the inheritance
access specifiers. It should be soon merged to the viewer-development repo.
Thanks for looking into it.
- Seth ProductEngine
On March 26, 2012, 12:23 a.m., Lance Corrimal wrote:
>
> ---
> This is an automatically
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/511/#review1071
---
Ship it!
- Seth
On Nov. 1, 2011, 7:36 a.m., Vadim ProductEngin
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/490/#review1051
---
Ship it!
- Seth
On Oct. 11, 2011, 10:48 a.m., Vadim ProductEng
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/485/#review1040
---
Ship it!
Looks good to me.
- Seth
On Sept. 29, 2011, 5:40 a.m
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/483/#review1037
---
Ship it!
- Seth
On Sept. 20, 2011, 2:41 p.m., Vadim ProductEng
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/482/#review1036
---
Ship it!
- Seth
On Sept. 20, 2011, 8:55 a.m., Vadim ProductEng
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/481/#review1035
---
Ship it!
Looks good.
- Seth
On Sept. 20, 2011, 8:44 a.m., Vad
t. 15, 2011, 2:57 p.m.)
>
>
> Review request for Viewer and Seth ProductEngine.
>
>
> Summary
> ---
>
> Replaced deprecated Google Translate v1 API with Google Translate v2 and Bing
> Translate APIs.
>
> Changes after https://codereview.secondlife.c
>
> (Updated Sept. 12, 2011, 5:28 p.m.)
>
>
> Review request for Viewer and Seth ProductEngine.
>
>
> Summary
> ---
>
> Replaced deprecated Google Translate v1 API with Google Translate v2 and Bing
> Translate APIs.
>
> Changes after https://codereview.se
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/464/#review1019
---
Ship it!
Looks good to me.
- Seth
On Sept. 7, 2011, 10:05 a.m
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/465/#review1017
---
Ship it!
looks good to me.
- Seth
On Sept. 7, 2011, 12:25 p.m
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/454/#review1010
---
Ship it!
Looks good.
- Seth
On Aug. 30, 2011, 10:20 a.m., Vad
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/461/#review1009
---
Ship it!
Looks good to me.
- Seth
On Aug. 31, 2011, 10:43 a.m
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/455/#review1008
---
Ship it!
- Seth
On Aug. 31, 2011, 3:18 a.m., Vadim ProductEngi
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/453/#review1004
---
Ship it!
- Seth
On Aug. 30, 2011, 4:51 a.m., Vadim ProductEngi
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/447/#review991
---
Ship it!
Looks good to me.
- Seth
On Aug. 22, 2011, 8:08 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/439/#review969
---
Ship it!
- Seth
On Aug. 12, 2011, 6:43 a.m., Vadim ProductEngin
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/430/#review952
---
Ship it!
Looks good to me.
- Seth
On Aug. 5, 2011, 7:53 a.m.,
a.m.)
>
>
> Review request for Viewer and Seth ProductEngine.
>
>
> Summary
> ---
>
> Fixed numerous missing and duplicated names in floater_build_options.xml and
> floater_model_wizard.xml.
>
>
> This addresses bug STORM-1540.
> http://jira.seco
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/426/#review947
---
Ship it!
- Seth
On Aug. 2, 2011, 8:40 a.m., Vadim ProductEngine
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/420/#review946
---
Ship it!
Looks good to me.
- Seth
On July 28, 2011, 7:29 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/421/#review944
---
Ship it!
Looks plausible.
- Seth
On July 29, 2011, 6:52 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/422/#review943
---
Ship it!
Looks good.
- Seth
On July 29, 2011, 7:05 a.m., Vadim
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/423/#review942
---
Ship it!
Looks good.
- Seth
On July 29, 2011, 8:01 a.m., Vadim
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/417/#review936
---
Ship it!
Looks good to me.
- Seth
On July 26, 2011, 2:02 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/418/#review935
---
Ship it!
The code looks perfect. No remarks, no objections.
- Se
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/413/#review930
---
Ship it!
Looks good.
- Seth
On July 25, 2011, 6:29 a.m., Vadim
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/409/#review918
---
Ship it!
Looks good to me.
- Seth
On July 22, 2011, 7:42 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/412/#review916
---
Ship it!
Looks like a duplicate of https://codereview.secondlife.
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/411/#review913
---
Ship it!
Looks good.
- Seth
On July 22, 2011, 9:02 a.m., Vadim
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/410/#review912
---
Ship it!
Works for me.
- Seth
On July 22, 2011, 8:41 a.m., Vad
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/400/
---
(Updated July 19, 2011, 7:20 a.m.)
Review request for Viewer.
Changes
---
m/r/400/#comment927>
Yes, there should be no "this" in this line.
- Seth
On July 18, 2011, 4:01 p.m., Seth ProductEngine wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://cod
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/400/
---
Review request for Viewer.
Summary
---
Hard coded dates made localizab
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/397/#review881
---
Ship it!
Looks good overall.
- Seth
On July 15, 2011, 9:13 a.m
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/396/#review876
---
Ship it!
Straightforward fix.
- Seth
On July 14, 2011, 2:15 a.
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/394/
---
Review request for Viewer and Richard Nelson.
Summary
---
Fixed text e
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/392/#review871
---
Ship it!
Looks pretty straightforward.
- Seth
On July 13, 2011
> On July 11, 2011, 8:56 a.m., Seth ProductEngine wrote:
> > Looks good.
> > Works for me.
>
> Boroondas Gupte wrote:
> Thanks for reviewing. As you write "Works for me.", I assume you tested
> it, too? Which languages did you try?
I te
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/387/#review856
---
Ship it!
Looks good.
Works for me.
- Seth
On July 10, 2011, 6:
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/386/#review852
---
Ship it!
Looks good.
- Seth
On July 8, 2011, 5:16 a.m., Paul P
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/385/#review850
---
Ship it!
- Seth
On July 7, 2011, 10:44 a.m., Vadim ProductEngin
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/384/#review848
---
Ship it!
- Seth
On July 7, 2011, 8:33 a.m., Vadim ProductEngine
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/382/#review846
---
Ship it!
Looks good to me.
- Seth
On July 6, 2011, 5:37 p.m.,
-
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/357/
> ---
>
> (Updated June 20, 2011, 8:21 p.m.)
>
>
> Review request for Viewer, Oz Linden, Seth ProductEngine
---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/357/
> ---
>
> (Updated June 20, 2011, 8:21 p.m.)
>
>
> Review request for Viewer, Oz Linden, Seth ProductEngine,
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/314/
---
Review request for Viewer.
Summary
---
SH-1549 WIP About Land floater
this case the LLMulitGesture class
becomes more complicated without any gain in performance because this is the
same check that LLGestureMgr::hasLoadingAssets() does.
- Seth
---
This is an automatically generated e-mail. To repl
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/274/
---
Review request for Viewer and Richard Nelson.
Summary
---
Fixed naviga
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/273/
---
Review request for Viewer and Richard Nelson.
Summary
---
Partial fix
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/249/
---
(Updated April 13, 2011, 8:11 a.m.)
Review request for Viewer.
Changes
--
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/261/
---
(Updated April 11, 2011, 9:27 a.m.)
Review request for Viewer.
Summary (u
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/261/
---
(Updated April 8, 2011, 5 p.m.)
Review request for Viewer.
Summary
--
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/261/
---
Review request for Viewer.
Summary
---
Fixed the inventory observers o
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/255/#review574
---
Ship it!
Looks good to me.
- Seth
On April 7, 2011, 4:20 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/249/
---
(Updated April 7, 2011, 4:16 p.m.)
Review request for Viewer.
Changes
---
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/250/#review555
---
Ship it!
- Seth
On April 5, 2011, 9 a.m., Seth ProductEngine
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/249/#review550
---
On April 4, 2011, 4:30 p.m., Seth ProductEngine wrote:
>
>
he patch by Richard Nelson at
https://codereview.secondlife.com/r/250/
- Seth
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/169/#review463
---
On March 4,
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/250/
---
Review request for Viewer.
Summary
---
Fix for text box clipping in a
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/249/
---
Review request for Viewer.
Summary
---
Fixed IM history to use the res
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/231/
---
(Updated March 31, 2011, 10:18 a.m.)
Review request for Viewer.
Changes
-
ld
> > potentially be delayed forever due to assets for other gestures being
> > loaded?
>
> Seth ProductEngine wrote:
> For now starting each new gesture resets the list of pending assets
> downloads so if the last started gesture's asset are loaded successfull
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/231/
---
(Updated March 28, 2011, 12:21 p.m.)
Review request for Viewer.
Changes
-
w.secondlife.com/r/231/#review508
---
On March 25, 2011, 5:33 p.m., Seth ProductEngine wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
7line1194>
> >
> > Can a gesture reference other asset types than animations and sounds?
> > And if it can, shouldn't those be removed from mLoadingAssets, too, once
> > loaded?
> >
> > If it can but shouldn't maybe some term
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/231/
---
Review request for Viewer.
Summary
---
First pass implementation of sy
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/219/
---
Review request for Viewer.
Summary
---
Fixed opening a floater contain
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/216/
---
Review request for Viewer and Vadim ProductEngine.
Summary
---
Agent's
gt; > rect
> >
> > what you want to do iscall mDocumentView->draw() inside the block that
> > has the clip operation and then hide the mDocumentView when calling
> > LLUICtrl::draw.
> >
> >
>
> Seth ProductEngine wrote:
> The
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/198/
---
(Updated March 17, 2011, 4:19 p.m.)
Review request for Viewer.
Changes
--
fe.com/r/175/
> ---
>
> (Updated March 17, 2011, 9:24 a.m.)
>
>
> Review request for Viewer and Seth ProductEngine.
>
>
> Summary
> ---
>
> Reason: The shortcut closes all floaters, including those wrapping undocked
>
On March 16, 2011, 7:30 a.m., Seth ProductEngine wrote:
> > So the new method might become something like
> >
> > void LLExpandableTextBox::LLTextBoxEx::hideOrShowExpandTextAsNeeded()
> > {
> > // Restore the text box contents to calculate the text height prope
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/198/
---
(Updated March 16, 2011, 5:19 p.m.)
Review request for Viewer.
Summary
--
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/198/
---
(Updated March 15, 2011, 9:21 a.m.)
Review request for Viewer.
Changes
--
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/198/
---
Review request for Viewer.
Summary
---
Fixed "More" link being toggled
a.m.)
>
>
> Review request for Viewer and Seth ProductEngine.
>
>
> Summary
> ---
>
> Let the user know what's wrong with external editor.
>
> Added meaningful messages for the following errors:
> * Editor not specified.
> * Error parsing comma
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/169/
---
(Updated March 4, 2011, 10:30 a.m.)
Review request for Viewer and Richard N
--
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/169/#review409
---
On March 1, 2011, 1:53 p.m., Seth ProductEngine wrote:
>
> ---
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/159/#review401
---
On March 2, 2011, 8:47 a.m., Seth ProductEngine wrote:
>
> ---
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/159/
---
(Updated March 2, 2011, 8:47 a.m.)
Review request for Viewer.
Changes
---
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/169/#review398
---
On March 1, 2011, 1:53 p.m., Seth ProductEngine wrote:
>
>
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/169/
---
Review request for Viewer.
Summary
---
Fixed text editor to display th
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/165/
---
Review request for Viewer.
Summary
---
Fixed the ability to select an
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/159/
---
Review request for Viewer.
Summary
---
- Added creating own calling ca
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/151/
---
Review request for Viewer.
Summary
---
Actual usernames are replaced w
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/146/#review349
---
Ship it!
- Seth
On Feb. 8, 2011, 11:26 a.m., Paul ProductEngine
other way. See
STORM-379.
- Seth
On Jan. 27, 2011, 4:05 p.m., Seth ProductEngine wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondli
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/138/
---
Review request for Viewer.
Summary
---
Fixed reshaping notification pa
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/130/#review285
---
The code looks good but I've uploaded nearly the same patch a day
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/128/
---
Review request for Viewer and Vadim ProductEngine.
Summary
---
- Added
ndlife.com/r/125/
> ---
>
> (Updated Jan. 27, 2011, 1:20 p.m.)
>
>
> Review request for Viewer and Seth ProductEngine.
>
>
> Summary
> ---
>
> Now when you change water color or density, the change
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/126/
---
Review request for Viewer.
Summary
---
Changed displaying the permissi
22, 2011, 7:40 a.m.)
>
>
> Review request for Viewer and Seth ProductEngine.
>
>
> Summary
> ---
>
> For the reason for this change, see
> https://jira.secondlife.com/browse/VWR-24487 and
> https://jira.secondlife.com/browse/VWR-24522
>
> What I did:
>
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/123/
---
Review request for Viewer and Nyx Linden.
Summary
---
Fixed TestCapabi
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/108/#review208
---
Ship it!
No missing string warnings while looking through the men
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/101/#review187
---
Ship it!
Looks good to me. Seems like adding another observer is
- Seth
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/77/#review170
---
On Jan. 17, 2011, 8:17 a.m., Seth ProductEngine wrote:
>
&
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/77/
---
(Updated Jan. 17, 2011, 8:17 a.m.)
Review request for Viewer.
Changes
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/77/
---
Review request for Viewer.
Summary
---
Added "Restore Item" context men
1 - 100 of 108 matches
Mail list logo
