----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/125/#review264 -----------------------------------------------------------
Ship it! Looks good to me. Seems that adding two more setting were necessary while editor presets are not persistent across sessions. - Seth On Jan. 27, 2011, 1:20 p.m., Vadim ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/125/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2011, 1:20 p.m.) > > > Review request for Viewer and Seth ProductEngine. > > > Summary > ------- > > Now when you change water color or density, the changes are saved until you > switch to another water preset. > > > This addresses bug STORM-610. > http://jira.secondlife.com/browse/STORM-610 > > > Diffs > ----- > > indra/newview/app_settings/settings.xml b542f8134a2b > indra/newview/llwaterparammanager.h b542f8134a2b > indra/newview/llwaterparammanager.cpp b542f8134a2b > > Diff: http://codereview.secondlife.com/r/125/diff > > > Testing > ------- > > Played with presets and sliders. The new behavior seems fine to me, although > it may be confusing that basic water settings are persistent, while sky > settings aren't. > > While working on this bug I've almost (~80%) implemented STORM-326 > (Persistent water/sky settings), so if anyone is interested I'd be happy to > complete that work. > > > Thanks, > > Vadim > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
