----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/130/#review285 -----------------------------------------------------------
The code looks good but I've uploaded nearly the same patch a day before: https://codereview.secondlife.com/r/128/. It is related to STORM-316 and includes some other code cleanup needed for that issue. It also adds "sort folders by name" option to inventory menu so perhaps we should go for my patch? - Seth On Jan. 29, 2011, 1:55 p.m., Kiptic Horsley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/130/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2011, 1:55 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > The constants SO_FOLDERS_BY_NAME (llinventoryfilter.h line 71) and > sort_folders_by_name (llpanelmaininventory.cpp line 125) already existed, so > added an option to use them to the inventory menu > (menu_inventory_gear_default.xml) and updated llpanelmaininventory.cpp to > handle the new option. > > > This addresses bug STORM-219. > http://jira.secondlife.com/browse/STORM-219 > > > Diffs > ----- > > indra/newview/llpanelmaininventory.cpp fe7fe04ccc9a > indra/newview/skins/default/xui/en/menu_inventory_gear_default.xml > fe7fe04ccc9a > > Diff: http://codereview.secondlife.com/r/130/diff > > > Testing > ------- > > > Thanks, > > Kiptic > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
