[opensource-dev] Review Request: Debugging autobuild post build re-configuration error.

2011-02-03 Thread Nicky Perian
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/137/ --- Review request for Viewer. Summary --- Print out failed build_config f

[opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition.

2011-02-03 Thread Nicky Perian
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/136/ --- Review request for Viewer. Summary --- This modification is a test cas

Re: [opensource-dev] Review Request: STORM-864: As as developer, I would like an object oriented wrapper to make safe use of memory pools easier

2011-02-03 Thread Aleric Inglewood
> On Feb. 2, 2011, 6:30 p.m., Merov Linden wrote: > > indra/llmessage/llpumpio.cpp, line 359 > > > > > > An example where the use of operator() is particularly unsightly... And rightfully so! It should be "extremely unpl

Re: [opensource-dev] Review Request: STORM-864: As as developer, I would like an object oriented wrapper to make safe use of memory pools easier

2011-02-03 Thread Aleric Inglewood
> On Jan. 31, 2011, 7:56 p.m., Merov Linden wrote: > > indra/llcommon/llaprpool.cpp, lines 206-207 > > > > > > K,it's just a paranoid assert. Still, I'm curious how you came up with > > the (*4) value. Also, not much poi

Re: [opensource-dev] Review Request: STORM-864: As as developer, I would like an object oriented wrapper to make safe use of memory pools easier

2011-02-03 Thread Aleric Inglewood
> On Feb. 2, 2011, 6:30 p.m., Merov Linden wrote: > > indra/llcommon/llaprpool.h, lines 107-116 > > > > > > I think it's be more clear to use an explicit name like "getAPRPool()" > > rather than the function operator her

Re: [opensource-dev] Review Request: VWR-24312: Massively duplicated objects (part 2)

2011-02-03 Thread Aleric Inglewood
> On Jan. 31, 2011, 6:44 p.m., Merov Linden wrote: > > @Aleric: OK, you convinced me on all accounts *except* for the ease of > > merge which I want to test myself before giving my blessing to this patch. > > You wouldn't be the first one be to claim that "it merges" and create some > > issues

Re: [opensource-dev] Review Request: VWR-24366: CMAKE_EXE_LINKER_FLAGS not honored when linking the viewer binary if -DLL_TESTS:BOOL=ON

2011-02-03 Thread Aleric Inglewood
> On Jan. 14, 2011, 5:27 p.m., Merov Linden wrote: > > Makes sense. *bump* Can this patch please be added to viewer-development soon? It's annoying that I can't even compile the viewer without having to apply local patches :/ (I just lost an hour because I didn't realize that this patch still

Re: [opensource-dev] Review Request: make PREHASH variables char const* const

2011-02-03 Thread Aleric Inglewood
> On Feb. 3, 2011, 6:35 p.m., Aleric Inglewood wrote: > > Can this patch please be added to viewer-development? It's getting really annoying that I have to apply patches to the soruce tree before it even can compile cleanly :(. - Aleric -

Re: [opensource-dev] Review Request: make PREHASH variables char const* const

2011-02-03 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/100/#review321 --- - Aleric On Jan. 22, 2011, 7:40 a.m., Boroondas Gupte wrote: >

Re: [opensource-dev] Review Request: Make autobuild-viewer work under Visual Studio 2005 Express Edition

2011-02-03 Thread Nicky Perian
> On Feb. 3, 2011, 1:59 p.m., Nicky Perian wrote: > > will redo looks like line ending problems. Reponed for comment. Don't know if it is line endings or normal operations that cause view diff to display the entire file. - Nicky --- T

Re: [opensource-dev] Review Request: Make autobuild-viewer work under Visual Studio 2005 Express Edition

2011-02-03 Thread Nicky Perian
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/134/ --- (Updated Feb. 3, 2011, 2:35 p.m.) Review request for Viewer. Summary

Re: [opensource-dev] Review Request: Make autobuild-viewer work under Visual Studio 2005 Express Edition

2011-02-03 Thread Nicky Perian
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/134/#review319 --- will redo looks like line ending problems. - Nicky On Feb. 3, 2

[opensource-dev] Review Request: Make autobuild-viewer work under Visual Studio 2005 Express Edition

2011-02-03 Thread Nicky Perian
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/134/ --- Review request for Viewer. Summary --- Make viewer-autobuild work unde

[opensource-dev] UI Hints - getting them again

2011-02-03 Thread Jonathan Welch
There is a menu control for UI Hints, but as there are only 10 of them, and you only get each one once, you might want to know how to reset them from their "has already been seen" state if you are debugging or doing development work. These settings are kept in ignorable_dialogs.xml in the same dir

[opensource-dev] Asstiance needed for STORM-236

2011-02-03 Thread WolfPup Lowenhar
After today's scrum meeting I started working on adding an new panel to the code to contain the resize handle for NearByChat and I'm having trouble figuring out how to add the panel to the code, it has been added to the xml, as there is no clear definition in the code for how the panels are read fr

[opensource-dev] Review Request: STORM-971 'Stop Tracking' menu item is still enabled in Mini-map floater after you stopped tracking in Nearby mini-map

2011-02-03 Thread Twisted Laws
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/133/ --- Review request for Viewer. Summary --- Sets "Stop Tracking" enabled ba

Re: [opensource-dev] Need Clarification on interfacing with web-based UI elements

2011-02-03 Thread Kadah
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 It would have been nice if web profiles had been done in something like XSLT instead :P Raw profile data can easily be converted or stored into XML and presintation would be taken care of by Webkit's libxslt. On 2/3/2011 9:01 AM, Oz Linden (Scott Lawr

Re: [opensource-dev] autobuild and vsexpress

2011-02-03 Thread Nicky Perian
sure, Be later today or first thing in the morning at -6GMT. From: Oz Linden (Scott Lawrence) To: Nicky Perian Cc: opensource-dev@lists.secondlife.com; robin.cornel...@gmail.com Sent: Thu, February 3, 2011 11:05:12 AM Subject: Re: autobuild and vsexpress On 2

Re: [opensource-dev] PO Test build (sprint 10 end game)

2011-02-03 Thread Anya Kanevsky
Thank you, Merov! Yes, this build works, issues that were fixed are actually fixed and all is well with the world! 2011/2/3 Philippe (Merov) Bossut > On Thu, Feb 3, 2011 at 12:51 AM, Anya Kanevsky < > akanev...@productengine.com> wrote: > >> Merov, are you sure this build is correct? I tried al

Re: [opensource-dev] autobuild and vsexpress

2011-02-03 Thread Oz Linden (Scott Lawrence)
On 2011-02-03 11:54, Nicky Perian wrote: If anyone wants to help bring autobuild to vsexpress here are two starter(1commit each) repositories. http://nic...@bitbucket.org/NickyP/viewer-autobuild-express-wip http://nic...@bitbucket.org/NickyP/autobuild-vcexpress-wip I was able to make a warts an

Re: [opensource-dev] Need Clarification on interfacing with web-based UI elements

2011-02-03 Thread Oz Linden (Scott Lawrence)
On 2011-02-03 11:13, Arrehn Oberlander wrote: > I'm concerned that I haven't received a response. I've already asked > this question a few times at office hours for Lindens involved in > development, and now here. Even if the answer is "LL will not support > a a stable API to web services" at le

[opensource-dev] autobuild and vsexpress

2011-02-03 Thread Nicky Perian
If anyone wants to help bring autobuild to vsexpress here are two starter(1commit each) repositories. http://nic...@bitbucket.org/NickyP/viewer-autobuild-express-wip http://nic...@bitbucket.org/NickyP/autobuild-vcexpress-wip I was able to make a warts and all build of LindenDeveloper.exe and log

Re: [opensource-dev] PO Test build (sprint 10 end game)

2011-02-03 Thread Philippe (Merov) Bossut
On Thu, Feb 3, 2011 at 12:51 AM, Anya Kanevsky wrote: > Merov, are you sure this build is correct? I tried all issues in the list > with this build (220162) and each one failed. > > Strange. I just noticed that TC fired 2 builds in rapid succession, each pointing to the same set of changes. Can y

Re: [opensource-dev] Review Request: STORM-465 Missing Strings from strings.xml

2011-02-03 Thread Kent Quirk
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/108/#review318 --- Ship it! I'm happy now. :) - Kent On Feb. 3, 2011, 8:20 a.m.,

Re: [opensource-dev] Review Request: STORM-465 Missing Strings from strings.xml

2011-02-03 Thread Vadim ProductEngine
> On Feb. 2, 2011, 8:56 a.m., Kent Quirk wrote: > > So I have a couple of issues with this patch: > > > > * I'm worried about the translation impact, how these strings are used and > > where. Should they be localized? Should they not be localized? I find it > > hard to believe that we ONLY nee

Re: [opensource-dev] Review Request: STORM-465 Missing Strings from strings.xml

2011-02-03 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/108/ --- (Updated Feb. 3, 2011, 8:20 a.m.) Review request for Viewer. Changes

Re: [opensource-dev] Need Clarification on interfacing with web-based UI elements

2011-02-03 Thread Arrehn Oberlander
I'm concerned that I haven't received a response. I've already asked this question a few times at office hours for Lindens involved in development, and now here. Even if the answer is "LL will not support a a stable API to web services" at least it is some kind of answer. "LL will continue to provi

Re: [opensource-dev] Review Request: VWR-17050 No nearby people when over approxiamately 1000 meters

2011-02-03 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/132/#review316 --- Ship it! - Oz On Feb. 2, 2011, 3:39 p.m., Twisted Laws wrote: >

Re: [opensource-dev] PO Test build (sprint 10 end game)

2011-02-03 Thread Anya Kanevsky
Merov, are you sure this build is correct? I tried all issues in the list with this build (220162) and each one failed. a 2011/2/2 Philippe (Merov) Bossut > Hi guys, > > Here are the binaries for the rest of sprint 10 bugs waiting for PO > approval (+ 1 sprint 11): > > http://automated-builds-s