-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/133/
-----------------------------------------------------------
Review request for Viewer.
Summary
-------
Sets "Stop Tracking" enabled based on tracking if true or false instead of only
when true. Also made it check for menu pointer validity to remove a remote
crash possiblity.
This addresses bug STORM-971.
http://jira.secondlife.com/browse/STORM-971
Diffs
-----
indra/newview/llnetmap.cpp ec4a9fd30688
Diff: http://codereview.secondlife.com/r/133/diff
Testing
-------
My testing was to open the side panel nearby, and verify that the state of the
menu was correct when tracking by the different methods and disabled. Then
leaving that open, openned a mini-map instance and repeated testing its state
tracking and not. Also tried the reverse. Verified that every possibility I
could think of, the state of both menus was always correct.
Correct state is Stop Tracking is enabled anytime tracking is on for avatars or
landmarks and is not enabled when Tracking has been stopped no matter where you
stopped tracking (i.e, clicking on red arrow in view window, and using the
various menues).
Thanks,
Twisted
_______________________________________________
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges
