Re: [opensource-dev] Review Request: make PREHASH variables char const* const

2011-01-21 Thread Merov Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/100/#review243 --- Ship it! Not a fan of widespread cleanup changes as I said in a p

[opensource-dev] google-breakpad VS2010 build project. Linden Dev Help Please.

2011-01-21 Thread Nicky Perian
I am trying to prove a no harm done 2005 build first. Then on to 2010. the build-cmd.sh script references "build_sln" for several entries. Example: build_sln src/client/windows/breakpad_client.sln "release|win32" exception_handler These all fail when I try them. Is build_sln common to the LL bui

Re: [opensource-dev] Review Request: Help Needed to debug small problem with code for STORM-236.

2011-01-21 Thread Merov Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/112/#review242 --- Ship it! Good code wise. Please keep comments short and clean.

Re: [opensource-dev] Review Request: VWR-24321: Validate textures starting with 00 too.

2011-01-21 Thread Merov Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/90/#review241 --- Ship it! Ok, I read the code in more details and I'm indeed convin

Re: [opensource-dev] Review Request: STORM-2 As a User, I want to set my own default views with specific UI layout so I can tailor my Viewer experience to the activities I'm most interested in.

2011-01-21 Thread Merov Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/98/#review240 --- Ship it! Good. Adding my stamp of approval. - Merov On Jan. 17,

Re: [opensource-dev] Review Request: STORM-236 Actual Code Review

2011-01-21 Thread Cron Stardust
> On Jan. 21, 2011, 3:44 a.m., Boroondas Gupte wrote: > > indra/newview/skins/default/xui/en/menu_bottomtray.xml, lines 11-13 > > > > > > Begin XML comments with just "", not > > "". Typically SGML/XML comments are supp

Re: [opensource-dev] Review Request: STORM-2 As a User, I want to set my own default views with specific UI layout so I can tailor my Viewer experience to the activities I'm most interested in.

2011-01-21 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/98/#review238 --- decided this morning that this change will not be integrated yet, s

[opensource-dev] line ordering in contributions.txt

2011-01-21 Thread Oz Linden (Scott Lawrence)
> Actually, because I use changes to this file to generate some of our metrics > for open source contributions, I'd prefer that any existing order be > preserved: that is, add lines as needed (and adding them in order is nice), > but do not reorder existing lines please. I've fixed my script -

Re: [opensource-dev] Review Request: VWR-24337: Possible crash on llassert_always(purge_list.size() >= entries_to_purge)

2011-01-21 Thread Merov Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/93/#review237 --- Ship it! Better! You may want to reword a bit the comment above th

Re: [opensource-dev] Review Request: STORM-236 Actual Code Review

2011-01-21 Thread Merov Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/113/#review236 --- indra/newview/llbottomtray.cpp

Re: [opensource-dev] Review Request: STORM-236 Actual Code Review

2011-01-21 Thread Opensource Obscure
It seems it works as expected on Linux after some testing (2.6.0 (219418)). The UI works fine, but I didn't use voice during the tests. I don't know if this is by design, but I'll add that: - when you disable Voice, the Speak Button correctly disappears - this doesn't happen if you disable the who

Re: [opensource-dev] FW: [JIRA] Commented: (STORM-236) Allow the "Speak" button to be removed, like other buttons

2011-01-21 Thread Trilo Byte
Works great in the Mac client. Sounds nitpicky, but I'd add a space after "Speak Button" and before "(Voice Enabled" in the menu On Jan 21, 2011, at 8:41 AM, WolfPup Lowenhar wrote: > Please Help test this. > > From: Oz Linden (JIRA) [mailto:no-re...@secondlife.com] > Sent: Friday, January

Re: [opensource-dev] Review Request: STORM-236 Actual Code Review

2011-01-21 Thread Alexandrea Fride
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/113/#review235 --- Perfect just the naming in menu should be better "Speak button (en

[opensource-dev] FW: [JIRA] Commented: (STORM-236) Allow the "Speak" button to be removed, like other buttons

2011-01-21 Thread WolfPup Lowenhar
Please Help test this. From: Oz Linden (JIRA) [mailto:no-re...@secondlife.com] Sent: Friday, January 21, 2011 10:57 AM To: wolfpu...@earthlink.net Subject: [JIRA] Commented: (STORM-236) Allow the "Speak" button to be removed, like other buttons [ https://jira.secondlife.com/browse

[opensource-dev] Link times revisited

2011-01-21 Thread Jonathan Welch
This is a follow up to my earlier Link Times message. I just upgraded my system from 2Gb to 4Gb, though it only shows 3Gb as being available (the joys of 32-bit Windows XP). 1st2nd pass CV 0:53 0:24 2Gb (CV = Cool Rainbow Viewer, based on v1.22) 0:58 0:26 3Gb SG 3:30 2:07

Re: [opensource-dev] Review Request: VWR-24312: Massively duplicated objects (part 2)

2011-01-21 Thread Aleric Inglewood
> On Jan. 20, 2011, 10:57 p.m., Merov Linden wrote: > > I fail to see how any of those changes "massively prevents object > > duplication". I don't disagree with any of them but I don't see much value > > in any either. Sure, there are different ways to skin a cat and some are > > better. Stil

Re: [opensource-dev] Review Request: STORM-236 Actual Code Review

2011-01-21 Thread Boroondas Gupte
> On Jan. 21, 2011, 3:44 a.m., Boroondas Gupte wrote: > > indra/newview/llspeakbutton.cpp, lines 67-70 > > > > > > Please don't remove the single empty line between the end of one method > > and the beginning of the next

Re: [opensource-dev] Review Request: VWR-24312: Massively duplicated objects (part 2)

2011-01-21 Thread Aleric Inglewood
> On Jan. 14, 2011, 1:31 p.m., Boroondas Gupte wrote: > > indra/llcommon/lllslconstants.h, line 184 > > > > > > Yay for having type modifiers after the core type name. Makes them much > > easier to understand, especially

Re: [opensource-dev] Review Request: VWR-24520: Don't use pkg_check_modules( ... QUIET ) on CMake < 2.8.2

2011-01-21 Thread Boroondas Gupte
> On Jan. 20, 2011, 11:33 p.m., Merov Linden wrote: > > I'm advising the MM to merge in a test repo and do a full TC cycle on all > > platforms before merging though... As far as I can see indra/cmake/FindLLQtWebkit.cmake only gets called by indra/cmake/WebKitLibPlugin.cmake (through find_pack

Re: [opensource-dev] Review Request: VWR-24337: Possible crash on llassert_always(purge_list.size() >= entries_to_purge)

2011-01-21 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/93/ --- (Updated Jan. 21, 2011, 4:25 a.m.) Review request for Viewer. Changes

Re: [opensource-dev] Review Request: STORM-236 Actual Code Review

2011-01-21 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/113/#review230 --- Looks like RB ate some of my comments in the review above. (Maybe

Re: [opensource-dev] Review Request: STORM-236 Actual Code Review

2011-01-21 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/113/#review229 --- indra/newview/llbottomtray.h