It seems it works as expected on Linux after some testing (2.6.0 (219418)). The UI works fine, but I didn't use voice during the tests.
I don't know if this is by design, but I'll add that: - when you disable Voice, the Speak Button correctly disappears - this doesn't happen if you disable the whole SL audio system Thanks for this feature! Opensource Obscure On Fri, Jan 21, 2011 at 18:06, Alexandrea Fride <babytje...@live.com> wrote: > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/113/ > > Perfect just the naming in menu should be better "Speak button (enables voice > chat)" like boroondas sayd :) (and mayby the styling fixed or so but patch > works as exspected) > > tested patch and test build both worked as exspected > > nice job > > > - Alexandrea > > On January 20th, 2011, 6:37 p.m., Wolfpup Lowenhar wrote: > Review request for Viewer. > By Wolfpup Lowenhar. > > *Updated Jan. 20, 2011, 6:37 p.m.* > Description > > This allows the Speak Button to auto-hide for those that do not use Voice at > all. > > Testing > > Built locally and did the following: > 1 Verified that when Voice is toggled via the preference panel the Speak > Button auto hid/showed. > 2 Verified that drag and drop functionality of the Speak Button was not > affected. > 3 Went to a non-Voice area with Voice active and verified that button was > still there but grayed out. > > *Bugs: * STORM-236 <http://jira.secondlife.com/browse/STORM-236> > Diffs > > - doc/contributions.txt (9c7d543fd15d) > - indra/newview/llbottomtray.h (9c7d543fd15d) > - indra/newview/llbottomtray.cpp (9c7d543fd15d) > - indra/newview/llspeakbutton.cpp (9c7d543fd15d) > - indra/newview/skins/default/xui/en/menu_bottomtray.xml (9c7d543fd15d) > > View Diff <http://codereview.secondlife.com/r/113/diff/> > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges > -- *Opensource Obscure* Twitter <http://twitter.com/oobscure> [EN] - Twitter<http://twitter.com/opensl> [IT] - Blog <http://opensourceobscure.com> [IT] - YouTube<http://youtube.com/opensourceobscure> - Photos<http://www.sluniverse.com/pics/ProfilePage.aspx?Name=Opensource+Obscure> - Second Life<http://world.secondlife.com/resident/eb42408b-5888-42b7-80d6-b00ca2eb9781>
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
