Re: [Openocd-development] Change in openocd[master]: jlink libusb1 driver with libusb1 common driver interface.

2011-10-20 Thread Mauro Gamba
I think that Xiofan suggest the good direction of developement. So I think to proceed in this way: - Add to the configuration step the possibility to choose which usb library to use. - Create an abstraction layer to the usb library with all the necessary functions for the drivers. - Modify the dri

Re: [Openocd-development] Gerrit background

2011-10-20 Thread Xiaofan Chen
On Fri, Oct 21, 2011 at 1:15 PM, Øyvind Harboe wrote: >> That is of course right. But that does not answer my question. >> I think it is good to change the wording of "-1" to something >> like "some changes are necessary before this patch can be >> accepted". > > I think most people will understan

Re: [Openocd-development] Gerrit background

2011-10-20 Thread Øyvind Harboe
> That is of course right. But that does not answer my question. > I think it is good to change the wording of "-1" to something > like "some changes are necessary before this patch can be > accepted". I think most people will understand that this is a textstring within Gerrit. Perhaps you can ta

Re: [Openocd-development] Gerrit background

2011-10-20 Thread Xiaofan Chen
On Fri, Oct 21, 2011 at 12:32 AM, Peter Stuge wrote: > Xiaofan Chen wrote: >> Then please change the wording of "-1" >> >> "+1 Looks good to me, but someone else must approve >> 0 No score >> -1 I would prefer that you didn't submit this" >> >> If the contributor see a -1 and refer to the above, >

Re: [Openocd-development] Command-line paths problem in Windows

2011-10-20 Thread Andrew Leech
On 21/10/2011 3:04 AM, Freddie Chopin wrote: 1. In 0.5.0 you could use slash or backslash (which is more "correct" in Windows) - no difference. Now only slash works, backslash is ommited and replaced with... nothing... 2. When running OpenOCD as External Tool from Eclipse I always left "Working

Re: [Openocd-development] Gerrit background

2011-10-20 Thread Peter Stuge
Xiaofan Chen wrote: > >> I think some changes are necessary. > > > > This is what you say with -1. .. > Then please change the wording of "-1" > > "+1 Looks good to me, but someone else must approve > 0 No score > -1 I would prefer that you didn't submit this" > > If the contributor see a -1 and

Re: [Openocd-development] Building OpenOCD for Windows

2011-10-20 Thread Freddie Chopin
On 2011-10-20 01:42, Peter Stuge wrote: Maybe you can also describe how you build them? No magic here - it's just much simpler to do crosscompilation on Linux than fighting natively in Windows. The cause of problems in Windows is that OpenOCD needs many tools to be compiled. libftdi needs eve

Re: [Openocd-development] Building OpenOCD for Windows

2011-10-20 Thread Freddie Chopin
Hi! I've prepared a package but I've found "an inconvenience" in handling paths in new version (see other thread) so I'll see whether there's a will and possibility to fix/change that before publishing. If you need it now I can send you the package. 4\/3!! ___

[Openocd-development] Command-line paths problem in Windows

2011-10-20 Thread Freddie Chopin
Hi! The most recent OpenOCD behaves differently on Windows than 0.5.0 (and before) and in my opinion the direction of change is to worse. OpenOCD 0.5.0 could be run this way: > openocd -f interface/jtagkey.cfg -f target/stm32.cfg And it worked fine. Current OpenOCD when trying this gives: > Ru

Re: [Openocd-development] Gerrit background

2011-10-20 Thread Xiaofan Chen
On Thu, Oct 20, 2011 at 9:14 PM, Peter Stuge wrote: > Xiaofan Chen wrote: >> "-1" is too harsh in the case of the J-Link libusb-1.0 patch. > > I think it fits, because: > >> I think some changes are necessary. > > This is what you say with -1. You don't think this should be added > exactly as-is.

Re: [Openocd-development] Gerrit background

2011-10-20 Thread Peter Stuge
Xiaofan Chen wrote: > "-1" is too harsh in the case of the J-Link libusb-1.0 patch. I think it fits, because: > I think some changes are necessary. This is what you say with -1. You don't think this should be added exactly as-is. It can sometimes be nice to use the comment field in addition to i

Re: [Openocd-development] arm-jtag-ew + swd

2011-10-20 Thread Tomek CEDRO
On Thu, Oct 20, 2011 at 4:59 AM, Peter Stuge wrote: > 1. Continue what David Brownell worked on for FT2232-based adapters > 2. Try Tomek's libswd, which I think works so far primarily with >   (only some?) FT2232-based adapters These are now joined into one :-) Transport and driver for ft2232 are

Re: [Openocd-development] Gerrit background

2011-10-20 Thread Xiaofan Chen
On Thu, Oct 20, 2011 at 7:59 PM, Xiaofan Chen wrote: > On Thu, Oct 20, 2011 at 3:33 PM, Øyvind Harboe > wrote: >> Still you can get a Gerrit account to read over patches and >> give comments!  All you need is a web browser, you can do it on the >> train using your cell phone if you're a commuter

Re: [Openocd-development] Gerrit background

2011-10-20 Thread Xiaofan Chen
On Thu, Oct 20, 2011 at 3:33 PM, Øyvind Harboe wrote: >> I agree, this is great work. >> >> I am not a programmer myself and  I can only contribute by >> testing or provide some suggestions based on my experiences >> with testing of other projects (libusb, libusb-win32, libftdi, etc). >> So I am k

Re: [Openocd-development] gitweb down?

2011-10-20 Thread Spencer Oliver
On 20 October 2011 12:06, Spencer Oliver wrote: > On 20 October 2011 11:49, Uwe Hermann wrote: >> Hi, >> >> seems like the gitweb for OpenOCD is down? E.g. the links such as >> http://openocd.zylin.com/gitweb/?p=openocd.git;a=commit;h=a756b1bcdffef34a6d60d7a2706da9574663f544 >> no longer work (th

Re: [Openocd-development] gitweb down?

2011-10-20 Thread Spencer Oliver
On 20 October 2011 11:49, Uwe Hermann wrote: > Hi, > > seems like the gitweb for OpenOCD is down? E.g. the links such as > http://openocd.zylin.com/gitweb/?p=openocd.git;a=commit;h=a756b1bcdffef34a6d60d7a2706da9574663f544 > no longer work (they did yesterday). There are links from Gerrits pages to

Re: [Openocd-development] [PATCH] Unused variables

2011-10-20 Thread Øyvind Harboe
> What exactly is checked by jenkins currently? I suggest at least one > build with the default "./configure" (no options) and one with as many > "./configure" options enabled as is possible on the build host. It's very early days still and we're still sorting out problems. We have ambitions to d

Re: [Openocd-development] [PATCH] Unused variables

2011-10-20 Thread Uwe Hermann
On Wed, Oct 19, 2011 at 08:32:42PM +0200, Øyvind Harboe wrote: > - Jenkins will build and check your patch for warnings. If you generate > warnings in some of the configurations that Jenkins checks for, you will > get an email w/info about that. No other humans will waste time on your > patch befor

[Openocd-development] gitweb down?

2011-10-20 Thread Uwe Hermann
Hi, seems like the gitweb for OpenOCD is down? E.g. the links such as http://openocd.zylin.com/gitweb/?p=openocd.git;a=commit;h=a756b1bcdffef34a6d60d7a2706da9574663f544 no longer work (they did yesterday). There are links from Gerrits pages to the gitweb install, for example (and that's a good thi

Re: [Openocd-development] Only every second programming works

2011-10-20 Thread Peter Stuge
Akos Vandra wrote: > I know what TRST is, but not SRST. Would it be the "normal" chip > reset? Right, system reset. //Peter ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-deve

Re: [Openocd-development] Only every second programming works

2011-10-20 Thread Akos Vandra
I know what TRST is, but not SRST. Would it be the "normal" chip reset? Ákos On 20 October 2011 11:12, Peter Stuge wrote: > Akos Vandra wrote: >> 1.  (in reply to freddie choppin) >> As far as I understand, reset halt is not supported on my target >> because srst pulls trst. > > Note that this w

Re: [Openocd-development] Only every second programming works

2011-10-20 Thread Peter Stuge
Akos Vandra wrote: > 1. (in reply to freddie choppin) > As far as I understand, reset halt is not supported on my target > because srst pulls trst. Note that this was set incorrectly for the lpc17xx chip. Double check if the setting in openocd really actually matches your hardware. You need to ch

Re: [Openocd-development] Only every second programming works

2011-10-20 Thread Akos Vandra
I just realized I hit "reply" for all previous emails, so I did not send them to the list. I'll copy paste them below. I am converting the elf to bin to be able to correct the checksum afterwards with a little tool I wrote. This way openocd does not emit warnings about the verification failiure.

Re: [Openocd-development] Building OpenOCD for Windows

2011-10-20 Thread Xiaofan Chen
On Thu, Oct 20, 2011 at 7:42 AM, Peter Stuge wrote: > Freddie Chopin wrote: >> I guess it's right time for me to provide a new development version >> on my website... > > Maybe you can also describe how you build them? > Freddie does provide a simple description about the build in his package. +

Re: [Openocd-development] [PATCH] Unused variables

2011-10-20 Thread Attila Kinali
On Thu, 20 Oct 2011 07:18:18 +0200 Peter Stuge wrote: > You need an OpenID from somewhere (let me know if you want one from me) > You need to register on a web page and pick a username > You need to set an HTTP password or upload a public SSH key > > The above takes not two minutes. If you have

Re: [Openocd-development] Gerrit background

2011-10-20 Thread Øyvind Harboe
> I agree, this is great work. > > I am not a programmer myself and  I can only contribute by > testing or provide some suggestions based on my experiences > with testing of other projects (libusb, libusb-win32, libftdi, etc). > So I am kind of an "outsider" of this git/gerrit stuff (I admit I > kn

Re: [Openocd-development] Gerrit background

2011-10-20 Thread Xiaofan Chen
On Thu, Oct 20, 2011 at 3:23 PM, Øyvind Harboe wrote: > First of all, I'd like everybody to stand up and give a big hand to Spencer > who's through his efforts has saved OpenOCD from a slow torturous demise! > ... > Who knows what percentage of fixes to OpenOCD that ever make > it into the reposit

[Openocd-development] Gerrit background

2011-10-20 Thread Øyvind Harboe
First of all, I'd like everybody to stand up and give a big hand to Spencer who's through his efforts has saved OpenOCD from a slow torturous demise! Why was Gerrit introduced? In some ways nothing has changed when we switched to Gerrit. Before Gerrit, OpenOCD maintainers had stopped lifting

Re: [Openocd-development] [PATCH] Unused variables

2011-10-20 Thread Øyvind Harboe
Actually, in some ways nothing has changed when we switched to Gerrit. Before Gerrit, OpenOCD maintainers had stopped lifting patches into git and now we don't lift them into Gerrit. Same thing, except with Gerrit contributors (or anyone) have the option of lifting patches into Gerrit themselves.