On Fri, Oct 21, 2011 at 12:32 AM, Peter Stuge <pe...@stuge.se> wrote: > Xiaofan Chen wrote: >> Then please change the wording of "-1" >> >> "+1 Looks good to me, but someone else must approve >> 0 No score >> -1 I would prefer that you didn't submit this" >> >> If the contributor see a -1 and refer to the above, >> I do not think it is that encouraging. :-). > > I think it is very important to always write some explanations for > why a change should not be submitted (which is the Gerrit term for > adding the change into the public repository), so that the > contributor knows why the change is not yet acceptable.
That is of course right. But that does not answer my question. I think it is good to change the wording of "-1" to something like "some changes are necessary before this patch can be accepted". -- Xiaofan _______________________________________________ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
