On Thu, Oct 20, 2011 at 9:14 PM, Peter Stuge <pe...@stuge.se> wrote: > Xiaofan Chen wrote: >> "-1" is too harsh in the case of the J-Link libusb-1.0 patch. > > I think it fits, because: > >> I think some changes are necessary. > > This is what you say with -1. You don't think this should be added > exactly as-is. It can sometimes be nice to use the comment field in > addition to inline comments, to expand a little in general on the > chosen scoring and what needs further improvement, if that isn't > clear from inline comments already. > > -1 isn't "Never ever" but rather "Not yet". The "what is missing" has > to be explained manually, which I think is a very important step. > (Ie. writing concrete comments, as you did.) >
Then please change the wording of "-1" "+1 Looks good to me, but someone else must approve 0 No score -1 I would prefer that you didn't submit this" If the contributor see a -1 and refer to the above, I do not think it is that encouraging. :-). -- Xiaofan _______________________________________________ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
