On Tue, 28 Jun 2022 15:29:41 GMT, Marius Hanl wrote:
>> This simple PR optimizes the observable `ArrayList` creation by using the
>> ArrayList constructor/array size so that the underlying array will be
>> initialized at the correct size which will speed up the creation as the
>> array does no
On Tue, 28 Jun 2022 16:56:27 GMT, Marius Hanl wrote:
>> modules/javafx.base/src/main/java/javafx/collections/FXCollections.java line
>> 351:
>>
>>> 349: public static ObservableList observableArrayList(E...
>>> items) {
>>> 350: ArrayList backingList = new ArrayList<>(items.length
On Mon, 27 Jun 2022 23:19:36 GMT, Andy Goryachev wrote:
> summary of changes:
> - fixed .classpath files
> - set UTF-8 encoding in the eclipse project config files
> - fixed gradlew to use UTF-8 encoding
There is already an open issue for this in
[JDK-8221708](https://bugs.openjdk.org/browse/JD
On Tue, 28 Jun 2022 00:13:40 GMT, Andy Goryachev wrote:
> I would definitely volunteer to review the remaining changes (once I
> accumulate enough karma).
Maybe that's the trick. If I make the changes, it requires another Reviewer to
allow me to merge, and there were (are?) no volunteers. If s
On Mon, 27 Jun 2022 23:19:36 GMT, Andy Goryachev wrote:
> summary of changes:
> - fixed .classpath files
> - set UTF-8 encoding in the eclipse project config files
I scheduled to review this today or tomorrow.
-
PR: https://git.openjdk.org/jfx/pull/804
On Tue, 28 Jun 2022 15:29:41 GMT, Marius Hanl wrote:
>> This simple PR optimizes the observable `ArrayList` creation by using the
>> ArrayList constructor/array size so that the underlying array will be
>> initialized at the correct size which will speed up the creation as the
>> array does no
On Fri, 1 Jul 2022 12:16:36 GMT, Marius Hanl wrote:
>> This simple PR optimizes the observable `ArrayList` creation by using the
>> ArrayList constructor/array size so that the underlying array will be
>> initialized at the correct size which will speed up the creation as the
>> array does not
On Mon, 27 Jun 2022 23:19:36 GMT, Andy Goryachev wrote:
> summary of changes:
> - fixed .classpath files
> - set UTF-8 encoding in the eclipse project config files
I found my branch that was dealing with the Eclipse files update:
https://github.com/openjdk/jfx/compare/master...nlisker:jfx:82217
On Fri, 1 Jul 2022 15:16:24 GMT, John Hendrikx wrote:
>> This is an implementation of the proposal in
>> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker
>> (@nlisker) have been working on. It's a complete implementation including
>> good
On Sat, 12 Mar 2022 04:57:37 GMT, Michael Strauß wrote:
> `Observable{List/Set/Map}Wrapper.retainAll/removeAll` can be optimized for
> some edge cases.
>
> 1. `removeAll(c)`:
> This is a no-op if 'c' is empty.
> For `ObservableListWrapper`, returning early skips an object allocation. For
> `Ob
On Tue, 5 Jul 2022 17:50:26 GMT, Andy Goryachev wrote:
>> modules/javafx.graphics/.classpath line 5:
>>
>>> 3:
>>> 4:
>>> 5:
>>
>> I think that you can remove these source folders too.
>>
>> Did you get errors with `build/hlsl/Decora` and `build/hlsl/Prism`? These
>> are generated for W
On Tue, 5 Jul 2022 17:52:24 GMT, Andy Goryachev wrote:
>> modules/javafx.swing/.classpath line 9:
>>
>>> 7:
>>> 8:
>>> 9:
>>
>> This folder doesn't exist, it should be giving you an error, does it not?
>
> line 4 is
>
> shims seem to be required, notice you get a bunch of shim-r
On Tue, 5 Jul 2022 19:02:20 GMT, Andy Goryachev wrote:
>> FWIW, the only test in `modules/javafx.swing/src/test/java` was removed by
>> [JDK-8234110](https://bugs.openjdk.org/browse/JDK-8234110). While we could
>> put in a dummy test class, the nature of the javafx.swing module is that
>> unit
On Tue, 5 Jul 2022 18:49:40 GMT, Andy Goryachev wrote:
>> 1. The way the apps are structured is that each app is its own project,
>> which means that there are many new projects to create and configure. It can
>> be a bit of work, though I have done it in my branch already. If you want to
>> l
On Fri, 1 Jul 2022 15:16:24 GMT, John Hendrikx wrote:
>> This is an implementation of the proposal in
>> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker
>> (@nlisker) have been working on. It's a complete implementation including
>> good
On Wed, 6 Jul 2022 18:16:02 GMT, Andy Goryachev wrote:
> - changed initialization sequence
Marked as reviewed by nlisker (Reviewer).
-
PR: https://git.openjdk.org/jfx/pull/815
On Wed, 6 Jul 2022 18:12:42 GMT, Andy Goryachev wrote:
> - removed unused method
Marked as reviewed by nlisker (Reviewer).
-
PR: https://git.openjdk.org/jfx/pull/814
On Wed, 6 Jul 2022 21:38:36 GMT, Andy Goryachev wrote:
>> summary of changes:
>> - fixed .classpath files
>> - set UTF-8 encoding in the eclipse project config files
>
> Andy Goryachev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8289255
On Wed, 6 Jul 2022 21:38:36 GMT, Andy Goryachev wrote:
>> summary of changes:
>> - fixed .classpath files
>> - set UTF-8 encoding in the eclipse project config files
>
> Andy Goryachev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8289255
On Wed, 6 Jul 2022 21:38:36 GMT, Andy Goryachev wrote:
>> summary of changes:
>> - fixed .classpath files
>> - set UTF-8 encoding in the eclipse project config files
>
> Andy Goryachev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8289255
On Thu, 7 Jul 2022 20:47:41 GMT, Andy Goryachev wrote:
> Let me see what it would take to create individual projects for toys and such.
You can look at my branch, it does exactly that, and I added all the module
reads/exports (unless something changed).
-
PR: https://git.openjdk.o
On Wed, 6 Jul 2022 21:38:36 GMT, Andy Goryachev wrote:
>> summary of changes:
>> - fixed .classpath files
>> - set UTF-8 encoding in the eclipse project config files
>
> Andy Goryachev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8289255
On Wed, 6 Jul 2022 21:38:36 GMT, Andy Goryachev wrote:
>> summary of changes:
>> - fixed .classpath files
>> - set UTF-8 encoding in the eclipse project config files
>
> Andy Goryachev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8289255
On Thu, 7 Jul 2022 20:37:29 GMT, Andy Goryachev wrote:
> This PR does not fix apps/ project. In fact, I think .project in apps/ should
> be removed, and instead we should create individual projects, either for a
> group (i.e. samples, toys), or for each application (i.e. Robot, 3DViewer).
>
>
On Thu, 7 Jul 2022 02:31:54 GMT, Nir Lisker wrote:
>> John Hendrikx has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 27 addi
On Thu, 7 Jul 2022 22:26:17 GMT, Andy Goryachev wrote:
> No, my workspace (jfx) was imported as a gradle project. I think it created a
> bunch of .project and .classpath files that never worked - I could not get
> them to compile. I had to reset all of them
That's what I wrote in the instructi
Vote: YES
On Fri, Jul 8, 2022 at 8:37 PM Kevin Rushforth
wrote:
> I hereby nominate Marius Hanl [1] to OpenJFX Committer.
>
> Marius is an OpenJFX community member, who has contributed 22 commits
> [2] to OpenJFX.
>
> Votes are due by July 22, 2022 at 13:00 UTC.
>
> Only current OpenJFX Committe
Vote: YES
On Fri, Jul 8, 2022 at 8:39 PM Kevin Rushforth
wrote:
> I hereby nominate Michael Strauß [1] to OpenJFX Committer.
>
> Michael is an OpenJFX community member, who has contributed 16 commits
> [2] to OpenJFX.
>
> Votes are due by July 22, 2022 at 13:00 UTC.
>
> Only current OpenJFX Comm
On Fri, 8 Jul 2022 20:11:22 GMT, Andy Goryachev wrote:
> trivial change, removed unnecessary code.
Marked as reviewed by nlisker (Reviewer).
-
PR: https://git.openjdk.org/jfx/pull/822
On Fri, 8 Jul 2022 18:47:49 GMT, Andy Goryachev wrote:
>> summary of changes:
>> - fixed .classpath files
>> - set UTF-8 encoding in the eclipse project config files
>>
>> the list of eclipse projects that do compile in Eclipse as a result of this
>> PR are:
>> - base
>> - controls
>> - fxml
>>
On Mon, 27 Jun 2022 23:47:21 GMT, Kevin Rushforth wrote:
>> summary of changes:
>> - fixed .classpath files
>> - set UTF-8 encoding in the eclipse project config files
>>
>> the list of eclipse projects that do compile in Eclipse as a result of this
>> PR are:
>> - base
>> - controls
>> - fxml
On Fri, 8 Jul 2022 21:37:47 GMT, Andy Goryachev wrote:
> The fix includes:
> - renaming of offending methods to avoid confusion
> - explicitly declaring the offending methods as private
modules/javafx.graphics/src/main/java/com/sun/prism/impl/ps/BaseShaderGraphics.java
line 92:
> 90: BaseS
On Fri, 8 Jul 2022 23:45:58 GMT, John Hendrikx wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8289389: toExternalForm()
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/css/CalculatedValue.java
> line 1
On Fri, 8 Jul 2022 22:27:52 GMT, Andy Goryachev wrote:
>> summary of changes:
>> - fixed .classpath files
>> - set UTF-8 encoding in the eclipse project config files
>>
>> the list of eclipse projects that do compile in Eclipse as a result of this
>> PR are:
>> - base
>> - controls
>> - fxml
>>
There was a previous implementation discussion that touched on some of the
points here in https://github.com/openjdk/jfx/pull/108
I think there are a few (semi-)independent points here:
1. Order of listeners: as John said, there is no specification of the order
of listeners, but the add/removeList
Hi,
Is it intended for this issue to go into 19? If so, we need to figure out
the new memory management model quickly. If not, I take it that we are
happy for now with the unspecified behaviors and specify them later.
Nir
On Wed, 6 Jul 2022 18:52:08 GMT, Andy Goryachev wrote:
> - fixed varargs
Marked as reviewed by nlisker (Reviewer).
-
PR: https://git.openjdk.org/jfx/pull/816
On Fri, 8 Jul 2022 21:37:47 GMT, Andy Goryachev wrote:
> The fix includes:
> - renaming of offending methods to avoid confusion
> - explicitly declaring the offending methods as private
I haven't had time to look at this one yet. Will do so later today or tomorrow.
-
PR: https://gi
On Fri, 8 Jul 2022 21:37:47 GMT, Andy Goryachev wrote:
> The fix includes:
> - renaming of offending methods to avoid confusion
> - explicitly declaring the offending methods as private
I've finished an analysis of a few of the cases here. After checking the
[JLS](https://docs.oracle.com/javase
On Wed, 13 Jul 2022 07:35:06 GMT, John Hendrikx wrote:
> These compiler warning settings are more than likely just a left over from
> the days before `@Override` existed.
My thoughts as well. `@Override` was added in 1.5. I think this warning was
added prior.
-
PR: https://git.op
On Fri, 8 Jul 2022 21:37:47 GMT, Andy Goryachev wrote:
> The fix includes:
> - renaming of offending methods to avoid confusion
> - explicitly declaring the offending methods as private
I turned on errors on missing `@Override` annotations. I got over 1k errors. I
think it's worth fixing it in
On Fri, 8 Jul 2022 21:37:47 GMT, Andy Goryachev wrote:
> The fix includes:
> - renaming of offending methods to avoid confusion
> - explicitly declaring the offending methods as private
I personally disabled the "does not override method in a different package"
warning. The synthetic methods on
The Eclipse project files were updated recently in
https://github.com/openjdk/jfx/pull/804. The OS-specific folders were
removed. I tested it and I had no issue after this change. On what resource
are you getting this error?
On Fri, Jul 15, 2022 at 12:44 PM Jeanette Winzenburg <
faste...@swingempi
m the source
folders list in the build path, so I don't know why you would get this
error. Nothing in the "main" source folders references these in compile- or
build-time.
On Fri, Jul 15, 2022 at 12:51 PM Nir Lisker wrote:
> The Eclipse project files were updated recently in
> http
What resource is the error on?
On Fri, Jul 15, 2022 at 1:19 PM Jeanette Winzenburg
wrote:
>
> Zitat von Nir Lisker :
>
> Hi Nir,
>
> thanks for the explanation - though I have no idea why Eclipse wants
> them (see them again after re-adding as source folders and al
On Thu, 14 Jul 2022 23:55:52 GMT, Kevin Rushforth wrote:
>> I introduced a bug with the fluent bindings PR which affects all
>> ObjectBindings.
>>
>> This is the code that fails:
>>
>> SimpleObjectProperty condition = new
>> SimpleObjectProperty<>(true);
>> ObservableValue bin
On Fri, 15 Jul 2022 07:19:19 GMT, John Hendrikx wrote:
>> I introduced a bug with the fluent bindings PR which affects all
>> ObjectBindings.
>>
>> This is the code that fails:
>>
>> SimpleObjectProperty condition = new
>> SimpleObjectProperty<>(true);
>> ObservableValue bindi
e all 4 folders as a part of the
> corresponding target.
>
>
> I am not in favor of this change. There are platform-specific parts of the
> build, so IDEs should be able to adapt to this.
>
> -- Kevin
>
>
>
>
>
> What do you think?
>
>
>
> -andy
>
t;1. The classes in build/gensrc/ generate a runtime exception, not a
>build error. I wonder if perhaps we should add an entry to the library
>path instead. Let me check on this.
>
>
>
>1. Again, Jeanette’s report was about runtime error. I wonder though
>
d to reproduce the runtime error by using an application that
uses fonts. If you know what the Mac/Linux-specific folders are, I will add
them to my classpath and see if everything works for me.
On Fri, Jul 15, 2022 at 10:34 PM Nir Lisker wrote:
> Ah, I missed that it's during runtime. When I r
On Sat, 16 Jul 2022 13:24:22 GMT, John Hendrikx wrote:
> Fix small error in flatmap docs
If we bump to Java 18 we would be able to use [JEP 413: Code Snippets in Java
API Documentation](https://openjdk.org/jeps/413) and avoid these errors :)
-
PR: https://git.openjdk.org/jfx/pull/
On Fri, 8 Jul 2022 20:31:31 GMT, Andy Goryachev wrote:
> Fixes "Unlikely argument type" warning generated by the latest Eclipse IDE.
>
> This warning should be reclassified as an error, as it catches bugs missed by
> javac. In this case, the following places seem to contain bugs:
> -
> apps/s
On Mon, 18 Jul 2022 21:50:00 GMT, Andy Goryachev wrote:
>> Fixes "Unlikely argument type" warning generated by the latest Eclipse IDE.
>>
>> This warning should be reclassified as an error, as it catches bugs missed
>> by javac. In this case, the following places seem to contain bugs:
>> -
>>
On Mon, 11 Jul 2022 22:40:29 GMT, Andy Goryachev wrote:
>> In order to reduce collisions, the hash of each component is typically added
>> to `h * 31` even when that hash is 0, whereas you skip the `h = 31 * h` in
>> the case of null. It might not be a problem in practice, since value and
>> o
On Mon, 11 Jul 2022 22:44:41 GMT, Andy Goryachev wrote:
>> - added missing hashCode() methods
>
> Andy Goryachev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8289389: minimize the impact of collision
Except for one case, looks good. I t
Why is the bump to JDK 17 and not 18? In 18 the feature for Code Snippets
in Java API Documentation was added and it could be useful for any new API.
Is the plan to continue to pump the minimum version with every release or
once in several? Does it depend on the benefit the new features add?
On T
In my opinion, each JDK version should be evaluated according to its
benefits to JavaFX and not according to LTS, which is a foreign concept to
OpenJDK.
The JDK moved to a 6 months release plan so it can innovate faster without
waiting several years to release an important feature, and if we go wi
>
> 1) ID3 metadata support for MP4 files.
> Rating:
>
3
>
> 2) Support for multichannel audio rendering (more than 2 channels).
Rating:
>
2
>
> 3) Subtitles support for MP4 files and HTTP Live Streaming.
> Rating:
>
2
>
> 4) HDR support.
> Rating:
>
3
>
> 5) InputStream for AudioClip with P
On Fri, 8 Jul 2022 19:00:25 GMT, Andy Goryachev wrote:
> Fixes warnings generated by the latest Eclipse:
> method is overriding a synchronized method without being synchronized
I'm not familiar with the code here, but it should be checked if the overriding
method should actually be synchronize
On Tue, 26 Jul 2022 22:54:56 GMT, Andy Goryachev wrote:
>> - replaced with exact functional equivalent (in the presence of exceptions,
>> for example)
>
> Andy Goryachev has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - 8289397: review com
On Tue, 26 Jul 2022 22:54:56 GMT, Andy Goryachev wrote:
>> - replaced with exact functional equivalent (in the presence of exceptions,
>> for example)
>
> Andy Goryachev has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - 8289397: review com
Now that we are using JDK 17, the SecurityManager is deprecated for
removal. JDK-8264139 [1] already suppressed the warnings, but we should
probably start looking at replacements as there are ~200 affected files.
What is the plan going forward?
[1] https://bugs.openjdk.org/browse/JDK-8264139
On Fri, 17 Jun 2022 09:04:41 GMT, Ambarish Rapte wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove unused comments, clean constructor
>
> modules/javafx.graphics/src/main/nativ
On Fri, 17 Jun 2022 14:27:58 GMT, Ambarish Rapte wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove unused comments, clean constructor
>
> modules/javafx.graphics/src/mai
On Fri, 29 Jul 2022 21:10:23 GMT, Ambarish Rapte wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove unused comments, clean constructor
>
> modules/javafx.graphics/src/main/native-p
On Fri, 29 Jul 2022 21:48:00 GMT, Ambarish Rapte wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove unused comments, clean constructor
>
> modules/javafx.graphics/src/main/native-p
On Thu, 16 Jun 2022 08:01:05 GMT, Ambarish Rapte wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove unused comments, clean constructor
>
> modules/javafx.graphics/src/mai
ded it to `psConstants` instead.
> * `vs2ps`
> * Removed the ambient color interpolation, which frees a register (no
> change in performance).
> * Simplified the structure (what is `LocalBumpOut` and why is it called
> `light` and contains `LocalBump`?).
> * `Mtl1PS` and `psM
ded it to `psConstants` instead.
> * `vs2ps`
> * Removed the ambient color interpolation, which frees a register (no
> change in performance).
> * Simplified the structure (what is `LocalBumpOut` and why is it called
> `light` and contains `LocalBump`?).
> * `Mtl1PS` and `psM
But that has no effect on previous JavaFX builds, I don't see a retroactive
value here.
>
On Mon, 1 Aug 2022 16:53:29 GMT, Andy Goryachev wrote:
> - updated .classpath entries in apps/
> - added utf-8 prefs in .settings/
I'm don't think that this is the right approach with the apps. I think that
each app should be its own project. See the branch I linked in the previous PR.
I don't
ded it to `psConstants` instead.
> * `vs2ps`
> * Removed the ambient color interpolation, which frees a register (no
> change in performance).
> * Simplified the structure (what is `LocalBumpOut` and why is it called
> `light` and contains `LocalBump`?).
> * `Mtl1PS` and `psM
On Tue, 2 Aug 2022 07:36:11 GMT, Ambarish Rapte wrote:
>> Yes, in `PsMath.h::computeLight`, there is a check if the light requests
>> attenuation. In general, this is done only for directional lights (that are
>> not attenuated), but in this case we know that this point light is not
>> attenua
On Mon, 1 Aug 2022 16:53:29 GMT, Andy Goryachev wrote:
> The goal of this change is to make sure jfx repo can be imported as a gradle
> project in eclipse and all nested projects in the workspace compile with no
> errors.
>
> - updated .classpath entries in apps/
> - added utf-8 prefs in .sett
On Mon, 1 Aug 2022 19:30:28 GMT, Andy Goryachev wrote:
>> modules/javafx.graphics/.classpath line 5:
>>
>>> 3:
>>> 4:
>>> 5:
>>
>> How do you not get errors on these on Mac/Linux if they are not declared
>> optional?
>>
>> Additionally, you need the hlsl folders as shown in the mailing
On Mon, 1 Aug 2022 19:34:11 GMT, Andy Goryachev wrote:
>> buildSrc/.classpath line 10:
>>
>>> 8: >> path="../build/libs/antlr-runtime-3.1.3.jar"/>
>>> 9: >> path="../build/libs/stringtemplate-3.2.jar"/>
>>> 10: >> path="../build/libs/swt-debug.jar"/>
>>
>> Why does buildSrc need to be a p
On Sat, 6 Aug 2022 13:22:17 GMT, Kevin Rushforth wrote:
>> As @kleopatra noted below, you need to add the hlsl folders that are built
>> on Windows. Add them as an optional source to avoid errors on other OS's:
>>
>>
>>
>>
>>
>>
>>
>> And the same for
>> ``
>> `
On Mon, 8 Aug 2022 15:21:58 GMT, Andy Goryachev wrote:
>> I agree that an optional dependency for a platform-specific generated source
>> directory is a much better solution than creating an empty dir.
>
> @kevinrushforth :
> Eclipse does not support conditionals in the .classpath files. The
On Mon, 8 Aug 2022 15:38:35 GMT, Andy Goryachev wrote:
>> On Linux there is no such warning., neither is there on Windows if I add a
>> non-existing folder (to simulate the ones for other OS's). I posted the
>> screenshots on the mailing list. If Eclipse for Mac is the only one
>> producing th
On Fri, 21 Apr 2023 13:18:31 GMT, Nir Lisker wrote:
> Adds the javadoc commands to generate the NEW page and to be able to select
> versions in the DEPRECATED page.
This pull request has now been integrated.
Changeset: 9913b23a
Author: Nir Lisker
URL:
https://git.openjdk.o
On Mon, 12 Jun 2023 18:17:17 GMT, Michael Strauß wrote:
>> This PR adds the following methods to the `EventTarget` interface:
>> 1. `addEventHandler`
>> 2. `removeEventHandler`
>> 3. `addEventFilter`
>> 4. `removeEventFilter`
>
> Michael Strauß has updated the pull request incrementally with two
>
> Which leads to the question; Does there, in JavaFX exist something
> comparable to setting the texture-sampler to NEAREST
>
> instead of LINEAR sampling?
>
There is no API to set the texture filter. If you would like to contribute
and add it, I can help. It needs to be compatible with both Dir
sic concept it
> would probably be sensible to add this as a parameter to the
> PhonMaterial-class.
>
> Alternatively it might make sense to add a “Texture” class that is used a
> a DiffuseMap in the PhonMaterial. But that seems slightly overkill.
>
>
>
> As I am not ve
ender call. However it shouldn’t make any
>
> API difference really, as we can just have a field somewhere and the parse
> it along when needed.
>
>
>
> Cheers,
>
> Matija.
>
>
>
> *From: *Jayathirth Rao Daarapuram Venkatesh Murthy
>
> *Sent: *Wednesday, 21
The Vulkan pipeline option has been brought up several times over the past
years. It's a good addition, but it's a lot of work and there aren't enough
people who volunteered to work on it.
Even "upgrading" the DirectX implementation from 9 to 11 hasn't taken off
for the same reason.
On Thu, Jun 2
rkill considering there is only this one
> single parameter we’re trying to add,
>
> thus maybe just a flag in PhongMaterial would suffice?
>
>
>
> Have a nice day,
>
> Matija.
>
> *From: *Matija Brown
> *Sent: *Thursday, 22 June 2023 18:37
> *To: *Jaya
, but I’m not certain if it
> makes sense use-case wise.
>
>
>
> Thanks,
>
> Matija.
>
>
>
> *From: *Nir Lisker
> *Sent: *Sunday, 25 June 2023 19:49
> *To: *Matija Brown
> *Cc: *Jayathirth Rao Daarapuram Venkatesh Murthy
> ; Kevin Rushforth ;
> o
On Thu, 13 Jul 2023 00:01:23 GMT, John Hendrikx wrote:
>> Makes `Subscription` public (removing some of its methods that are
>> unnecessary), and adds methods that can provide `Subscription`s in
>> `ObservableValue`.
>
> John Hendrikx has updated the pull request incrementally with one addition
On Tue, 11 Jul 2023 23:19:21 GMT, John Hendrikx wrote:
>> Makes `Subscription` public (removing some of its methods that are
>> unnecessary), and adds methods that can provide `Subscription`s in
>> `ObservableValue`.
>
> John Hendrikx has updated the pull request incrementally with one addition
On Thu, 13 Jul 2023 00:01:23 GMT, John Hendrikx wrote:
>> Makes `Subscription` public (removing some of its methods that are
>> unnecessary), and adds methods that can provide `Subscription`s in
>> `ObservableValue`.
>
> John Hendrikx has updated the pull request incrementally with one addition
On Thu, 13 Jul 2023 21:13:06 GMT, John Hendrikx wrote:
> Incorporates documentation review comments from #1069.
>
> This PR should be kept minimal so it can be backported to JFX21; it should
> only contain documentation changes.
modules/javafx.base/src/main/java/javafx/beans/Subscription.java
On Thu, 13 Jul 2023 21:21:32 GMT, John Hendrikx wrote:
>> I put your changes (that we agree upon so far) in #1177
>>
>> As I said I'm not sure about the description for the Subscription class, and
>> it's not included yet, and so I also haven't yet removed the duplicated
>> texts about GC-abi
I added the info to the ticket.
On Fri, Jul 21, 2023 at 2:00 AM Alessandro Mercier <
administra...@codedead.com> wrote:
> Hello,
>
> I possibly have some new information in regards to:
> https://bugs.openjdk.org/browse/JDK-8268657
>
> It seems the bug is predominantly active on Linux Wayland syst
On Fri, 21 Jul 2023 22:15:03 GMT, John Hendrikx wrote:
> The Subscription interface is independent from FX beans and has uses
> unrelated to beans, it should therefore be placed in javafx.util.
>
> This should be fixed before
> [JDK-8311123](https://bugs.openjdk.org/browse/JDK-8311123) is rele
A simple fix of changing the attenuation toggle from 1 to 0 for removed lights.
-
Commit messages:
- Initial commit
Changes: https://git.openjdk.org/jfx/pull/1186/files
Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1186&range=00
Issue: https://bugs.openjdk.org/browse/JDK-83132
On Thu, 27 Jul 2023 03:39:06 GMT, Nir Lisker wrote:
> A simple fix of changing the attenuation toggle from 1 to 0 for removed
> lights.
@kevinrushforth I think that this is simple enough to be able to get into RDP1.
There is some performance improvement regained here that was lost in
On Thu, 27 Jul 2023 03:39:06 GMT, Nir Lisker wrote:
> A simple fix of changing the attenuation toggle from 1 to 0 for removed
> lights.
This pull request has now been integrated.
Changeset: b323db26
Author: Nir Lisker
URL:
https://git.openjdk.org/jfx/
Backport of commit
[b323db26](https://github.com/openjdk/jfx/commit/b323db262906853afbdec7a747f3b2f5b6593b9b)
(PR https://github.com/openjdk/jfx/pull/1186)
-
Commit messages:
- Backport b323db262906853afbdec7a747f3b2f5b6593b9b
Changes: https://git.openjdk.org/jfx/pull/1187/files
On Fri, 28 Jul 2023 00:13:16 GMT, Nir Lisker wrote:
> Backport of commit
> [b323db26](https://github.com/openjdk/jfx/commit/b323db262906853afbdec7a747f3b2f5b6593b9b)
> (PR https://github.com/openjdk/jfx/pull/1186)
This pull request has now been integrated.
Changeset: 86e71094
Autho
On Mon, 31 Jul 2023 11:51:24 GMT, John Hendrikx wrote:
>> Incorporates documentation review comments from #1069.
>>
>> This PR should be kept minimal so it can be backported to JFX21; it should
>> only contain documentation changes.
>
> John Hendrikx has updated the pull request with a new targ
1 - 100 of 846 matches
Mail list logo
