On Tue, 5 Jul 2022 17:50:26 GMT, Andy Goryachev <d...@openjdk.org> wrote:
>> modules/javafx.graphics/.classpath line 5: >> >>> 3: <classpathentry kind="src" path="src/main/java"/> >>> 4: <classpathentry kind="src" path="build/gensrc/jsl-prism"/> >>> 5: <classpathentry kind="src" path="build/gensrc/jsl-decora"/> >> >> I think that you can remove these source folders too. >> >> Did you get errors with `build/hlsl/Decora` and `build/hlsl/Prism`? These >> are generated for Windows, so possibly on Linux/Mac you would get errors, >> but marking them with "ignore_optional_problems" should resolve these. >> >> In general, we should be able to remove OS-specific folders. > > 1. I will try to incorporate your changes, especially in apps/. My initial > goal was to fix the build of everything except apps/ > 2. I do get some warnings, they will be addressed by other fixes under > JDK-8289379. But others (ex: MacPasteboardShim) I do not see, as those have > been fixed. Could you please make sure you have no modified files and do a > refresh? > 3. Could you clarify your point about build/hlsl/Decora and build/hlsl/Prism > please? I noticed there is nothing there, and nothing seem to be put there. > Also, there are build/gensrc/jsl-prism and build/gensrc/jsl-decora > directories being created, so I felt we can remove these entries from > .classpath. I do build on Mac though. 1. The way the apps are structured is that each app is its own project, which means that there are many new projects to create and configure. It can be a bit of work, though I have done it in my branch already. If you want to leave it to round 2 of fixing the Eclipse files it's fine. 2+3. I worked directly from master and from your branch, so no files have been changed. The folders under `build` are OS-specific and are generated as needed by the build. Since you are on Mac, it would explain why the hlsl folders are empty, but they are not empty on Windows. This is why they are marked as "ignore_optional_problems" - to not produce errors even on the wrong system. Since they don't contain Java classes that are referenced by the build (as far as I could tell), it should be safe to remove the `build/...` source folders in general. I don't know if on Mac you get any issues, but I assume you don't. ------------- PR: https://git.openjdk.org/jfx/pull/804
