ng list (Could be a follow up). To
> support padding also when a `fixedCellSize` is set, the `compute...` methods
> needs to also add the padding when a `fixedCellSize` is set (in the `if`
> clauses) and the `VirtualFlow` needs to add the padding to every row instead
> of using the `
On Tue, 21 Jun 2022 23:32:02 GMT, Michael Strauß wrote:
>> Marius Hanl has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8218826: changed test file to use junit5 api
>
> modules/javafx.controls/src/test/java/
On Wed, 22 Jun 2022 18:07:45 GMT, Michael Strauß wrote:
>> Marius Hanl has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8283346: Improved test name
>
> modules/javafx.base/src/main/java/javafx/collections/
oid tearDown() {
> strings = null;
> }
>
> @Benchmark
> public ObservableList init() {
> return FXCollections.observableArrayList(strings);
> }
> }
>
>
>
Marius Hanl has updated the pull request incrementally with one additional
commit since th
On Tue, 28 Jun 2022 16:23:57 GMT, Nir Lisker wrote:
>> Marius Hanl has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8283346: add items directly to the backing list to save a change build
>> caused by addin
Initialize the `(Tree)TableView` when creating the measure row.
This will guarantee, that we can access the `(Tree)TableView` in the
`(Tree)TableRowSkin`, which is currently only null during the autosizing (It is
always set otherwise).
With this change, a NPE is happening as the `(Tree)TableRow`
the `(Tree)TableRow` must be removed after the autosizing and the
> index must be set to `-1` (as for the cell) so that e.g. `cancelEdit` is not
> triggered twice. Some tests catched that (see `test_rt_31015`).
Marius Hanl has updated the pull request incrementally with one additional
the `(Tree)TableRow` must be removed after the autosizing and the
> index must be set to `-1` (as for the cell) so that e.g. `cancelEdit` is not
> triggered twice. Some tests catched that (see `test_rt_31015`).
Marius Hanl has updated the pull request incrementally with two additional
co
For some reason the `skinProperty` did not allow to set a new skin which is the
same class as the previous one.
This leads to multiple issues:
1. When creating a new skin (same class as previous), the skin will likely
install some children and listener but is then rejected when setting it due to
I want to have a look on the following issue:
https://bugs.openjdk.org/browse/JDK-8209991
https://bugs.openjdk.org/browse/JDK-8087549
Currently, the ComboBox hides the popup when typing in space, even when it is editable.
This is unexpected and problematic when implementing something like
On Thu, 30 Jun 2022 16:16:32 GMT, Michael Strauß wrote:
>> For some reason the `skinProperty` did not allow to set a new skin which is
>> the same class as the previous one.
>> This leads to multiple issues:
>> 1. When creating a new skin (same class as previous), the skin will likely
>> instal
oid tearDown() {
> strings = null;
> }
>
> @Benchmark
> public ObservableList init() {
> return FXCollections.observableArrayList(strings);
> }
> }
>
>
>
Marius Hanl has updated the pull request incrementally with two additional
commits since the
On Thu, 30 Jun 2022 19:36:34 GMT, Nir Lisker wrote:
> Looks good. I left a few small comments.
>
> I ran some benchmarks and I can reproduce the performance improvement both in
> the array (varargs) and the collection variants of the method.
Thanks for the review and verifying the improvement.
oid tearDown() {
> strings = null;
> }
>
> @Benchmark
> public ObservableList init() {
> return FXCollections.observableArrayList(strings);
> }
> }
>
>
>
Marius Hanl has updated the pull request incrementally with one additional
commit since the l
On Thu, 17 Mar 2022 21:10:14 GMT, Marius Hanl wrote:
> This simple PR optimizes the observable `ArrayList` creation by using the
> ArrayList constructor/array size so that the underlying array will be
> initialized at the correct size which will speed up the creation as the array
&
On Wed, 23 Feb 2022 22:27:51 GMT, Marius Hanl wrote:
> This PR fixes an issue where the item of the table row is null, although the
> cell itself is not empty (non null value).
>
> The fix is to call `indexChanged(..)` immediately after the index was
> changed, but before all
the `(Tree)TableRow` must be removed after the autosizing and the
> index must be set to `-1` (as for the cell) so that e.g. `cancelEdit` is not
> triggered twice. Some tests catched that (see `test_rt_31015`).
Marius Hanl has updated the pull request with a new target base due to a
As also discussed in the ticket, we need to disable/ignore this two tests for
now.
With the fix for [JDK-8251483](https://bugs.openjdk.org/browse/JDK-8251483) the
table row item is never null in a non empty table cell.
In the meantime with [JDK-8251480](https://bugs.openjdk.org/browse/JDK-825148
On Tue, 5 Jul 2022 23:09:37 GMT, Marius Hanl wrote:
> As also discussed in the ticket, we need to disable/ignore this two tests for
> now.
>
> With the fix for [JDK-8251483](https://bugs.openjdk.org/browse/JDK-8251483)
> the table row item is never null in a non empty table
On Tue, 5 Jul 2022 23:21:19 GMT, Kevin Rushforth wrote:
> Thank you for fixing this quickly.
Thank you very much for your time as well! I am glad that I could help.
-
PR: https://git.openjdk.org/jfx/pull/811
the `(Tree)TableRow` must be removed after the autosizing and the
> index must be set to `-1` (as for the cell) so that e.g. `cancelEdit` is not
> triggered twice. Some tests catched that (see `test_rt_31015`).
Marius Hanl has updated the pull request with a new target base due to a
On Wed, 29 Jun 2022 13:35:15 GMT, Marius Hanl wrote:
> For some reason the `skinProperty` did not allow to set a new skin which is
> the same class as the previous one.
> This leads to multiple issues:
> 1. When creating a new skin (same class as previous), the skin will likely
&g
I had a similar idea in the past and like the idea.Ideally, setting/switching a skin is a one step process. Currently you can construct a skin for a control and set it after to a different control.Your approach sounds good, if you can set a skin by creating a new skin (with a default construc
I don't see how this fixes the underlying problem, since you could still do stuff like:control.installSkin(c -> { MySkin s = new MySkin(myOtherControl);// configure stuff return s; });So I think the super clean way would still be to have a default construc
I think this is the right step and at the time of JavaFX 20, 1.5 years passed after the release of JDK 17 (and of course JavaFX 17), which should be enough time to upgrade to it.And even if some people can't upgrade to JDK 17 for whatever reason, running on JavaFX 19 for a bit more shouldn't
On Tue, 26 Jul 2022 02:46:15 GMT, Michael Strauß wrote:
> When a node is set as the root node of a `Scene` or `SubScene`, the "root"
> style class is automatically added to the node, but not cleared when the node
> is later removed from the scene.
>
> This can lead to an incorrectly set "root"
On Tue, 26 Jul 2022 22:59:26 GMT, Andy Goryachev wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/util/Utils.java line
>> 875:
>>
>>> 873: public static boolean assertionEnabled() {
>>> 874: boolean assertsEnabled = false;
>>> 875: assert (assertsEnabled = true
On Fri, 29 Jul 2022 21:11:53 GMT, Andy Goryachev wrote:
> - moving mouse pointer to stage lower right corner in order to avoid
> interference with the Robot screen capture.
tests/system/src/test/java/test/robot/javafx/scene/RobotTest.java line 148:
> 146: double y = stage.getY() + stag
On Tue, 26 Jul 2022 11:51:10 GMT, Florian Kirmaier
wrote:
>> It's "a bit" complicated.
>> In some situations, getRuns get's called because listeners on bounds are set.
>> This causes TextFlow to layout to compute the runs.
>> Afterward, the bounds of the parents get updated.
>> This triggers a
On Tue, 24 May 2022 21:25:23 GMT, Marius Hanl wrote:
> This PR fixes a problem, where the layout is broken when a `(Tree)TableRow`
> has padding.
> As also mentioned in the ticket, the `layoutChildren` method in
> `TableRowSkinBase` is implemented wrong.
>
> The `layoutC
On Thu, 4 Aug 2022 21:29:49 GMT, Kevin Rushforth wrote:
> As I mentioned in that JBS issue, I tend to agree that if we were starting
> today with a blank sheet of paper, we might have disallowed null and defined
> a "noop" selection model and/or focus model. At this point, though, it would
> b
On Thu, 1 Jun 2023 15:50:37 GMT, Andy Goryachev wrote:
>> Minor fixes and addition of missing sections:
>>
>> - The 'system' font is missing from the list of generic font family names in
>> the section. ✓
>> - Explicitly add text color property -fx-fill to Text section, so as not to
>> confus
On Tue, 30 May 2023 10:39:28 GMT, Johan Vos wrote:
>> Only update the VirtualFlow parameters in case the size of a cell has
>> changed.
>>
>> The fixes for JDK-8298728 and JDK-8277785 introduced an unconditional
>> recalculation in case the size of a cell is set. This recalculation is only
>>
On Thu, 1 Jun 2023 20:30:06 GMT, Marius Hanl wrote:
>> Johan Vos has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove newline
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin
On Fri, 2 Jun 2023 13:55:05 GMT, Kevin Rushforth wrote:
>> @johanvos I still think this should be evaluated.
>
> Perhaps you could file a follow-up JBS issue?
Filed: https://bugs.openjdk.org/browse/JDK-8309470
-
PR Review Comment: https://git.openjdk.org/jfx/pull/1098#discussion_r1
On Mon, 15 May 2023 16:12:10 GMT, Andy Goryachev wrote:
>> Fixed a memory leak in TreeTableView by reverting to register**Listener
>> (which is ok in this particular situation) - the leak is specific to
>> TreeTableRowSkin.
>>
>> Added a unit test.
>
> Andy Goryachev has updated the pull reque
On Mon, 15 May 2023 16:12:10 GMT, Andy Goryachev wrote:
>> Fixed a memory leak in TreeTableView by reverting to register**Listener
>> (which is ok in this particular situation) - the leak is specific to
>> TreeTableRowSkin.
>>
>> Added a unit test.
>
> Andy Goryachev has updated the pull reque
On Tue, 6 Jun 2023 15:56:45 GMT, Andy Goryachev wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TreeTableRowSkin.java
>> line 117:
>>
>>> 115: TreeTableView treeTableView =
>>> getSkinnable().getTreeTableView();
>>> 116: if (treeTableView == null) {
>>
This PR does two small improvements to `VirtualFlow`.
Until now, the `VirtualFlow` sometimes called the `computeHeight` or
`computeWidth` methods, although a fixed cell size is set and we therefore
don't need to call those method (and never should do, as we may don't get the
expected result and
On Thu, 8 Jun 2023 00:01:02 GMT, Andy Goryachev wrote:
>> This PR does two small improvements to `VirtualFlow`.
>> Until now, the `VirtualFlow` sometimes called the `computeHeight` or
>> `computeWidth` methods, although a fixed cell size is set and we therefore
>> don't need to call those metho
;t get the
> expected result and mix computed sizes with the fixed cell size).
>
> Added tests that fail before and pass now. They check that the
> `computeHeight` or `computeWidth` (non vertical flow) are never called when a
> fixed cell size is set.
Marius Hanl has updated th
On Thu, 8 Jun 2023 06:46:28 GMT, Marius Hanl wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/VirtualFlowTest.java
>> line 1579:
>>
>>> 1577: @Test
>>> 1578: public void
>>> testComputeWidthShouldNotBeCalledWhe
On Thu, 8 Jun 2023 00:07:20 GMT, Andy Goryachev wrote:
> I don't see any ill effects in the MonkeyTester. There is still a bit of lag
> with 10,000,000 row model, same as before.
Yeah for me as well. This is a very minor improvement and actually with this PR
the following assertion is now true
;t get the
> expected result and mix computed sizes with the fixed cell size).
>
> Added tests that fail before and pass now. They check that the
> `computeHeight` or `computeWidth` (non vertical flow) are never called when a
> fixed cell size is set.
Marius Hanl has updated th
On Tue, 25 Apr 2023 07:14:07 GMT, John Hendrikx wrote:
>> This fix introduces immutable sets of `PseudoClass` almost everywhere, as
>> they are rarely modified. These are re-used by caching them in a new class
>> `ImmutablePseudoClassSetsCache`.
>>
>> In order to make this work, `BitSet` had
;t get the
> expected result and mix computed sizes with the fixed cell size).
>
> Added tests that fail before and pass now. They check that the
> `computeHeight` or `computeWidth` (non vertical flow) are never called when a
> fixed cell size is set.
Marius Hanl has updated th
On Thu, 8 Jun 2023 13:41:56 GMT, Karthik P K wrote:
>> Marius Hanl has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> JDK-8309470: Improved Tests
>
> modules/javafx.controls/src/main/java/javafx/scene/control
On Thu, 8 Jun 2023 13:41:04 GMT, Karthik P K wrote:
> Tested the changes in MacOS 13.3.1, I'm seeing failure ...
I added two more test that directly fail if those methods are called. You will
get a better stacktrace from them. If this issue still appears, please paste it
here. :)
;t get the
> expected result and mix computed sizes with the fixed cell size).
>
> Added tests that fail before and pass now. They check that the
> `computeHeight` or `computeWidth` (non vertical flow) are never called when a
> fixed cell size is set.
Marius Hanl has updated th
On Thu, 8 Jun 2023 17:44:21 GMT, Karthik P K wrote:
> All the tests added here passes with the fix and fails without it. No issues
> now. Could have been some problem from my end.
Alright, thanks for the feedback!
-
PR Comment: https://git.openjdk.org/jfx/pull/1150#issuecomment-15
On Wed, 7 Jun 2023 20:59:01 GMT, Marius Hanl wrote:
> This PR does two small improvements to `VirtualFlow`.
> Until now, the `VirtualFlow` sometimes called the `computeHeight` or
> `computeWidth` methods, although a fixed cell size is set and we therefore
> don't need to call
On Thu, 8 Jun 2023 21:38:02 GMT, Andy Goryachev wrote:
> I am somewhat divided on which version to start with. On one hand, it makes
> sense to use last LTS version (or previous, if the current one is also LTS),
> so 17.
I think we should either start from 9 or 11.
Depending on the source, Jav
On Mon, 12 Jun 2023 18:17:17 GMT, Michael Strauß wrote:
>> This PR adds the following methods to the `EventTarget` interface:
>> 1. `addEventHandler`
>> 2. `removeEventHandler`
>> 3. `addEventFilter`
>> 4. `removeEventFilter`
>
> Michael Strauß has updated the pull request incrementally with two
On Wed, 5 Jul 2023 20:52:28 GMT, Michael Strauß wrote:
>> John Hendrikx has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 16 commits:
>>
>> - Merge branch 'master' of https://git.openjdk.org/jfx into
>>feature/immutable-pseudoc
On Fri, 7 Jul 2023 05:25:34 GMT, Karthik P K wrote:
> In `TreeTableRowSkin`, graphic was not updated along with tree item update.
>
> Made changes to update graphics of TreeTableView row in `updateTreeItem()`
> method.
>
> Added options in monkey tester to add graphics and subnodes to
> `Tree
On Mon, 17 Jul 2023 07:06:43 GMT, Karthik P K wrote:
>> In `TreeTableRowSkin`, graphic was not updated along with tree item update.
>>
>> Made changes to update graphics of TreeTableView row in `updateTreeItem()`
>> method.
>>
>> Added options in monkey tester to add graphics and subnodes to
On Thu, 20 Jul 2023 06:54:14 GMT, Karthik P K wrote:
>> In `TreeTableRowSkin`, graphic was not updated along with tree item update.
>>
>> Made changes to update graphics of TreeTableView row in `updateTreeItem()`
>> method.
>>
>> Added options in monkey tester to add graphics and subnodes to
On Wed, 19 Jul 2023 06:02:13 GMT, Prasanta Sadhukhan
wrote:
>> Due to transient datatype of scenePeer, it can become null which can result
>> in NPE in scenarios where scene is continuously been reset and set, which
>> warrants a null check, as is done in other places for the same variable.
>
I think this is a good feature to have in JavaFX, especially as it makes it much easier to animate the UI.This looks good to me API wise. Since you implemented this as in modern CSS, this is also very easy for people coming from the Web.-- Marius
Am 17.07.23, 21:24 schrieb "Michael Strauß" :
On Mon, 31 Jul 2023 16:49:36 GMT, Andy Goryachev wrote:
>> This PR adds a file lock to the cache directory, allowing access from
>> multiple processes (that is, from more than one JVM) to that directory.
>>
>> This helps solving the issue where the cache is empty or doesn't exist yet,
>> and
When a table has padding or the `layoutChildren` method inside the table skin
is overridden (and x/y are modified), the drag drag header, column overlay and
column line are not correctly aligned.
The reason is that the positions were calculated incorrectly.
- **Column overlay and column line**
A
On Wed, 2 Aug 2023 16:36:47 GMT, Marius Hanl wrote:
> When a table has padding or the `layoutChildren` method inside the table skin
> is overridden (and x/y are modified), the drag drag header, column overlay
> and column line are not correctly aligned.
>
> The reason is tha
An IOOBE was thrown when scrolling up via the trough (->
`VirtualScrollBar#adjustValue`).
This happened only when it has bigger cells than the viewport.
If the the uppermost cell with the index 0 is only visible (although not
completely scrolled to the top) and then an attempt is made to scroll
On Thu, 3 Aug 2023 11:41:30 GMT, Kevin Rushforth wrote:
>> An IOOBE was thrown when scrolling up via the trough (->
>> `VirtualScrollBar#adjustValue`).
>> This happened only when it has bigger cells than the viewport.
>> If the the uppermost cell with the index 0 is only visible (although not
ollBar` does this check, which will
> never be true then: `firstVisibleCell == lastVisibleCell`). This is unrelated
> to this fix. I can create a ticket when I have more information.
Marius Hanl has updated the pull request incrementally with three additional
commits since the last revision:
- JDK-
On Fri, 9 Jun 2023 12:45:02 GMT, John Hendrikx wrote:
>> This fix introduces immutable sets of `PseudoClass` almost everywhere, as
>> they are rarely modified. These are re-used by caching them in a new class
>> `ImmutablePseudoClassSetsCache`.
>>
>> In order to make this work, `BitSet` had t
On Fri, 9 Jun 2023 12:45:02 GMT, John Hendrikx wrote:
>> This fix introduces immutable sets of `PseudoClass` almost everywhere, as
>> they are rarely modified. These are re-used by caching them in a new class
>> `ImmutablePseudoClassSetsCache`.
>>
>> In order to make this work, `BitSet` had t
On Thu, 3 Aug 2023 15:18:51 GMT, John Hendrikx wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/css/BitSet.java line
>> 263:
>>
>>> 261:
>>> 262:
>>> 263: /** {@inheritDoc} */
>>
>> Isn't this still needed?
>
> There is an `@Override` annotation, javadoc will do the right t
On Thu, 3 Aug 2023 23:02:29 GMT, Andy Goryachev wrote:
>> When a table has padding or the `layoutChildren` method inside the table
>> skin is overridden (and x/y are modified), the drag drag header, column
>> overlay and column line are not correctly aligned.
>>
>> The reason is that the posit
On Wed, 24 May 2023 16:55:11 GMT, Marius Hanl wrote:
>> This PR implements a way to override the table column menu.
>> When the `cornerRegion` is pressed, it will now call the `showColumnMenu`
>> method. This new method is protected and therefore can be overidden by
>
On Wed, 29 Jun 2022 13:35:15 GMT, Marius Hanl wrote:
> For some reason the `skinProperty` did not allow to set a new skin which is
> the same class as the previous one.
> This leads to multiple issues:
> 1. When creating a new skin (same class as previous), the skin will likely
&g
Before, the `updateItem` method was called with the new value that was
committed via `commitEdit()`.
This is problematic as developers may setup a commit handler via
`setOnEditCommit`, which may reject the edit (or change the value otherwise).
We therefore do call the `updateItem(-1)` which will
The `lockItemOnEdit` only exists inside `TreeTableCell` and `TableCell` for the
sake of testing.
It is only changed by some JUnit tests to remove the need of setting up the
whole table framework.
This PR shifts this flag from those two classes to the shim classes, which are
not inside the final
When the `D3DPipeline` is reinitialized, the adapter ordinal of all the
`Screen`s are outdated.
As a consequence, when a `D3DResourceFactory` is created for a `Screen`
(adapter ordinal), the code may fail with an `ArrayIndexOutOfBoundsException`
as the ordinal is higher than what we would expect
On Fri, 4 Aug 2023 22:12:55 GMT, Marius Hanl wrote:
> The `lockItemOnEdit` only exists inside `TreeTableCell` and `TableCell` for
> the sake of testing.
> It is only changed by some JUnit tests to remove the need of setting up the
> whole table framework.
> This PR shifts this
On Wed, 9 Aug 2023 18:46:11 GMT, Michael Strauß wrote:
> I notice that the logic to assign adapter ordinals is now duplicated in two
> places in the codebase. Have you thought about moving the implementation into
> the `Screen` class?
I actually considered this but I really want to keep the d
On Sat, 5 Aug 2023 13:00:36 GMT, Marius Hanl wrote:
> When the `D3DPipeline` is reinitialized, the adapter ordinal of all the
> `Screen`s are outdated.
> As a consequence, when a `D3DResourceFactory` is created for a `Screen`
> (adapter ordinal), the code may
On Sat, 5 Aug 2023 13:00:36 GMT, Marius Hanl wrote:
> When the `D3DPipeline` is reinitialized, the adapter ordinal of all the
> `Screen`s are outdated.
> As a consequence, when a `D3DResourceFactory` is created for a `Screen`
> (adapter ordinal), the code may
On Tue, 15 Aug 2023 16:56:54 GMT, Andy Goryachev wrote:
>> Marius Hanl has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - JDK-8311983: remove JUnit5 import
>> - JDK-8311983: improve exception handling
On Mon, 14 Aug 2023 18:36:57 GMT, Andy Goryachev wrote:
>> It probably won't hurt. But since the mismatch is visible even at a normal
>> scale, I didn't bothered to do so.
>
> ... as a safeguard for any possible regressions?
Well, the question is: Is there really something to test? E.g. a lot o
On Tue, 8 Aug 2023 09:02:07 GMT, Guillaume Tâche wrote:
>> `setHeight()` / `setWidth()` were ignored if called after `sizeToScene()`
>> and before `show()`.
>> Now the `sizeToScene` flag is unset in these methods to ensure the right
>> values are set when the window is shown.
>
> Guillaum
On Wed, 16 Aug 2023 09:28:57 GMT, Guillaume Tâche wrote:
>> `setHeight()` / `setWidth()` were ignored if called after `sizeToScene()`
>> and before `show()`.
>> Now the `sizeToScene` flag is unset in these methods to ensure the right
>> values are set when the window is shown.
>
> Guillau
On Wed, 2 Aug 2023 22:21:20 GMT, Marius Hanl wrote:
> An IOOBE was thrown when scrolling up via the trough (->
> `VirtualScrollBar#adjustValue`).
> This happened only when it has bigger cells than the viewport.
> If the the uppermost cell with the index 0 is only visibl
On Fri, 18 Aug 2023 01:59:06 GMT, Michael Strauß wrote:
> @Maran23 maybe you could take a look, too.
Yes! It is on my list.
-
PR Comment: https://git.openjdk.org/jfx/pull/1210#issuecomment-1683406362
On Thu, 17 Aug 2023 00:30:45 GMT, Michael Strauß wrote:
>> This PR fixes an issue with the way `focusWithin` bits are adjusted in the
>> scene graph. Previously, the `focusWithin` counts of all parents of a
>> removed node would be decreased if the removed node has a non-zero
>> `focusWithin`
On Fri, 18 Aug 2023 13:38:43 GMT, Michael Strauß wrote:
> That's because the table row remains `focused` even if you change the scene's
> focus owner to the "focus lost" button
I see. But to be honest, the table focus code is not optimal as it contains
multiple focus workarounds which can be b
On Fri, 18 Aug 2023 20:45:00 GMT, Michael Strauß wrote:
>> This PR fixes an issue with the way `focusWithin` bits are adjusted in the
>> scene graph. Previously, the `focusWithin` counts of all parents of a
>> removed node would be decreased if the removed node has a non-zero
>> `focusWithin`
On Fri, 18 Aug 2023 16:21:00 GMT, Michael Strauß wrote:
> The `focusWithin` count cannot be negative, and there is no possible way for
> applications to misuse the API to cause a negative count. If it ends up being
> negative, that's because of a bug, and I think that bugs should be fixed and
On Mon, 28 Aug 2023 04:58:31 GMT, Jayathirth D V wrote:
> At multiple places in native glass code we don't have appropriate NULL checks
> which might result in null pointer access.
>
> Added appropriate checks and all test run is green.
modules/javafx.graphics/src/main/native-glass/gtk/GlassAp
This PR adds a test that verifies the `SkinBase.layoutChildren(..)` method with
different scales.
While not explicitly documented, this method will receive the snapped and
correctly calculated x, y, width and height values, so that children of the
Control can be layouted correctly without requir
outed correctly without requiring to do many more
> calculations regarding padding.
Marius Hanl has updated the pull request incrementally with one additional
commit since the last revision:
JDK-8315569: Set a min size
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1229/fi
On Thu, 7 Sep 2023 22:04:46 GMT, Andy Goryachev wrote:
>> Marius Hanl has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> JDK-8315569: Set a min size
>
> modules/javafx.controls/src/test/
On Tue, 12 Sep 2023 22:48:26 GMT, Andy Goryachev wrote:
>> Do you a better idea? I guess it would make sense to rename it to something
>> more generic. Maybe ControlLayoutTest?
>
> ControlLayoutChildrenContractTest perhaps, if that's the only thing being
> tested here (that is, if you don't pla
On Tue, 12 Sep 2023 23:28:37 GMT, John Hendrikx wrote:
>> This fix introduces immutable sets of `PseudoClass` almost everywhere, as
>> they are rarely modified. These are re-used by caching them in a new class
>> `ImmutablePseudoClassSetsCache`.
>>
>> In order to make this work, `BitSet` had
Fixes the regression by basically reverting one change introduced in
https://bugs.openjdk.org/browse/JDK-8311983.
The problem is that it is actually required to get the size from a cell with
the index -1, which technically does not exist (the accumCell is used then).
Furthermore, unlike the name
On Thu, 21 Sep 2023 19:53:57 GMT, Johan Vos wrote:
> Hence, the result is that the item at "index" 0 is positioned at the wrong
> offset, which is something you can detect with a test.
I will check it out. More tests are always better nonetheless.
I still think the existing test is good as a re
, since this looks like something that can be optimized. But that is
> another story, not related to this fix.
Marius Hanl has updated the pull request incrementally with one additional
commit since the last revision:
JDK-8316590: More tests
-
Changes:
- all: https://git.ope
outed correctly without requiring to do many more
> calculations regarding padding.
Marius Hanl has updated the pull request incrementally with one additional
commit since the last revision:
JDK-8315569: Improve test name and add 2.25 scale
-
Changes:
- all: https://git.openjdk
On Sun, 24 Sep 2023 09:53:42 GMT, Johan Vos wrote:
> Therefore, I think there is a huge value in PR's like this because they add
> tests.
I agree, more tests also means we can more confidently implement potential
performance improvements in the future, as well as catch any regression when
cha
On Sat, 5 Aug 2023 12:28:16 GMT, Thorsten Fischer wrote:
> Hi,
>
> I did open the bug report. Some notes to this PR:
>
> My colleagues and I are able to reproduce this bug regularly, even though it
> takes sometimes up to 3 or 4 weeks until the D3DERR_DEVICEHUNG error shows
> up. We are curre
1 - 100 of 659 matches
Mail list logo
