On Thu, 8 Jun 2023 13:41:56 GMT, Karthik P K <k...@openjdk.org> wrote:
>> Marius Hanl has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> JDK-8309470: Improved Tests
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java
> line 3065:
>
>> 3063: }
>> 3064:
>> 3065: // if we have a valid cell, we can populate the cache
>
> Do we need this comment now?
no, it doesn't add anything useful to the code 😄
> modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/VirtualFlowTest.java
> line 1542:
>
>> 1540: @Override
>> 1541: protected double computeMinHeight(double width) {
>> 1542: return 1337;
>
> Can we add a final variable for this number since it is repeated many times?
It is just an arbitrary number for testing and only used for those two methods.
Not sure if it is worth it (it can be basically every number but should not be
the fixed cell size)
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1150#discussion_r1223232327
PR Review Comment: https://git.openjdk.org/jfx/pull/1150#discussion_r1223231530
