On Mon, 17 Jul 2023 07:06:43 GMT, Karthik P K <k...@openjdk.org> wrote:
>> In `TreeTableRowSkin`, graphic was not updated along with tree item update.
>>
>> Made changes to update graphics of TreeTableView row in `updateTreeItem()`
>> method.
>>
>> Added options in monkey tester to add graphics and subnodes to
>> `TreeTableView` rows.
>
> Karthik P K has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Review comments
modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/TreeTableRowSkinTest.java
line 372:
> 370:
> 371: for (int i = 0; i < 4; i++) {
> 372: TreeItem parent = new TreeItem("item - " + i, new
> Rectangle(10, 10));
Generics should be added here
modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/TreeTableRowSkinTest.java
line 380:
> 378:
> 379: int itemNodeSize = tree.getRoot().getChildren().size();
> 380: TreeItem treeItem =
> (TreeItem)tree.getRoot().getChildren().get(itemNodeSize - 2);
Cast is not needed here and below
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1172#discussion_r1268545646
PR Review Comment: https://git.openjdk.org/jfx/pull/1172#discussion_r1268545263
