On Wed, 23 Feb 2022 22:43:58 GMT, Marius Hanl wrote:
>> This PR fixes an issue where the item of the table row is null, although the
>> cell itself is not empty (non null value).
>>
>> The fix is to call `indexChanged(..)` immediately after the index was
>> changed, but before all `indexProper
On Wed, 29 Jun 2022 13:35:15 GMT, Marius Hanl wrote:
> For some reason the `skinProperty` did not allow to set a new skin which is
> the same class as the previous one.
> This leads to multiple issues:
> 1. When creating a new skin (same class as previous), the skin will likely
> install some c
On Fri, 8 Jul 2022 11:48:51 GMT, Michael Strauß wrote:
>> This PR adds the `Node.focusVisible` and `Node.focusWithin` properties, as
>> well as the corresponding `:focus-visible` and `:focus-within` CSS
>> pseudo-classes.
>
> Michael Strauß has updated the pull request incrementally with one ad
On Wed, 6 Jul 2022 23:36:26 GMT, Michael Strauß wrote:
>> This PR adds the `Node.focusVisible` and `Node.focusWithin` properties, as
>> well as the corresponding `:focus-visible` and `:focus-within` CSS
>> pseudo-classes.
>
> Michael Strauß has updated the pull request incrementally with one ad
Vote : YES
Regards,
Ajit
> On 08-Jul-2022, at 6:01 PM, Kevin Rushforth
> wrote:
>
> I hereby nominate Michael Strauß [1] to OpenJFX Committer.
>
> Michael is an OpenJFX community member, who has contributed 16 commits [2] to
> OpenJFX.
>
> Votes are due by July 22, 2022 at 13:00 UTC.
>
> O
Vote : YES
Regards,
Ajit
> On 08-Jul-2022, at 5:42 PM, Kevin Rushforth
> wrote:
>
> I hereby nominate Marius Hanl [1] to OpenJFX Committer.
>
> Marius is an OpenJFX community member, who has contributed 22 commits [2] to
> OpenJFX.
>
> Votes are due by July 22, 2022 at 13:00 UTC.
>
> Only
On Mon, 11 Jul 2022 13:59:36 GMT, Johan Vos wrote:
>> In order to fix the issues reported in JDK-8089589, the VirtualFlow now uses
>> the real sizes of the elements that are displayed. This allows for a more
>> natural way of scrolling through lists that contain items of very different
>> size
On Sun, 17 Jul 2022 18:59:22 GMT, Johan Vos wrote:
>> Do not recalculate total estimated size recursively.
>>
>> In the (unlikely) event that the recalculation triggers a new recalculation
>> (e.g. when the height of a Cell is changed), do not start this recalculation.
>> The cache and cache si
On Tue, 19 Jul 2022 10:36:07 GMT, Johan Vos wrote:
>> Do not recalculate total estimated size recursively.
>>
>> In the (unlikely) event that the recalculation triggers a new recalculation
>> (e.g. when the height of a Cell is changed), do not start this recalculation.
>> The cache and cache si
On Thu, 21 Jul 2022 11:12:08 GMT, Johan Vos wrote:
>> Do not recalculate total estimated size recursively.
>>
>> In the (unlikely) event that the recalculation triggers a new recalculation
>> (e.g. when the height of a Cell is changed), do not start this recalculation.
>> The cache and cache si
On Thu, 21 Jul 2022 21:10:10 GMT, Andy Goryachev wrote:
>> …ontract
>>
>> 1. reword SelectionModel.isSelected(int) javadoc, removing incorrect
>> statement "Is functionally equivalent to calling
>> getSelectedIndices().contains(index)."
>> 2. reimplement TableView.TableViewSelectionModel.isSe
On Tue, 26 Jul 2022 16:00:15 GMT, Andy Goryachev wrote:
> 1. javadoc for TableSelectionModel.isSelected(int, TablecolumnBase)
> already describes the logic:
Yes. I am aware of this documentation. I was thinking of making it clear for
the users if they see their application breaks due to thi
On Tue, 26 Jul 2022 02:46:15 GMT, Michael Strauß wrote:
> When a node is set as the root node of a `Scene` or `SubScene`, the "root"
> style class is automatically added to the node, but not cleared when the node
> is later removed from the scene.
>
> This can lead to an incorrectly set "root"
On Wed, 27 Jul 2022 21:36:10 GMT, Andy Goryachev wrote:
>> …ontract
>>
>> 1. reword SelectionModel.isSelected(int) javadoc, removing incorrect
>> statement "Is functionally equivalent to calling
>> getSelectedIndices().contains(index)."
>> 2. reimplement TableView.TableViewSelectionModel.isSe
On Thu, 28 Jul 2022 15:01:34 GMT, Kevin Rushforth wrote:
> When using the Windows Narrator screen reader on a Hi-DPI screen, the visible
> focus is drawn in the wrong location and with the wrong size. This happens
> because the the JavaFX Windows accessibility code that returns the screen
> bo
On Thu, 28 Jul 2022 15:01:34 GMT, Kevin Rushforth wrote:
> When using the Windows Narrator screen reader on a Hi-DPI screen, the visible
> focus is drawn in the wrong location and with the wrong size. This happens
> because the the JavaFX Windows accessibility code that returns the screen
> bo
On Mon, 1 Aug 2022 18:42:46 GMT, Michael Strauß wrote:
>> The `focusVisible` flag is only set on a node when it acquires input focus
>> using a keyboard interaction, and it is cleared by mouse and touch
>> interactions.
>>
>> It is not necessary for a node to lose input focus in order to lose
On Tue, 28 Jun 2022 15:19:50 GMT, Marius Hanl wrote:
>> This PR fixes a problem, where the layout is broken when a `(Tree)TableRow`
>> has padding.
>> As also mentioned in the ticket, the `layoutChildren` method in
>> `TableRowSkinBase` is implemented wrong.
>>
>> The `layoutChildren` method i
On Fri, 5 Aug 2022 18:42:34 GMT, Kevin Rushforth wrote:
>> When using the Windows Narrator screen reader on a Hi-DPI screen, the
>> visible focus is drawn in the wrong location and with the wrong size. This
>> happens because the the JavaFX Windows accessibility code that returns the
>> screen
On Mon, 15 May 2023 16:12:10 GMT, Andy Goryachev wrote:
>> Fixed a memory leak in TreeTableView by reverting to register**Listener
>> (which is ok in this particular situation) - the leak is specific to
>> TreeTableRowSkin.
>>
>> Added a unit test.
>
> Andy Goryachev has updated the pull reque
On Wed, 14 Jun 2023 13:39:52 GMT, Kevin Rushforth wrote:
> Simple fix to skip two failing tests on macOS until the underlying bugs are
> fixed:
>
> SceneChangeEventsTest::testSceneChange --
> [JDK-8300094](https://bugs.openjdk.org/browse/JDK-8300094)
> SceneChangeShouldNotFocusStageTest::windo
On Fri, 16 Jun 2023 15:35:42 GMT, Andy Goryachev wrote:
>> A recent change in JDK-8304831 ensured that insertionIndex is always
>> computed prior to HitInfo construction, making it possible to remove buggy
>> logic in HitInfo. This change also allows for removal of the 'text' field.
>>
>> Th
Hi John,
This looks like a user code issue and not a JavaFX bug.
Most of the vertical scrollbar issues that you have mentioned get fixed by
adding a call to "super.updateItem(image, empty);" as a first call in the cell
factory method "protected void updateItem(Image image, boolean empty)”
hev wrote:
I have a video clip of how to reproduce the exception. Do you mind creating a
bug?
Thank you
-andy
From: John Hendrikx <mailto:john.hendr...@gmail.com>
Date: Wednesday, July 12, 2023 at 09:33
To: Andy Goryachev
<mailto:andy.goryac...@oracle.com>, Ajit Ghaisas
<mailto:
On Tue, 18 Jul 2023 06:05:06 GMT, Prasanta Sadhukhan
wrote:
> Due to transient datatype of scenePeer, it can become null which can result
> in NPE in scenarios where scene is continuously been reset and set, which
> warrants a null check, as is done in other places for the same variable.
This
On Wed, 21 Jun 2023 13:34:28 GMT, Guillaume Tâche wrote:
>> This fixes ResourceBundle loading by calling
>> `ResourceBundle.getBundle(value, Locale.getDefault())` when the loader
>> resources are null or their classloader is null.
>> Apparently the original author of the bug report said the
On Wed, 2 Aug 2023 09:47:25 GMT, Guillaume Tâche wrote:
>> This fixes ResourceBundle loading by calling
>> `ResourceBundle.getBundle(value, Locale.getDefault())` when the loader
>> resources are null or their classloader is null.
>> Apparently the original author of the bug report said they
On Fri, 4 Aug 2023 22:12:55 GMT, Marius Hanl wrote:
> The `lockItemOnEdit` only exists inside `TreeTableCell` and `TableCell` for
> the sake of testing.
> It is only changed by some JUnit tests to remove the need of setting up the
> whole table framework.
> This PR shifts this flag from those t
On Fri, 18 Aug 2023 07:25:28 GMT, Karthik P K wrote:
> The issue is present in AreaChart along with the LineChart. Issue is fixed in
> both the charts as part of this PR.
> The line elements in case of Line chart and both line element and fill
> element in the case of Area charts were not clear
On Sat, 2 Sep 2023 00:31:26 GMT, Alexandre Iline wrote:
>> JDK-8315409: Fix jfx-tests so they work with latest jfx build
>
> Alexandre Iline has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Addressing copyright issues.
I verified that the f
On Mon, 4 Sep 2023 13:15:47 GMT, Karthik P K wrote:
> Added test: `testChartLineAndAreaRemovedOnClearingSeries()` for
> `StackedAreaChart` to check if the line and fill elements gets removed from
> the series on clearing the series. This test is added similar to the tests
> added to `LineChart
On Wed, 6 Sep 2023 05:21:03 GMT, Karthik P K wrote:
>> Added test: `testChartLineAndAreaRemovedOnClearingSeries()` for
>> `StackedAreaChart` to check if the line and fill elements gets removed from
>> the series on clearing the series. This test is added similar to the tests
>> added to `LineC
On Sat, 2 Sep 2023 00:31:26 GMT, Alexandre Iline wrote:
>> JDK-8315409: Fix jfx-tests so they work with latest jfx build
>
> Alexandre Iline has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Addressing copyright issues.
Approving this PR as
A few SceneGraphTests and ControlsTests/chart test classes are abstract classes
and serve as base classes for other tests.
They are excluded from test execution and hence result in avoiding false
failure reports.
-
Commit messages:
- 8315845 - exclude base class tests
Changes: htt
On Thu, 7 Sep 2023 07:58:08 GMT, Jayathirth D V wrote:
> Currently only 18 out of 62 3D tests run properly in jfx-tests repo.
> All the shape tests under "test/scenegraph/fx3d/shapes" and
> "test/scenegraph/fx3d/subscene/shapes" fail because they are not able to find
> image input they need.
>
On Thu, 7 Sep 2023 10:17:28 GMT, Jayathirth D V wrote:
> Out of 62 3D tests, 26 tests fail because of minute color differences in edge
> pixels.
> These tests are used to verify 3D rendering with different parameters like
> translation, rotation.
>
> So adding little color tolerance will not c
On Thu, 7 Sep 2023 09:26:59 GMT, Ajit Ghaisas wrote:
> A few SceneGraphTests and ControlsTests/chart test classes are abstract
> classes and serve as base classes for other tests.
> They are excluded from test execution and hence result in avoiding false
> failure reports.
Please
Below tests fail due to "resource not found" error.
- test/scenegraph/binding/effects/IdentityTest.java
- test/scenegraph/lcd/controls/tests/AccordionTest.java
- Almost all ControlsTests/Chart tests
Fix :
Moved required resources to appropriate directory.
-
Commit messages:
- addres
On Thu, 7 Sep 2023 10:17:28 GMT, Jayathirth D V wrote:
> Out of 62 3D tests, 26 tests fail because of minute color differences in edge
> pixels.
> These tests are used to verify 3D rendering with different parameters like
> translation, rotation.
>
> So adding little color tolerance will not c
On Mon, 11 Sep 2023 05:21:12 GMT, Jayathirth D V wrote:
>> Out of 62 3D tests, 26 tests fail because of minute color differences in
>> edge pixels.
>> These tests are used to verify 3D rendering with different parameters like
>> translation, rotation.
>>
>> So adding little color tolerance wil
On Fri, 8 Sep 2023 17:17:17 GMT, Alexandre Iline wrote:
>> There was a field in a subclass hiding a field in a superclass.
>
> Alexandre Iline has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - Copyright. :|
> - Copyright year
Marked as re
test/scenegraph/richtext/RichTextLabeledsTest.java
test/scenegraph/richtext/RichTextMixedTest.java
test/scenegraph/richtext/RichTextRectangleTest.java
test/scenegraph/richtext/RichTextTextTest.java
These tests were failing with - java.lang.IllegalStateException: This
operation is permitted on th
test/scenegraph/functional/graphics/Effects2Test.java has a total of 123 test
cases. Out of which 122 test cases pass and 1 test case (Lightningspotlight)
fails consistently. Right now, the root cause of this test failure is unknown.
This PR marks this test case with `@Ignore`. It will be fixed
On Tue, 12 Sep 2023 14:38:12 GMT, Ajit Ghaisas wrote:
> test/scenegraph/functional/graphics/Effects2Test.java has a total of 123 test
> cases. Out of which 122 test cases pass and 1 test case (Lightningspotlight)
> fails consistently. Right now, the root cause of this test failure i
On Fri, 8 Sep 2023 11:21:14 GMT, Ajit Ghaisas wrote:
> Below tests fail due to "resource not found" error.
> - test/scenegraph/binding/effects/IdentityTest.java
> - test/scenegraph/lcd/controls/tests/AccordionTest.java
> - Almost all ControlsTests/Chart tests
>
On Thu, 7 Sep 2023 09:26:59 GMT, Ajit Ghaisas wrote:
> A few SceneGraphTests and ControlsTests/chart test classes are abstract
> classes and serve as base classes for other tests.
> They are excluded from test execution and hence result in avoiding false
> failure reports.
This
On Fri, 15 Sep 2023 07:09:13 GMT, Ajit Ghaisas wrote:
> - Removed README file
> - Added README.md file with details
>
> For formatted output of README.md - See :
> https://github.com/aghaisas/jfx-tests/tree/update_readme
@shurymury, @kevinrushforth - Can you please review?
--
- Removed README file
- Added README.md file with details
For formatted output of README.md - See :
https://github.com/aghaisas/jfx-tests/tree/update_readme
-
Commit messages:
- add newline
- Update bullet points
- Add README.md
Changes: https://git.openjdk.org/jfx-tests/pull/11
is
> operation is permitted on the event thread only; currentThread = Time-limited
> test. They are fixed with a change to single file `RichTextPropertiesApp.java`
>
> Another test - test/scenegraph/richtext/RichTextSpecSymbTest.java - was
> failing due to NPE. Added a null c
On Tue, 12 Sep 2023 10:33:07 GMT, Ajit Ghaisas wrote:
> test/scenegraph/richtext/RichTextLabeledsTest.java
> test/scenegraph/richtext/RichTextMixedTest.java
> test/scenegraph/richtext/RichTextRectangleTest.java
> test/scenegraph/richtext/RichTextTextTest.java
>
> These tests
On Fri, 15 Sep 2023 15:04:59 GMT, Kevin Rushforth wrote:
>> README.md line 50:
>>
>>> 48: - To run a single test provide - `-Dtests=>> SceneGraphTests/tests>` before `test` in above command
>>> 49:
>>> 50: 7) **Generating golden images**
>>
>> terminology: would a "reference images" be a bette
> - Removed README file
> - Added README.md file with details
>
> For formatted output of README.md - See :
> https://github.com/aghaisas/jfx-tests/tree/update_readme
Ajit Ghaisas has updated the pull request incrementally with one additional
commit since the last revision:
On Fri, 15 Sep 2023 07:09:13 GMT, Ajit Ghaisas wrote:
> - Removed README file
> - Added README.md file with details
>
> For formatted output of README.md - See :
> https://github.com/aghaisas/jfx-tests/tree/update_readme
This pull request has now been integrated.
Changeset:
On Thu, 21 Sep 2023 16:39:35 GMT, Andy Goryachev wrote:
>> Adding changes to the MonkeyTester application accumulated since the last
>> test sprint, from a separate repository
>> https://github.com/andy-goryachev-oracle/MonkeyTest
>>
>> User preferences location:
>> The applications stores its
On Fri, 22 Sep 2023 09:40:31 GMT, Jayathirth D V wrote:
> When we run 3D picking tests under test/scenegraph/fx3d/picking/parallel/
> nothing is displayed on the window and subscene parallel camera tests under
> test/scenegraph/fx3d/subscene/picking/parallel/ throw
> UnsupportedOperationExcept
On Thu, 21 Sep 2023 19:10:38 GMT, Kevin Rushforth wrote:
> The fix for [JDK-8233678](https://bugs.openjdk.org/browse/JDK-8233678) added
> a step to the NSApplication initialization to deactivate and then reactivate
> the application. We trigger the deactivation the first time
> applicationDidB
On Fri, 29 Sep 2023 11:03:56 GMT, Jayathirth D V wrote:
> While debugging subscene picking tests it was identified that in subscene
> mouse events are not captured when we click on area where nothing is drawn or
> filled.
> All the picking tests actually click on these null points and expect a
On Tue, 22 Aug 2023 20:46:21 GMT, Andy Goryachev wrote:
> The fix uses character BreakIterator instead of the logic that relies on
> caretBounds/hitTest/rangeShape in TextInputControl.nextCharacterVisually().
>
> I believe this is a more reliable method of navigation, as it behaves in sync
> w
On Tue, 19 Sep 2023 21:53:16 GMT, Andy Goryachev wrote:
>> Creating the first batch of tests and testing framework that enables writing
>> behavior tests for javafx controls, focusing on key bindings. The idea is
>> to make writing such tests a simple process.
>>
>> This PR deals with the d
On Fri, 6 Oct 2023 18:58:56 GMT, Andy Goryachev wrote:
>> Creating the first batch of tests and testing framework that enables writing
>> behavior tests for javafx controls, focusing on key bindings. The idea is
>> to make writing such tests a simple process.
>>
>> This PR deals with the de
On Fri, 13 Oct 2023 03:23:42 GMT, Prasanta Sadhukhan
wrote:
> Corrected the typo
Looks good!
-
Marked as reviewed by aghaisas (Reviewer).
PR Review: https://git.openjdk.org/jfx/pull/1260#pullrequestreview-1675641812
On Thu, 12 Oct 2023 17:08:39 GMT, Andy Goryachev wrote:
>> Creating the first batch of tests and testing framework that enables writing
>> behavior tests for javafx controls, focusing on key bindings. The idea is
>> to make writing such tests a simple process.
>>
>> This PR deals with the d
On Sat, 14 Oct 2023 05:17:44 GMT, Ambarish Rapte wrote:
> Few dependency were missed to be added for webkit build.
> With this change webkit build completes successfully.
> Please review
Approving based on successful CI builds on all platforms.
-
Marked as reviewed by aghaisas (Rev
On Fri, 4 Aug 2023 18:13:34 GMT, Marius Hanl wrote:
> Before, the `updateItem` method was called with the new value that was
> committed via `commitEdit()`.
> This is problematic as developers may setup a commit handler via
> `setOnEditCommit`, which may reject the edit (or change the value oth
Vote: YES
Regards,
Ajit
> On 16-Nov-2023, at 9:08 PM, Kevin Rushforth
> wrote:
>
> I hereby nominate Florian Kirmaier [1] to OpenJFX Committer.
>
> Florian is an OpenJFX community member, who has contributed 24 commits [2] to
> OpenJFX.
>
> Votes are due by November 30, 2023 at 16:00 UTC.
>
Vote: YES
Regards,
Ajit
> On 16-Nov-2023, at 9:24 PM, Kevin Rushforth
> wrote:
>
> I hereby nominate Martin Fox [1] to OpenJFX Committer.
>
> Martin is an OpenJFX community member, who has contributed 12 commits [2] to
> OpenJFX.
>
> Votes are due by November 30, 2023 at 16:00 UTC.
>
> Onl
On Wed, 22 Nov 2023 17:05:36 GMT, Ambarish Rapte wrote:
>> Currently we use the value of spinner as it's `UIA_NamePropertyId` when a11y
>> client application requests for it.
>> Ideally we should use the text set by `Node.setAccessibleText()` as the
>> `UIA_NamePropertyId`.
>> For other control
On Mon, 5 Feb 2024 16:46:40 GMT, Martin Fox wrote:
>> Turning on warnings-as-errors for the macOS glass native code. Deprecated
>> declarations are excluded and still appear as warnings.
>>
>> In the code that tries to locate the application's dock icon there were
>> three instances where `NO`
On Wed, 13 Mar 2024 08:56:13 GMT, Jayathirth D V wrote:
> Updated test to get screen capture in different platforms to see how we are
> picking colors. Found that this test fails because it assumes that red,green
> & blue bands in the test image are of equal size and picks color based on
> tha
On Mon, 18 Mar 2024 23:31:03 GMT, Andy Goryachev wrote:
> Q: Any other files?
May be `.DS_Store` file
-
PR Comment: https://git.openjdk.org/jfx/pull/1408#issuecomment-2007598297
On Mon, 18 Mar 2024 23:31:03 GMT, Andy Goryachev wrote:
> Add hs_err_pid* to .gitignore
>
> Q: Any other files?
Marked as reviewed by aghaisas (Reviewer).
Oops... I saw the JBS Description now. It is already ignored.
-
PR Review: https://git.openjdk.org/jfx/pull/1408#pullrequestr
On Fri, 22 Mar 2024 15:54:42 GMT, Andy Goryachev wrote:
> Fixing missing @Overrides in demo apps.
>
> This is still a trivial change since all the spots are identified by the IDE.
Looks good.
-
Marked as reviewed by aghaisas (Reviewer).
PR Review: https://git.openjdk.org/jfx/pull
On Fri, 22 Mar 2024 15:55:35 GMT, Andy Goryachev wrote:
> Fixing missing @ OVERRIDES in tests.
>
> This is still a trivial change since all the spots are identified by the IDE.
Looks good.
-
Marked as reviewed by aghaisas (Reviewer).
PR Review: https://git.openjdk.org/jfx/pull/14
A null check has been added to below SpinnerValueFactory classes in
valueProperty() ChangeListeners-
- `IntegerSpinnerValueFactory`
- `LocalDateSpinnerValueFactory`
- `LocalTimeSpinnerValueFactory`
- `ListSpinnerValueFactory`
Added 5 tests that detect NPE for above 4 Spinner factories.
Only `Doub
NPE for above 4 Spinner factories.
> Only `DoubleSpinnerValueFactory` already had a valid null check - so the test
> for it passes before and after.
Ajit Ghaisas has updated the pull request incrementally with one additional
commit since the last revision:
Simplify null asserts
On Wed, 10 Aug 2022 22:14:53 GMT, Andy Goryachev wrote:
>> - added Skin.install()
>> - javadoc changes for Skinnable.setSkin(Skin)
>>
>> no code changes for Skinnable.setSkin(Skin) yet.
>
> Andy Goryachev has updated the pull request incrementally with one additional
> commit since the last rev
On Thu, 4 Aug 2022 14:30:40 GMT, Johan Vos wrote:
> When calculating the viewportOffset, we now already take into account that
> cells will have to shift.
>
> This prevents the creation of temporary empty cells in the layout phase.
> One test needed to be fixed, since the number of invocations
On Tue, 2 Aug 2022 10:45:54 GMT, Jose Pereda wrote:
> This PR fixes an issue when there is a DialogPane that has no header and no
> graphic is set, by adding the `graphic-container` styleclass only when there
> is a non-null graphic applied, preventing the padding that otherwise the
> graphic
On Tue, 2 Aug 2022 10:45:54 GMT, Jose Pereda wrote:
> As part of this PR or as possible follow-up, it could be also discussed that
> the right/bottom padding of the graphic container shouldn't be 0 when there
> is no header and the graphic is laid out to the left of the content area.
We can di
On Fri, 12 Aug 2022 15:08:27 GMT, Andy Goryachev wrote:
>>>
>>> The tests were added to both TableViewSelectionModelImplTest and
>>> TreeTableViewSelectionModelImplTest.
>>
>> hmm .. in TreeTableViewSelectionModelImplTest, I don't see any of the
>> testRowSelectionAfterSelectAndHideLastColum
On Fri, 12 Aug 2022 17:21:24 GMT, Andy Goryachev wrote:
>> 1. reword SelectionModel.isSelected(int) javadoc, removing incorrect
>> statement "Is functionally equivalent to calling
>> getSelectedIndices().contains(index)."
>> 2. reimplement TableView.TableViewSelectionModel.isSelected(int) meth
On Wed, 17 Aug 2022 16:36:24 GMT, Ambarish Rapte wrote:
>> Accessibility is not implemented for JavaFX dialogs. This change is to
>> implement the accessibility on windows platform.
>> Without this fix : On Windows platform, content of Dialog are not read by
>> Windows Narrator or JAWS.
>> With
On Wed, 17 Aug 2022 02:21:30 GMT, Sai Pradeep Dandem wrote:
>> **Issue:**
>> When the `TableView` is set with built-in `CONSTRAINED_RESIZE_POLICY`, the
>> horizontal scroll bar keeps flickering when the `TableView` width is reduced.
>>
>> **Cause:**
>> The table columns widths are recalculated
On Wed, 17 Aug 2022 12:02:04 GMT, Ambarish Rapte wrote:
> Update libjpeg to current version release [9e](http://www.ijg.org/) of
> 16-Jan-2022
>
> reference: https://jpegclub.org/reference/reference-sources/
>
> Verified all test run on Windows and MacOS
Marked as reviewed by aghaisas (Review
On Fri, 26 Aug 2022 05:48:54 GMT, Ambarish Rapte wrote:
>> Issue:
>> When Narrator is running,
>> 1. Deleting last character from `TextField` throws
>> `IllegalArgumentException`, and
>> 2. Deleting last character from `TextArea` throws `NPE`.
>>
>> Fix:
>> When character is deleted, we recei
On Wed, 10 Aug 2022 06:56:50 GMT, Ajit Ghaisas wrote:
> A null check has been added to below SpinnerValueFactory classes in
> valueProperty() ChangeListeners-
> - `IntegerSpinnerValueFactory`
> - `LocalDateSpinnerValueFactory`
> - `LocalTimeSpinnerValueFactory`
> - `ListS
On Tue, 30 Aug 2022 11:21:26 GMT, Jose Pereda wrote:
>> The corner region is currently laid out with this assumption:
>>
>> // position the top-right rectangle (which sits above the scrollbar)
>>
>> However, the vertical scrollbar is not always visible. Therefore, when that
>> is the c
On Mon, 12 Sep 2022 16:27:06 GMT, Marius Hanl wrote:
>> This PR fixes a bunch of NPEs when a null `SelectionModel` or `FocusModel`
>> is set on a `ListView`.
>>
>> The following NPEs are fixed (all are also covered by exactly one test case):
>> NPEs with null selection model:
>> - Mouse click o
On Wed, 10 Aug 2022 08:14:13 GMT, Marius Hanl wrote:
>> Initialize the `(Tree)TableView` when creating the measure row.
>> This will guarantee, that we can access the `(Tree)TableView` in the
>> `(Tree)TableRowSkin`, which is currently only null during the autosizing (It
>> is always set otherw
On Mon, 12 Sep 2022 15:33:29 GMT, Andy Goryachev wrote:
>> Modified the tree/table view internals to suppress the horizontal (a.k.a.
>> breadth in VirtualFlow) scroll bar when a constrained resize mode is in
>> effect. This change complements fixes added in
>> [JDK-8089009](https://bugs.openj
On Fri, 16 Sep 2022 16:13:57 GMT, Andy Goryachev wrote:
>> Modified the tree/table view internals to suppress the horizontal (a.k.a.
>> breadth in VirtualFlow) scroll bar when a constrained resize mode is in
>> effect. This change complements fixes added in
>> [JDK-8089009](https://bugs.openj
On Mon, 19 Sep 2022 15:44:58 GMT, Andy Goryachev wrote:
>> The issue is caused by TreeTableRow incorrectly selected when cell selection
>> mode is enabled.
>>
>> Changes:
>> - modified TreeTableRow.updateSelection()
>
> Andy Goryachev has updated the pull request incrementally with one addition
On Tue, 20 Sep 2022 18:59:40 GMT, Andy Goryachev wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/control/TreeTableRowTest.java
>> line 840:
>>
>>> 838: /** TreeTableView with cell selection enabled should not select
>>> TreeTableRows */
>>> 839: @Test
>>> 840: pub
On Tue, 20 Sep 2022 19:06:19 GMT, Andy Goryachev wrote:
>> The issue is caused by TreeTableRow incorrectly selected when cell selection
>> mode is enabled.
>>
>> Changes:
>> - modified TreeTableRow.updateSelection()
>
> Andy Goryachev has updated the pull request incrementally with one addition
On Wed, 28 Sep 2022 19:07:26 GMT, Andy Goryachev wrote:
>> The issue is caused by TreeTableRow incorrectly selected when cell selection
>> mode is enabled.
>>
>> Changes:
>> - modified TreeTableRow.updateSelection()
>
> Andy Goryachev has updated the pull request incrementally with one addition
On Tue, 23 Aug 2022 20:20:11 GMT, Andy Goryachev wrote:
>> Setting a null selection model in TableView and TreeTableView produce NPE on
>> sorting (and probably in some other situations) because the check for null
>> is missing in several places.
>>
>> Setting a null selection model is a vali
On Mon, 31 Oct 2022 16:42:34 GMT, Andy Goryachev wrote:
>> - added Skin.install()
>> - javadoc changes for Skinnable.setSkin(Skin)
>
> Andy Goryachev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8290844: review comments
Overall this loo
On Thu, 3 Nov 2022 09:43:39 GMT, Ajit Ghaisas wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8290844: review comments
>
> modules/javafx.controls/src/main/java/javafx/scene/contr
On Thu, 3 Nov 2022 15:49:07 GMT, Andy Goryachev wrote:
>> - added Skin.install()
>> - javadoc changes for Skinnable.setSkin(Skin)
>
> Andy Goryachev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8290844: review comments
Marked as reviewe
On Thu, 3 Nov 2022 15:56:33 GMT, Andy Goryachev wrote:
>> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/CellBehaviorBase.java
>> line 274:
>>
>>> 272: protected void simpleSelect(MouseButton button, int clickCount,
>>> boolean shortcutDown) {
>>> 273:
1 - 100 of 233 matches
Mail list logo
