On Mon, 31 Oct 2022 16:42:34 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> - added Skin.install()
>> - javadoc changes for Skinnable.setSkin(Skin)
>
> Andy Goryachev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8290844: review comments
Overall this looks fine.
I have identified some minor javadoc style issues. I don't think we need to
redo the CSR just for these corrections.
modules/javafx.controls/src/main/java/javafx/scene/control/Skin.java line 86:
> 84: * @implNote
> 85: * Skins only need to implement {@code install} if they need to make
> direct changes to the control
> 86: * like overwriting properties or event handlers. Such skins should
> ensure these changes are undone in
Very minor : There are two spaces before `Such skins...`
modules/javafx.controls/src/main/java/javafx/scene/control/Skin.java line 94:
> 92:
> 93: /**
> 94: * Called when a previously installed skin is about to be removed
> from its associated control.
Use @code tag for `Skin` and `Control` in this description.
modules/javafx.controls/src/main/java/javafx/scene/control/Skinnable.java line
39:
> 37: public interface Skinnable {
> 38: /**
> 39: * The Skin responsible for rendering this {@code Skinnable}. From the
Use @code tag for `Skin`
-------------
PR: https://git.openjdk.org/jfx/pull/845
