On Tue, 20 Sep 2022 18:59:40 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/control/TreeTableRowTest.java
>> line 840:
>>
>>> 838: /** TreeTableView with cell selection enabled should not select
>>> TreeTableRows */
>>> 839: @Test
>>> 840: public void test_TreeTableView_jdk_8292353_select_all() {
>>
>> This test passes with or without the code changes.
>> If test intention is to increase coverage, then the comment `// JDK-8292353
>> failure` needs to be removed. If not, the test needs some correction.
>
> similarly, this test also fails without code changes:
>
>
> TreeTableRowTest > test_TreeTableView_jdk_8292353_select_all FAILED
> org.opentest4j.AssertionFailedError: expected: <false> but was: <true>
> at
> app//org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
> at
> app//org.junit.jupiter.api.AssertFalse.assertFalse(AssertFalse.java:40)
> at
> app//org.junit.jupiter.api.AssertFalse.assertFalse(AssertFalse.java:35)
> at
> app//org.junit.jupiter.api.Assertions.assertFalse(Assertions.java:227)
> at
> app//test.javafx.scene.control.TreeTableRowTest.test_TreeTableView_jdk_8292353_select_all(TreeTableRowTest.java:870)
A clean build and run behaves correctly. This test fails without code changes
and passes with them.
Sorry for the confusion!
>> modules/javafx.controls/src/test/java/test/javafx/scene/control/TreeTableRowTest.java
>> line 875:
>>
>>> 873: /** TreeTableView with cell selection enabled should not select
>>> TreeTableRows */
>>> 874: @Test
>>> 875: public void test_TreeTableView_jdk_8292353_select_all_but_one() {
>>
>> This test passes with or without the code changes.
>> If test intention is to increase coverage, then the comment `// JDK-8292353
>> failure` needs to be removed. If not, the test needs some correction.
>
> I don't understand. It fails for me
>
>
> TreeTableRowTest > test_TreeTableView_jdk_8292353_select_all_but_one FAILED
> org.opentest4j.AssertionFailedError: expected: <false> but was: <true>
> at
> app//org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
> at
> app//org.junit.jupiter.api.AssertFalse.assertFalse(AssertFalse.java:40)
> at
> app//org.junit.jupiter.api.AssertFalse.assertFalse(AssertFalse.java:35)
> at
> app//org.junit.jupiter.api.Assertions.assertFalse(Assertions.java:227)
> at
> app//test.javafx.scene.control.TreeTableRowTest.test_TreeTableView_jdk_8292353_select_all_but_one(TreeTableRowTest.java:902)
>
>
> command line:
A clean build and run behaves correctly. This test fails without code changes
and passes with them.
Sorry for the confusion!
-------------
PR: https://git.openjdk.org/jfx/pull/875
