Re: RFR: 8340344: The first item in TreeView is not aligned in the beginning [v5]

2025-05-12 Thread Ziad El Midaoui
On Fri, 9 May 2025 10:51:20 GMT, Ziad El Midaoui wrote: >> The issue occurred because items preceding an item with children (items with >> a disclosure node) had different widths, which led to misalignment. This can >> be fixed by requesting a cell relayout whenever the disclosure node's width

Re: RFR: 8355774: RichTextArea: provide mechanism for CSS styling of highlights

2025-05-12 Thread PavelTurk
Andy, unfortunately, I don't have that text and the link to the issue will come only when the issue is approved. Sorry, we can only wait now. Best regards. Pavel On 5/12/25 20:40, Andy Goryachev wrote: Pavel: if you don't mind, could you forward the text from the bug to the mailing list as

Re: RFR: 8355774: RichTextArea: provide mechanism for CSS styling of highlights

2025-05-12 Thread Andy Goryachev
JDK-8355774 adds methods to style highlights added via addHighlight() with CSS. What (I think) you want is an ability to style a single text segment with (background | underlines | etc) attributes, which is still debatable - because you already can do all that, albeit with some additional code.

Re: RFR: 8355774: RichTextArea: provide mechanism for CSS styling of highlights

2025-05-12 Thread PavelTurk
Thank you very much for the detailed explanation. Am I right in understanding that JDK-8355774 does not consider the possibility of styling underline/wavy underline via a CSS file (without calling special methods like addHighlight, addWavyUnderline? If so, should I open another issue? Best reg

Re: RFR: 8355774: RichTextArea: provide mechanism for CSS styling of highlights

2025-05-12 Thread Andy Goryachev
Pavel: if you don't mind, could you forward the text from the bug to the mailing list as a new message, so it does not get appended to the PR? The reason is - it'll take some time to percolate the ticket through the webbugs system. Thanks! -andy From: openjfx-dev on behalf of PavelTurk D

Withdrawn: 8350917: Allow parent nodes to provide CSS styleable properties for child nodes

2025-05-12 Thread duke
On Mon, 17 Feb 2025 01:15:37 GMT, John Hendrikx wrote: > 8350917: Allow parent nodes to provide CSS styleable properties for child > nodes This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jfx/pull/1714

Re: RFR: 8356690: Update JUnit to 5.12.2

2025-05-12 Thread Kevin Rushforth
On Sat, 10 May 2025 23:41:44 GMT, Marius Hanl wrote: > This PR bumps the JUnit version to 5.12.2. > Also removed 2 now unused variables since I phased out the JUnit Vintage > Engine + Hamcrest. > > Changelog: > https://junit.org/junit5/docs/current/release-notes/index.html#release-notes-5.12.2

Re: RFR: 8340344: The first item in TreeView is not aligned in the beginning [v5]

2025-05-12 Thread Andy Goryachev
On Fri, 9 May 2025 10:51:20 GMT, Ziad El Midaoui wrote: >> The issue occurred because items preceding an item with children (items with >> a disclosure node) had different widths, which led to misalignment. This can >> be fixed by requesting a cell relayout whenever the disclosure node's width

Re: RFR: 8351867: No UI changes while iconified

2025-05-12 Thread Martin Fox
On Thu, 13 Mar 2025 10:36:40 GMT, John Hendrikx wrote: > Adds code to trigger a scene update when a Window is restored > > This seems to solve https://bugs.openjdk.org/browse/JDK-8351867 and > https://bugs.openjdk.org/browse/JDK-8146479 Test file attached. [drawdeiconify.patch](https://github

Re: RFR: 8355774: RichTextArea: provide mechanism for CSS styling of highlights

2025-05-12 Thread PavelTurk
Andy, thank you for your time and the detailed discussion. I'm sure it was very helpful. That's why I just opened a new issue with ID: 9078500. Best regards, Pavel On 5/12/25 19:58, Andy Goryachev wrote: JDK-8355774 adds methods to style highlights added via addHighlight() with CSS. What (I

Re: JavaFX Presentation at JavaOne

2025-05-12 Thread Kevin Rushforth
Thanks for posting this. -- Kevin On 5/10/2025 10:32 PM, Nir Lisker wrote: Just saw Kevin's JavaFX talk released on YT. Thanks Kevin! https://www.youtube.com/watch?v=FxHbXY34iFQ

Re: Add more useful APIs to javafx.scene.text.Font

2025-05-12 Thread Glavo
I hope this issue gets more attention. Can anyone take a look at this email? Glavo On Sun, May 4, 2025 at 4:18 PM Glavo wrote: > Hi, > > We have noticed that JavaFX's strategy for selecting default fonts can > sometimes be quite odd, > and at times it doesn't properly follow the fontconfig conf

Re: RFR: 8355615: ConcurrentModificationException creating MenuBar on background thread [v2]

2025-05-12 Thread Andy Goryachev
On Fri, 2 May 2025 15:44:03 GMT, Andy Goryachev wrote: >> Moving MenuBarSkin initialization code to install() which always happens in >> the FX Application Thread. >> >> Also, ensure that the reverse process also happens in the FX application >> thread. > > Andy Goryachev has updated the pull

Re: RFR: 8355774: RichTextArea: provide mechanism for CSS styling of highlights

2025-05-12 Thread Andy Goryachev
Pavel: Underlines and strike-through attributes are available via StyleAttributeMap.STRIKE_THROUGH and StyleAttributeMap.UNDERLINE (using text color). On the other hand, adding this functionality via addHighlight() would allow the application to style the shapes via CSS. -andy From: openjfx

Re: RFR: 8355774: RichTextArea: provide mechanism for CSS styling of highlights

2025-05-12 Thread PavelTurk
Andy, thank you very much for your response. But as I’ve said many times, I’m only considering styling through a CSS file. Best regards, Pavel On 5/12/25 19:28, Andy Goryachev wrote: Pavel: Underlines and strike-through attributes are available via StyleAttributeMap.STRIKE_THROUGH and Style

Re: RFR: 8355774: RichTextArea: provide mechanism for CSS styling of highlights

2025-05-12 Thread Andy Goryachev
Yes, I know. But we must support both options, since the RichTextArea provides models that allow to style programmatically and independently from the stylesheet. Our goal is to provide the tools that can be used equally well in either situation. "The most frequent operations must be easy, all