> The RichTextArea control
> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
> control that needs non-trivial navigation within complex or wrapped text
> needs a public API to get information about text layout.
>
> This change fixes the missing functionality by addin
On Thu, 10 Oct 2024 08:46:25 GMT, Michael Strauß wrote:
> Martin says [this](https://bugs.openjdk.org/browse/JDK-8095467) about
> NEXT_IN_LINE back in 2014
Let me see if we can get rid of it.
-
PR Comment: https://git.openjdk.org/jfx/pull/1555#issuecomment-2407799910
On Fri, 11 Oct 2024 14:22:27 GMT, Jurgen wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> convert to wrapper
>
> Wrt to rangeShape & underlineShape: RichTextFX quite successfully uses the
> PathElement[] returned
Disabled the pdb file generation in order to resolve the build failure.
Sanity testing looks fine. Verified build on windows, mac and linux.
-
Commit messages:
- remove condition
- Disable pdb files
Changes: https://git.openjdk.org/jfx/pull/1599/files
Webrev: https://webrevs.open
> Add the `jdk.jsobject` module to JavaFX. This module is currently delivered
> by the JDK, but will be terminally-deprecated in JDK 24 by
> [JDK-8311530](https://bugs.openjdk.org/browse/JDK-8311530), which is out for
> review at openjdk/jdk#20555. We therefore plan to start delivering it with
On Fri, 11 Oct 2024 18:59:43 GMT, Michael Strauß wrote:
> It's more like the existing tools are sufficient for this particular
> scenario. Or put another way: a custom TraversalPolicy is not less complex
> than what I've described, since it needs to solve exactly the same problems
> (namely, s
On Thu, 10 Oct 2024 19:23:47 GMT, Andy Goryachev wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> convert to wrapper
>
> One additional thought/question:
>
> There is a need to extract a few more data points from
This PR adds a title-mentioned fallback to `ImageStorage.java` and a test for
that specific scenario.
In `ImageStorage.loadAll()` we still prefer the Image path that was provided by
the user, but if it is missing we will now try to add a `@1x` suffix to Image
name and give it one last try.
Add
On Thu, 26 Sep 2024 10:30:47 GMT, Florian Kirmaier
wrote:
> Fixing the wrong TriangleMesh.vertexFormat property.
> TriangleMesh.getVertexFormat() and TriangleMesh.vertexProperty().get()
> initially returned different values, which are now fixed.
This pull request has now been integrated.
Cha
On Wed, 9 Oct 2024 22:41:29 GMT, Andy Goryachev wrote:
>> The RichTextArea control
>> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
>> control that needs non-trivial navigation within complex or wrapped text
>> needs a public API to get information about text layo
> Incubating a new feature - rich text control, **RichTextArea**, intended to
> bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. The
> main design goal is to provide a control that is complete enough to be useful
> out-of-the box, as well as open to extension by the appl
> Incubating a new feature - rich text control, **RichTextArea**, intended to
> bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. The
> main design goal is to provide a control that is complete enough to be useful
> out-of-the box, as well as open to extension by the appl
On Thu, 10 Oct 2024 23:26:27 GMT, John Hendrikx wrote:
> You say a "bunch of event handlers" is less optimal; then optimize that. It's
> already there. In fact, a simple utility makes it a one-liner...
Let me know if I understood you correctly:
Let's consider an example where the application h
On Wed, 9 Oct 2024 22:41:29 GMT, Andy Goryachev wrote:
>> The RichTextArea control
>> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
>> control that needs non-trivial navigation within complex or wrapped text
>> needs a public API to get information about text layo
On Thu, 10 Oct 2024 12:31:53 GMT, Kevin Rushforth wrote:
>> Add the `jdk.jsobject` module to JavaFX. This module is currently delivered
>> by the JDK, but will be terminally-deprecated in JDK 24 by
>> [JDK-8311530](https://bugs.openjdk.org/browse/JDK-8311530), which is out for
>> review at op
On Thu, 10 Oct 2024 08:46:25 GMT, Michael Strauß wrote:
>>> My suggestion for a better API is: have two separate knobs to configure
>>> directional and logical focus traversal, and provide a very small set of
>>> curated policies. We should only consider opening up the API to allow more
>>> cu
On Thu, 10 Oct 2024 08:46:25 GMT, Michael Strauß wrote:
>>> My suggestion for a better API is: have two separate knobs to configure
>>> directional and logical focus traversal, and provide a very small set of
>>> curated policies. We should only consider opening up the API to allow more
>>> cu
On Fri, 11 Oct 2024 17:33:00 GMT, Michael Strauß wrote:
>>> > My suggestion for a better API is: have two separate knobs to configure
>>> > directional and logical focus traversal, and provide a very small set of
>>> > curated policies. We should only consider opening up the API to allow
>>> >
On Fri, 11 Oct 2024 16:49:30 GMT, Andy Goryachev wrote:
> > You say a "bunch of event handlers" is less optimal; then optimize that.
> > It's already there. In fact, a simple utility makes it a one-liner...
>
> Let me know if I understood you correctly:
>
> Let's consider an example where the
On Fri, 11 Oct 2024 17:22:02 GMT, Hima Bindu Meda wrote:
> Disabled the pdb file generation in order to resolve the build failure.
> Sanity testing looks fine. Verified build on windows, mac and linux.
This looks good. Since it is a very safe fix, and well-tested -- restoring the
compile flags
On Fri, 11 Oct 2024 17:40:45 GMT, Michael Strauß wrote:
> So, inside of the single event filter, I'm going to call requestFocus() on
> the next element as dictated by my business rules.
so basically reinvent TraversalPolicy?
-
PR Comment: https://git.openjdk.org/jfx/pull/1555#issu
On Thu, 10 Oct 2024 12:31:53 GMT, Kevin Rushforth wrote:
>> Add the `jdk.jsobject` module to JavaFX. This module is currently delivered
>> by the JDK, but will be terminally-deprecated in JDK 24 by
>> [JDK-8311530](https://bugs.openjdk.org/browse/JDK-8311530), which is out for
>> review at op
On Thu, 10 Oct 2024 17:52:29 GMT, Andy Goryachev wrote:
> - fixed the issue
> - added unit tests
> - clarified default value of `ScrollPane.fitWidth` and `ScrollPane.fitHeight`
> properties
>
> No CSR is needed as it is a minor clarification.
This pull request has now been integrated.
Changes
On Fri, 11 Oct 2024 17:47:19 GMT, Andy Goryachev wrote:
> > So, inside of the single event filter, I'm going to call requestFocus() on
> > the next element as dictated by my business rules.
>
> so basically reinvent TraversalPolicy?
It's more like the existing tools are sufficient for this par
On Fri, 11 Oct 2024 18:59:43 GMT, Michael Strauß wrote:
>>> So, inside of the single event filter, I'm going to call requestFocus() on
>>> the next element as dictated by my business rules.
>>
>> so basically reinvent TraversalPolicy?
>
>> > So, inside of the single event filter, I'm going to c
> Release notes for JavaFX 23.0.1.
>
> Notes to reviewers:
>
> I used the following filter to pick the issues:
>
> https://bugs.openjdk.org/issues/?filter=46412
>
> The original filter, with the backport IDs, is here:
>
> https://bugs.openjdk.org/issues/?filter=46411
>
> As usual, I excluded
26 matches
Mail list logo
