On Fri, 11 Oct 2024 17:22:02 GMT, Hima Bindu Meda <hm...@openjdk.org> wrote:
> Disabled the pdb file generation in order to resolve the build failure. > Sanity testing looks fine. Verified build on windows, mac and linux. This looks good. Since it is a very safe fix, and well-tested -- restoring the compile flags we were using in JavaFX 23 -- only a single reviewer is needed. Also, no need to wait the full 24 hours, although you might wait until Monday morning to integrate in case @tiainen would like a chance to look at it. modules/javafx.web/src/main/native/Source/cmake/OptionsMSVC.cmake line 123: > 121: # Suppress creation of pdb files for Release builds > 122: # FIXME: Need to re-enable the flag for Debug builds > 123: #add_compile_options(/Zi /GS) I can confirm that this restores the build logic we had prior to the WebKit 619.1 update, by removing the `/Zi` and `/GS` compile flags. See the following from the commit right before the last WebKit update: https://github.com/openjdk/jfx/blob/e3c15957488256ec53c5fb9978e336c59b69d65e/modules/javafx.web/src/main/native/Source/cmake/OptionsMSVC.cmake#L119-L122 I also note that previously we had also removed the "`/DEBUG` linker flag, but since that isn't relevant to the errors we are seeing on some of our build machines, we could consider filing a P4 follow-up bug to consider also removing the `/DEBUG` linker flag for our builds. ------------- Marked as reviewed by kcr (Lead). PR Review: https://git.openjdk.org/jfx/pull/1599#pullrequestreview-2363299183 PR Review Comment: https://git.openjdk.org/jfx/pull/1599#discussion_r1797257531
