On Fri, 11 Oct 2024 14:22:27 GMT, Jurgen <d...@openjdk.org> wrote: >> Andy Goryachev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> convert to wrapper > > Wrt to rangeShape & underlineShape: RichTextFX quite successfully uses the > PathElement[] returned to it's advantage and so wouldn't gain from Rectangles. > > `.strikeThroughShape()` should be added to Text/TextFlow for consistency sake.
thank you so much @Jugen for checking and the feedback! I see that a lot of what is being done in TextFlowExt should become unnecessary with the new API (or maybe even the whole thing might become unnecessary). Also, while the new API do not address [JDK-8091012](https://bugs.openjdk.org/browse/JDK-8091012) _directly_, that is, there is no field added to `HitInfo`, it looks like the information provided by the LayoutInfo should be sufficient to implement what you guys need as a utility, since you will have the geometry of text lines in the layout, right? Anyway, thank you. I agree with you that we should add T/TF.strikeThroughShape() for consistency sake. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1596#issuecomment-2407808643
