Re: RFR: 8341090: Remove support for security manager from JavaFX [v4]

2024-10-28 Thread Johan Vos
On Wed, 23 Oct 2024 19:36:53 GMT, Kevin Rushforth wrote: >> This PR removes support for running JavaFX applications with the Java >> Security Manager. >> >> The initial work was done in 4 separate commits as follows: >> >> * Fail fast at startup if the Security Manager is enabled >> * Remove `

Re: RFR: 8341090: Remove support for security manager from JavaFX [v2]

2024-10-25 Thread Kevin Rushforth
On Fri, 18 Oct 2024 10:13:13 GMT, Johan Vos wrote: >> Kevin Rushforth has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >> commits

Re: RFR: 8341090: Remove support for security manager from JavaFX [v4]

2024-10-23 Thread Kevin Rushforth
> This PR removes support for running JavaFX applications with the Java > Security Manager. > > The initial work was done in 4 separate commits as follows: > > * Fail fast at startup if the Security Manager is enabled > * Remove `-Djava.security.manager` and all security policy files; delete >

Re: RFR: 8341090: Remove support for security manager from JavaFX [v3]

2024-10-21 Thread Kevin Rushforth
> This PR removes support for running JavaFX applications with the Java > Security Manager. > > The initial work was done in 4 separate commits as follows: > > * Fail fast at startup if the Security Manager is enabled > * Remove `-Djava.security.manager` and all security policy files; delete >

Re: RFR: 8341090: Remove support for security manager from JavaFX [v2]

2024-10-18 Thread Kevin Rushforth
On Fri, 18 Oct 2024 10:13:13 GMT, Johan Vos wrote: > When you say "all tests pass", what set of tests are you referring to? We > have a number of properties that determine which tests are actually executed, > and I believe in general it would be good if we could standardize on what set > of te

Re: RFR: 8341090: Remove support for security manager from JavaFX [v2]

2024-10-18 Thread Johan Vos
On Thu, 17 Oct 2024 21:47:00 GMT, Kevin Rushforth wrote: >> This PR removes support for running JavaFX applications with the Java >> Security Manager. >> >> The initial work was done in 4 separate commits as follows: >> >> * Fail fast at startup if the Security Manager is enabled >> * Remove `

Re: RFR: 8341090: Remove support for security manager from JavaFX [v2]

2024-10-17 Thread Kevin Rushforth
> This PR removes support for running JavaFX applications with the Java > Security Manager. > > The initial work was done in 4 separate commits as follows: > > * Fail fast at startup if the Security Manager is enabled > * Remove `-Djava.security.manager` and all security policy files; delete >

Re: RFR: 8341090: Remove support for security manager from JavaFX

2024-10-16 Thread Ambarish Rapte
On Mon, 7 Oct 2024 20:03:49 GMT, Kevin Rushforth wrote: > This PR removes support for running JavaFX applications with the Java > Security Manager. > > The initial work was done in 4 separate commits as follows: > > * Fail fast at startup if the Security Manager is enabled > * Remove `-Djava.s

Re: RFR: 8341090: Remove support for security manager from JavaFX

2024-10-09 Thread Andy Goryachev
On Mon, 7 Oct 2024 20:03:49 GMT, Kevin Rushforth wrote: > This PR removes support for running JavaFX applications with the Java > Security Manager. > > The initial work was done in 4 separate commits as follows: > > * Fail fast at startup if the Security Manager is enabled > * Remove `-Djava.s

Re: RFR: 8341090: Remove support for security manager from JavaFX

2024-10-09 Thread Kevin Rushforth
On Wed, 9 Oct 2024 17:26:16 GMT, Andy Goryachev wrote: >> It's related. See this comment in the PR Description: >> >>> ...as part of this, I renamed`CustomSecurityManagerTest` to >>> `StageRobotTest` and removed all of the tests that depend on the security >>> manager, since the test methods t

Re: RFR: 8341090: Remove support for security manager from JavaFX

2024-10-09 Thread Andy Goryachev
On Wed, 9 Oct 2024 16:50:54 GMT, Kevin Rushforth wrote: >> tests/system/src/test/java/test/robot/helloworld/StageRobotTest.java line 53: >> >>> 51: */ >>> 52: @Timeout(value=15000, unit=TimeUnit.MILLISECONDS) >>> 53: public class StageRobotTest extends VisualTestBase { >> >> this file seem unr

Re: RFR: 8341090: Remove support for security manager from JavaFX

2024-10-09 Thread Kevin Rushforth
On Wed, 9 Oct 2024 15:21:09 GMT, Andy Goryachev wrote: >> This PR removes support for running JavaFX applications with the Java >> Security Manager. >> >> The initial work was done in 4 separate commits as follows: >> >> * Fail fast at startup if the Security Manager is enabled >> * Remove `-D

Re: RFR: 8341090: Remove support for security manager from JavaFX

2024-10-09 Thread Andy Goryachev
On Mon, 7 Oct 2024 20:03:49 GMT, Kevin Rushforth wrote: > This PR removes support for running JavaFX applications with the Java > Security Manager. > > The initial work was done in 4 separate commits as follows: > > * Fail fast at startup if the Security Manager is enabled > * Remove `-Djava.s