On Fri, 18 Oct 2024 10:13:13 GMT, Johan Vos <j...@openjdk.org> wrote:
>> Kevin Rushforth has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >> commits since the last revision: >> >> - Merge branch 'master' into 8341090-remove-sm >> - SM removal part 5: Update API spec to remove mention of security manager >> - SM removal part 4: delete remaining tests that depend on security manager >> - SM removal part 2: remove -Djava.security.manager and security policy >> files >> SM removal part 3: remove SandboxAppTest >> - SM removal part 1: Fail fast at startup if the Security Manager is enabled > > @kevinrushforth looks good at first sight. I'm very happy to see the > SandboxAppTest being removed! > When you say "all tests pass", what set of tests are you referring to? We > have a number of properties that determine which tests are actually executed, > and I believe in general it would be good if we could standardize on what set > of tests we consider crucial (e.g. not the ones marked as unstable). > I'd like to run all tests as well on all supported platforms, but your > explanation is very clear and makes sense, hence I don't expect issues. @johanvos Did you want a chance to review this before I integrate it? ------------- PR Comment: https://git.openjdk.org/jfx/pull/1595#issuecomment-2438526155
