On Wed, 9 Oct 2024 16:50:54 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> tests/system/src/test/java/test/robot/helloworld/StageRobotTest.java line 53:
>>
>>> 51: */
>>> 52: @Timeout(value=15000, unit=TimeUnit.MILLISECONDS)
>>> 53: public class StageRobotTest extends VisualTestBase {
>>
>> this file seem unrelated. merge issue?
>
> It's related. See this comment in the PR Description:
>
>> ...as part of this, I renamed`CustomSecurityManagerTest` to `StageRobotTest`
>> and removed all of the tests that depend on the security manager, since the
>> test methods that don't depend on SM are useful functional tests of a
>> Stage's FullScreen and AlwaysOnTop mode.
>
> Because I ended up deleting so much of the file, git's heuristic for
> detecting renames doesn't think that it is.
>
> If you run this diff manually on the PR branch, you'll see it:
>
>
> git diff --find-renames=40 master... --
> tests/system/src/test/java/test/robot/helloworld
sorry, missed that. please ignore the comment.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1595#discussion_r1793899369
