Re: RFR: 8328577: Toolbar's overflow button overlaps the items [v4]

2024-04-15 Thread eduardsdv
On Mon, 15 Apr 2024 12:28:55 GMT, eduardsdv wrote: >> modules/javafx.controls/src/main/java/javafx/scene/control/skin/ToolBarSkin.java >> line 783: >> >>> 781: CustomMenuItem customMenuItem = new >>> CustomMenuItem(node); >>> 782: >>> 783: // RT-36455:

Re: RFR: 8328577: Toolbar's overflow button overlaps the items [v4]

2024-04-15 Thread eduardsdv
On Fri, 12 Apr 2024 18:11:14 GMT, Andy Goryachev wrote: >> eduardsdv has updated the pull request incrementally with one additional >> commit since the last revision: >> >> JDK-8328577: Collect overflowed items in a shadow (overflowBox) pane > > modules/javafx.controls/src/main/java/javafx/sc

Re: RFR: 8328577: Toolbar's overflow button overlaps the items [v4]

2024-04-15 Thread eduardsdv
On Fri, 12 Apr 2024 18:15:41 GMT, Andy Goryachev wrote: >> eduardsdv has updated the pull request incrementally with one additional >> commit since the last revision: >> >> JDK-8328577: Collect overflowed items in a shadow (overflowBox) pane > > modules/javafx.controls/src/main/java/javafx/sc

Re: RFR: 8328577: Toolbar's overflow button overlaps the items [v4]

2024-04-12 Thread Andy Goryachev
On Fri, 12 Apr 2024 15:21:14 GMT, eduardsdv wrote: >> This change fixes the calculation of which nodes go to the toolbar and which >> go to the overflow menu. >> It is now determined before the nodes are removed from the scene graph. >> This is important because the values returned by >> ``Node

Re: RFR: 8328577: Toolbar's overflow button overlaps the items [v4]

2024-04-12 Thread eduardsdv
On Fri, 12 Apr 2024 15:21:14 GMT, eduardsdv wrote: >> This change fixes the calculation of which nodes go to the toolbar and which >> go to the overflow menu. >> It is now determined before the nodes are removed from the scene graph. >> This is important because the values returned by >> ``Node

Re: RFR: 8328577: Toolbar's overflow button overlaps the items [v4]

2024-04-12 Thread eduardsdv
> This change fixes the calculation of which nodes go to the toolbar and which > go to the overflow menu. > It is now determined before the nodes are removed from the scene graph. > This is important because the values returned by > ``Node.prefWidth(..)``/``Node.prefHeight(..)`` may depend on whe