On Fri, 12 Apr 2024 15:21:14 GMT, eduardsdv <d...@openjdk.org> wrote:

>> This change fixes the calculation of which nodes go to the toolbar and which 
>> go to the overflow menu.
>> It is now determined before the nodes are removed from the scene graph.
>> This is important because the values returned by 
>> ``Node.prefWidth(..)``/``Node.prefHeight(..)`` may depend on whether the 
>> node is added to the scene graph.
>> 
>> Furthermore I corrected the ``hasOveflow`` value passed to the 
>> ``organizeOverflow(double, boolean)`` in ``correctOverflow(double)``.
>
> eduardsdv has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   JDK-8328577: Collect overflowed items in a shadow (overflowBox) pane

I solved the issue with applying of CSS by introducing a 'shadow' pane 
(``overflowBox``).
This pane contains the overflowed items all the time unless overflow menu is 
open.
After the overflow menu is closed the items are moved back the to the pane.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1434#issuecomment-2051974734

Reply via email to