On Fri, 12 Apr 2024 18:15:41 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> eduardsdv has updated the pull request incrementally with one additional >> commit since the last revision: >> >> JDK-8328577: Collect overflowed items in a shadow (overflowBox) pane > > modules/javafx.controls/src/main/java/javafx/scene/control/skin/ToolBarSkin.java > line 783: > >> 781: CustomMenuItem customMenuItem = new >> CustomMenuItem(node); >> 782: >> 783: // RT-36455: > > since we moved this code, could we change this line to > ` // RT-36455 (JDK-8096292):` > > and also make sure that this change introduced no regression w.r.t. > JDK-8096292 ? > (My limited testing indicates that it still works as expected, but please > double check) I tested it with the Modena application. The bug is not reproducible. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1434#discussion_r1565712081
