> The fix prevents the DatePicker from losing focus if the date is not parsable.
brunesto has updated the pull request incrementally with one additional commit
since the last revision:
import
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1274/files
- new: https://git.ope
On Wed, 15 Nov 2023 18:58:02 GMT, brunesto wrote:
>> The fix prevents the DatePicker from losing focus if the date is not
>> parsable.
>
> brunesto has updated the pull request incrementally with one additional
> commit since the last revision:
>
> import
perfection achieved :-)
--
On Wed, 15 Nov 2023 18:52:17 GMT, brunesto wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/DatePicker.java
>> line 32:
>>
>>> 30: import java.time.LocalDate;
>>> 31: import java.time.DateTimeException;
>>> 32: import java.time.format.DateTimeParseException;
>>
>> is this i
On Wed, 15 Nov 2023 18:52:17 GMT, brunesto wrote:
>> The fix prevents the DatePicker from losing focus if the date is not
>> parsable.
>
> brunesto has updated the pull request incrementally with one additional
> commit since the last revision:
>
> DatePicker on focus lost catches all except
On Wed, 15 Nov 2023 18:51:28 GMT, Andy Goryachev wrote:
>> brunesto has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> DatePicker on focus lost catches all exceptions around commit
>
> modules/javafx.controls/src/main/java/javafx/scene/cont
> The fix prevents the DatePicker from losing focus if the date is not parsable.
brunesto has updated the pull request incrementally with one additional commit
since the last revision:
DatePicker on focus lost catches all exceptions around commit
-
Changes:
- all: https://git.o
On Wed, 15 Nov 2023 18:15:51 GMT, Marius Hanl wrote:
> I just wonder if we want to catch `Exception` here as well, as it was done in
> the old code.
> The contract then would be: If a converter throws any exception, we cancel
> the edit.
There might be some discussion on that, but yes, I'd rat
On Wed, 15 Nov 2023 18:10:28 GMT, Marius Hanl wrote:
>> brunesto has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> inlined
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/DatePickerTest.java
> line 765:
>
>> 763:
> The fix prevents the DatePicker from losing focus if the date is not parsable.
brunesto has updated the pull request incrementally with one additional commit
since the last revision:
minor
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1274/files
- new: https://git.open
On Wed, 15 Nov 2023 09:37:23 GMT, brunesto wrote:
>> The fix prevents the DatePicker from losing focus if the date is not
>> parsable.
>
> brunesto has updated the pull request incrementally with one additional
> commit since the last revision:
>
> inlined
Looks good to me, just some minor
On Wed, 15 Nov 2023 09:37:23 GMT, brunesto wrote:
>> The fix prevents the DatePicker from losing focus if the date is not
>> parsable.
>
> brunesto has updated the pull request incrementally with one additional
> commit since the last revision:
>
> inlined
Looks good, thank you for making t
On Tue, 14 Nov 2023 21:31:59 GMT, Andy Goryachev wrote:
>> brunesto has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> minor
>
> modules/javafx.controls/src/main/java/javafx/scene/control/DatePicker.java
> line 151:
>
>> 149: focu
> The fix prevents the DatePicker from losing focus if the date is not parsable.
brunesto has updated the pull request incrementally with one additional commit
since the last revision:
inlined
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1274/files
- new: https://git.op
On Fri, 10 Nov 2023 16:51:22 GMT, brunesto wrote:
>> The fix prevents the DatePicker from losing focus if the date is not
>> parsable.
>
> brunesto has updated the pull request incrementally with one additional
> commit since the last revision:
>
> minor
thank you for adding a test case!
t
> The fix prevents the DatePicker from losing focus if the date is not parsable.
brunesto has updated the pull request incrementally with one additional commit
since the last revision:
minor
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1274/files
- new: https://git.open
On Thu, 2 Nov 2023 11:55:46 GMT, Kevin Rushforth wrote:
>> tests/system/src/test/java/test/robot/javafx/scene/DatePickerOnFocusLostTest.java
>> line 98:
>>
>>> 96: // 3. Click on button to grab the focus and hence attempt to
>>> datePicker.commitValue()
>>> 97: // 4. Verify that in cas
> The fix prevents the DatePicker from losing focus if the date is not parsable.
brunesto has updated the pull request incrementally with one additional commit
since the last revision:
replaced robot test by plain junit
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1274/fi
On Tue, 31 Oct 2023 19:20:48 GMT, brunesto wrote:
> The fix prevents the DatePicker from losing focus if the date is not parsable.
modules/javafx.controls/src/main/java/javafx/scene/control/DatePicker.java line
159:
> 157: * This is to address https://bugs.openjdk.org/browse/JDK-8303478
>
On Tue, 31 Oct 2023 20:01:39 GMT, Michael Strauß wrote:
>> The fix prevents the DatePicker from losing focus if the date is not
>> parsable.
>
> modules/javafx.controls/src/main/java/javafx/scene/control/DatePicker.java
> line 159:
>
>> 157: * This is to address https://bugs.openjdk.org/b
On Wed, 1 Nov 2023 15:20:29 GMT, Andy Goryachev wrote:
>> The fix prevents the DatePicker from losing focus if the date is not
>> parsable.
>
> tests/system/src/test/java/test/robot/javafx/scene/DatePickerOnFocusLostTest.java
> line 2:
>
>> 1: /*
>> 2: * Copyright (c) 2018, 2023, Oracle and/o
On Thu, 2 Nov 2023 08:01:01 GMT, Marius Hanl wrote:
>> The fix prevents the DatePicker from losing focus if the date is not
>> parsable.
>
> modules/javafx.controls/src/main/java/javafx/scene/control/DatePicker.java
> line 157:
>
>> 155:
>> 156: /**
>> 157: * This is to address https
On Tue, 31 Oct 2023 19:20:48 GMT, brunesto wrote:
> The fix prevents the DatePicker from losing focus if the date is not parsable.
FYI a company Agreement was sent for the OCA, it is under review.
-
PR Comment: https://git.openjdk.org/jfx/pull/1274#issuecomment-1790662061
On Tue, 31 Oct 2023 19:20:48 GMT, brunesto wrote:
> The fix prevents the DatePicker from losing focus if the date is not parsable.
modules/javafx.controls/src/main/java/javafx/scene/control/DatePicker.java line
157:
> 155:
> 156: /**
> 157: * This is to address https://bugs.openjdk.o
On Tue, 31 Oct 2023 19:20:48 GMT, brunesto wrote:
> The fix prevents the DatePicker from losing focus if the date is not parsable.
I left a few inline comments. I'll leave it to others to formally review it.
I should add that we won't formally review the fix until the OCA status is
recorded (w
On Tue, 31 Oct 2023 19:20:48 GMT, brunesto wrote:
> The fix prevents the DatePicker from losing focus if the date is not parsable.
Just preliminary comments, will do a full review once OCA process is completed.
tests/system/src/test/java/test/robot/javafx/scene/DatePickerOnFocusLostTest.java
l
25 matches
Mail list logo
