On Tue, 31 Oct 2023 19:20:48 GMT, brunesto <d...@openjdk.org> wrote: > The fix prevents the DatePicker from losing focus if the date is not parsable.
I left a few inline comments. I'll leave it to others to formally review it. I should add that we won't formally review the fix until the OCA status is recorded (which Andy mentioned above). modules/javafx.controls/src/main/java/javafx/scene/control/DatePicker.java line 159: > 157: * This is to address https://bugs.openjdk.org/browse/JDK-8303478 > 158: */ > 159: private void commitValueOnFocusLost(){ Minor: add a space before the `{` ------------- PR Review: https://git.openjdk.org/jfx/pull/1274#pullrequestreview-1710061973 PR Comment: https://git.openjdk.org/jfx/pull/1274#issuecomment-1790619083 PR Review Comment: https://git.openjdk.org/jfx/pull/1274#discussion_r1379990815
