On Fri, 10 Nov 2023 16:51:22 GMT, brunesto <d...@openjdk.org> wrote:
>> The fix prevents the DatePicker from losing focus if the date is not
>> parsable.
>
> brunesto has updated the pull request incrementally with one additional
> commit since the last revision:
>
> minor
thank you for adding a test case!
the testing looks good. have a couple of minor suggestions.
modules/javafx.controls/src/main/java/javafx/scene/control/DatePicker.java line
151:
> 149: focusedProperty().addListener(o -> {
> 150: if (!isFocused()) {
> 151: commitValueOnFocusLost();
minor: I don't know if it's worth creating a new method here - try .. catch can
simply be moved here.
modules/javafx.controls/src/main/java/javafx/scene/control/DatePicker.java line
164:
> 162: }
> 163:
> 164:
minor: extra newline
-------------
PR Review: https://git.openjdk.org/jfx/pull/1274#pullrequestreview-1730840393
PR Review Comment: https://git.openjdk.org/jfx/pull/1274#discussion_r1393322392
PR Review Comment: https://git.openjdk.org/jfx/pull/1274#discussion_r1393318322
