On Wed, 14 Aug 2024 02:21:30 GMT, Kevin Rushforth wrote:
>> 1. Added logic to look in the standard locations for Visual Studio 2022,
>> with a fallback to 2019 and then 2017 if 2022 is not found. It will look in
>> the following locations:
>>
>> C:("Program Files"|"Program Files (x86)")\Micros
On Wed, 14 Aug 2024 02:21:30 GMT, Kevin Rushforth wrote:
>> 1. Added logic to look in the standard locations for Visual Studio 2022,
>> with a fallback to 2019 and then 2017 if 2022 is not found. It will look in
>> the following locations:
>>
>> C:("Program Files"|"Program Files (x86)")\Micros
On Wed, 14 Aug 2024 02:21:30 GMT, Kevin Rushforth wrote:
>> 1. Added logic to look in the standard locations for Visual Studio 2022,
>> with a fallback to 2019 and then 2017 if 2022 is not found. It will look in
>> the following locations:
>>
>> C:("Program Files"|"Program Files (x86)")\Micros
> 1. Added logic to look in the standard locations for Visual Studio 2022, with
> a fallback to 2019 and then 2017 if 2022 is not found. It will look in the
> following locations:
>
> C:("Program Files"|"Program Files (x86)")\Microsoft Visual
> Studio(2022|2019|2017)\
> (Enterprise|Profess
On Tue, 13 Aug 2024 06:27:51 GMT, Lukasz Kostyra wrote:
>> Thanks, that would be helpful. Let me know what you find.
>
> I checked on a Win 11 system where Build Tools 2022 are installed in default
> directory (no other Visual Studio edition) and the build failed with "Cannot
> locate Visual St
On Mon, 12 Aug 2024 21:31:49 GMT, Kevin Rushforth wrote:
>> 1. Added logic to look in the standard locations for Visual Studio 2022,
>> with a fallback to 2019 and then 2017 if 2022 is not found. It will look in
>> the following locations:
>>
>> C:("Program Files"|"Program Files (x86)")\Micros
On Mon, 12 Aug 2024 21:31:49 GMT, Kevin Rushforth wrote:
>> 1. Added logic to look in the standard locations for Visual Studio 2022,
>> with a fallback to 2019 and then 2017 if 2022 is not found. It will look in
>> the following locations:
>>
>> C:("Program Files"|"Program Files (x86)")\Micros
On Mon, 12 Aug 2024 18:04:47 GMT, Kevin Rushforth wrote:
>> buildSrc/genVSproperties.bat line 52:
>>
>>> 50: for %%a in (2022, 2019, 2017) do (
>>> 51: set year=%%a
>>> 52: for %%b in (Enterprise, Professional, Community) do (
>>
>> Quick two cents from me on this part - Mic
On Mon, 12 Aug 2024 21:31:49 GMT, Kevin Rushforth wrote:
>> 1. Added logic to look in the standard locations for Visual Studio 2022,
>> with a fallback to 2019 and then 2017 if 2022 is not found. It will look in
>> the following locations:
>>
>> C:("Program Files"|"Program Files (x86)")\Micros
On Mon, 12 Aug 2024 20:31:37 GMT, Phil Race wrote:
>> Kevin Rushforth has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Revert "Add debug prints"
>>
>> This reverts commit 3ea8ee58867d21e5c0aeb6a22170cdc28dd7a486.
>
> buildSrc/genVSpr
On Mon, 12 Aug 2024 20:41:13 GMT, Phil Race wrote:
>> Kevin Rushforth has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review comments
>
> buildSrc/win.gradle line 93:
>
>> 91: defineProperty("WINDOWS_VS_LIB", properties,
>> "$W
> 1. Added logic to look in the standard locations for Visual Studio 2022, with
> a fallback to 2019 and then 2017 if 2022 is not found. It will look in the
> following locations:
>
> C:("Program Files"|"Program Files (x86)")\Microsoft Visual
> Studio(2022|2019|2017)\
> (Enterprise|Profess
On Mon, 12 Aug 2024 15:37:10 GMT, Kevin Rushforth wrote:
>> 1. Added logic to look in the standard locations for Visual Studio 2022,
>> with a fallback to 2019 and then 2017 if 2022 is not found. It will look in
>> the following locations:
>>
>> C:("Program Files"|"Program Files (x86)")\Micros
On Mon, 12 Aug 2024 19:48:11 GMT, Kevin Rushforth wrote:
> > The wiki page for building OpenJFX will also need an update.
>
> Yes. I plan to (I meant to list that in the Description, but forgot to add
> it). Thanks for the reminder.
Yes indeed, Kevin and I discussed that at some length. What i
On Mon, 12 Aug 2024 19:18:40 GMT, Nir Lisker wrote:
> The wiki page for building OpenJFX will also need an update.
Yes. I plan to (I meant to list that in the Description, but forgot to add it).
Thanks for the reminder.
-
PR Comment: https://git.openjdk.org/jfx/pull/1534#issuecomm
On Mon, 12 Aug 2024 15:37:10 GMT, Kevin Rushforth wrote:
>> 1. Added logic to look in the standard locations for Visual Studio 2022,
>> with a fallback to 2019 and then 2017 if 2022 is not found. It will look in
>> the following locations:
>>
>> C:("Program Files"|"Program Files (x86)")\Micros
On Mon, 12 Aug 2024 17:32:10 GMT, Lukasz Kostyra wrote:
>> Kevin Rushforth has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Revert "Add debug prints"
>>
>> This reverts commit 3ea8ee58867d21e5c0aeb6a22170cdc28dd7a486.
>
> buildSrc/ge
On Mon, 12 Aug 2024 15:37:10 GMT, Kevin Rushforth wrote:
>> 1. Added logic to look in the standard locations for Visual Studio 2022,
>> with a fallback to 2019 and then 2017 if 2022 is not found. It will look in
>> the following locations:
>>
>> C:("Program Files"|"Program Files (x86)")\Micros
On Mon, 12 Aug 2024 15:37:10 GMT, Kevin Rushforth wrote:
>> 1. Added logic to look in the standard locations for Visual Studio 2022,
>> with a fallback to 2019 and then 2017 if 2022 is not found. It will look in
>> the following locations:
>>
>> C:("Program Files"|"Program Files (x86)")\Micros
> 1. Added logic to look in the standard locations for Visual Studio 2022, with
> a fallback to 2019 and then 2017 if 2022 is not found. It will look in the
> following locations:
>
> C:("Program Files"|"Program Files (x86)")\Microsoft Visual
> Studio(2022|2019|2017)\
> (Enterprise|Profess
On Mon, 12 Aug 2024 14:21:14 GMT, Kevin Rushforth wrote:
> 1. Added logic to look in the standard locations for Visual Studio 2022, with
> a fallback to 2019 and then 2017 if 2022 is not found. It will look in the
> following locations:
>
> C:("Program Files"|"Program Files (x86)")\Microsoft V
21 matches
Mail list logo
