On Mon, 12 Aug 2024 20:31:37 GMT, Phil Race <p...@openjdk.org> wrote:
>> Kevin Rushforth has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Revert "Add debug prints"
>>
>> This reverts commit 3ea8ee58867d21e5c0aeb6a22170cdc28dd7a486.
>
> buildSrc/genVSproperties.bat line 27:
>
>> 25:
>> 26: REM Windows bat file that runs vcvars64.bat for Visual Studio
>> 27: REM and echos out a property file with the values of the environment
>
> nit : I think it is usually spelt echoes.
This was preexisting, but since I touched this line (to remove white space),
I'll fix it.
> buildSrc/genVSproperties.bat line 55:
>
>> 53: set edition=%%b
>> 54: for %%c in ("Program Files", "Program Files (x86)") do (
>> 55: set ProgramFiles=%%~c
>
> What does the ~ do here ?
It strips the quotes.
> buildSrc/win.gradle line 113:
>
>> 111: IS_DEBUG_NATIVE ? ["/MDd", "/Od", "/Zi", "/DDEBUG"] : ["/O2",
>> "/MD", "/DNDEBUG"]
>> 112:
>> 113: // Serialize access to PDB file for debug builds if on VS2013 or later
>
> The "if on VS2013 or later" part of the comment is obsolete.
I'll remove it.
> buildSrc/win.gradle line 141:
>
>> 139:
>> 140: // Remove C++ static linking if not on VS2010
>> 141: ccFlags -= ["/D_STATIC_CPPLIB", "/D_DISABLE_DEPRECATE_STATIC_CPPLIB"]
>
> The "if not on VS2010" part of the comment is obsolete.
I'll remove it.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1534#discussion_r1714379348
PR Review Comment: https://git.openjdk.org/jfx/pull/1534#discussion_r1714379591
PR Review Comment: https://git.openjdk.org/jfx/pull/1534#discussion_r1714384323
PR Review Comment: https://git.openjdk.org/jfx/pull/1534#discussion_r1714384853
