On Mon, 12 Aug 2024 17:32:10 GMT, Lukasz Kostyra <lkost...@openjdk.org> wrote:
>> Kevin Rushforth has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Revert "Add debug prints" >> >> This reverts commit 3ea8ee58867d21e5c0aeb6a22170cdc28dd7a486. > > buildSrc/genVSproperties.bat line 52: > >> 50: for %%a in (2022, 2019, 2017) do ( >> 51: set year=%%a >> 52: for %%b in (Enterprise, Professional, Community) do ( > > Quick two cents from me on this part - Microsoft also offers a free CLI-only > version of Visual Studio called "Build Tools for Visual Studio" - > https://visualstudio.microsoft.com/downloads/#build-tools-for-visual-studio-2022 > > Those install in a separate "BuildTools" directory (so ex. `C:\Program > Files\Microsoft Visual Studio\2022\BuildTools...`). Internally the directory > structure is the same and all the scripts we need are also there, so it seems > like this should work. I think we could also add BuildTools as an option > here? I can check on my machine if it builds as part of this review. Thanks, that would be helpful. Let me know what you find. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1534#discussion_r1714186379
