Re: RFR: 8354986: Update to Visual Studio 2022 version 17.13.2 on Windows [v2]

2025-05-28 Thread Ambarish Rapte
On Thu, 22 May 2025 16:53:07 GMT, Kevin Rushforth wrote: >> This PR updates the compiler on Windows to Visual Studio 2022 17.13.2 (from >> 17.6.5) to match JDK 25. >> >> I ran a full headless and headful test run, including building media and >> WebKit. All tests pass. >> >> NOTE: There is a

Re: RFR: 8354986: Update to Visual Studio 2022 version 17.13.2 on Windows [v2]

2025-05-22 Thread Alexander Matveev
On Thu, 22 May 2025 16:53:07 GMT, Kevin Rushforth wrote: >> This PR updates the compiler on Windows to Visual Studio 2022 17.13.2 (from >> 17.6.5) to match JDK 25. >> >> I ran a full headless and headful test run, including building media and >> WebKit. All tests pass. >> >> NOTE: There is a

Re: RFR: 8354986: Update to Visual Studio 2022 version 17.13.2 on Windows [v2]

2025-05-22 Thread Joeri Sykora
On Thu, 22 May 2025 16:53:07 GMT, Kevin Rushforth wrote: >> This PR updates the compiler on Windows to Visual Studio 2022 17.13.2 (from >> 17.6.5) to match JDK 25. >> >> I ran a full headless and headful test run, including building media and >> WebKit. All tests pass. >> >> NOTE: There is a

Re: RFR: 8354986: Update to Visual Studio 2022 version 17.13.2 on Windows

2025-05-22 Thread Kevin Rushforth
On Wed, 14 May 2025 23:20:42 GMT, Kevin Rushforth wrote: > This PR updates the compiler on Windows to Visual Studio 2022 17.13.2 (from > 17.6.5) to match JDK 25. > > I ran a full headless and headful test run, including building media and > WebKit. All tests pass. > > NOTE: There is a compati

Re: RFR: 8354986: Update to Visual Studio 2022 version 17.13.2 on Windows [v2]

2025-05-22 Thread Kevin Rushforth
> This PR updates the compiler on Windows to Visual Studio 2022 17.13.2 (from > 17.6.5) to match JDK 25. > > I ran a full headless and headful test run, including building media and > WebKit. All tests pass. > > NOTE: There is a compatibility issue, introduced in VS 2022 17.10, that is > seen

Re: RFR: 8354986: Update to Visual Studio 2022 version 17.13.2 on Windows

2025-05-22 Thread Joeri Sykora
On Wed, 14 May 2025 23:20:42 GMT, Kevin Rushforth wrote: > This PR updates the compiler on Windows to Visual Studio 2022 17.13.2 (from > 17.6.5) to match JDK 25. > > I ran a full headless and headful test run, including building media and > WebKit. All tests pass. > > NOTE: There is a compati

Re: RFR: 8354986: Update to Visual Studio 2022 version 17.13.2 on Windows

2025-05-20 Thread Ambarish Rapte
On Wed, 14 May 2025 23:20:42 GMT, Kevin Rushforth wrote: > This PR updates the compiler on Windows to Visual Studio 2022 17.13.2 (from > 17.6.5) to match JDK 25. > > I ran a full headless and headful test run, including building media and > WebKit. All tests pass. > > NOTE: There is a compati

Re: RFR: 8354986: Update to Visual Studio 2022 version 17.13.2 on Windows

2025-05-20 Thread Nir Lisker
The instructions could be outdated. They need another pass in any case. On Tue, May 20, 2025, 09:03 Peter Hull wrote: > On Mon, 19 May 2025 at 17:14, Kevin Rushforth wrote: > > > > This PR updates the compiler on Windows to Visual Studio 2022 17.13.2 > (from 17.6.5) to match JDK 25. > > Related

Re: RFR: 8354986: Update to Visual Studio 2022 version 17.13.2 on Windows

2025-05-20 Thread Peter Hull
On Mon, 19 May 2025 at 17:14, Kevin Rushforth wrote: > > This PR updates the compiler on Windows to Visual Studio 2022 17.13.2 (from > 17.6.5) to match JDK 25. Related to this, on the wiki it says that Cygwin is needed (https://wiki.openjdk.org/display/OpenJFX/Building+OpenJFX#BuildingOpenJFX-Wi

Re: RFR: 8354986: Update to Visual Studio 2022 version 17.13.2 on Windows

2025-05-19 Thread Alexander Matveev
On Wed, 14 May 2025 23:20:42 GMT, Kevin Rushforth wrote: > This PR updates the compiler on Windows to Visual Studio 2022 17.13.2 (from > 17.6.5) to match JDK 25. > > I ran a full headless and headful test run, including building media and > WebKit. All tests pass. > > NOTE: There is a compati

RFR: 8354986: Update to Visual Studio 2022 version 17.13.2 on Windows

2025-05-19 Thread Kevin Rushforth
This PR updates the compiler on Windows to Visual Studio 2022 17.13.2 (from 17.6.5) to match JDK 25. I ran a full headless and headful test run, including building media and WebKit. All tests pass. NOTE: There is a compatibility issue, introduced in VS 2022 17.10, that is seen when compiling w

Re: RFR: 8354986: Update to Visual Studio 2022 version 17.13.2 on Windows

2025-05-19 Thread Kevin Rushforth
On Wed, 14 May 2025 23:20:42 GMT, Kevin Rushforth wrote: > This PR updates the compiler on Windows to Visual Studio 2022 17.13.2 (from > 17.6.5) to match JDK 25. > > I ran a full headless and headful test run, including building media and > WebKit. All tests pass. > > NOTE: There is a compati