> This PR updates the compiler on Windows to Visual Studio 2022 17.13.2 (from > 17.6.5) to match JDK 25. > > I ran a full headless and headful test run, including building media and > WebKit. All tests pass. > > NOTE: There is a compatibility issue, introduced in VS 2022 17.10, that is > seen when compiling with a more recent version of Visual Studio and running > against an older `msvcp140.dll`. A workaround is documented in the [VS 2022 > 17.10 release > notes](https://github.com/microsoft/STL/releases/tag/vs-2022-17.10) and is > implemented by this PR. Without the workaround of compiling with > `_DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR` WebKit crashes in the ICU library when > run on JDK 24 or earlier, since the version of `msvcp140.dll` in JDK 24 is > the one from 17.6.5 (the JDK loads its `msvcp140.dll` first, causing the one > we redistribute to be ignored). With this workaround, we can run both on > older JDKs and on JDK 25.
Kevin Rushforth has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits: - Merge remote-tracking branch 'upstream/master' into 8354986-vs2022-17.13.2 - Merge remote-tracking branch 'upstream/master' into 8354986-vs2022-17.13.2 - Only define '_DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR' for ICU on Windows - Define '_DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR' when compiling web (ICU), graphics, and media - 8354986: Update to Visual Studio 2022 version 17.13.2 on Windows ------------- Changes: https://git.openjdk.org/jfx/pull/1807/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1807&range=01 Stats: 21 lines in 14 files changed: 17 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jfx/pull/1807.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/1807/head:pull/1807 PR: https://git.openjdk.org/jfx/pull/1807
