On Wed, 14 May 2025 23:20:42 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
> This PR updates the compiler on Windows to Visual Studio 2022 17.13.2 (from > 17.6.5) to match JDK 25. > > I ran a full headless and headful test run, including building media and > WebKit. All tests pass. > > NOTE: There is a compatibility issue, introduced in VS 2022 17.10, that is > seen when compiling with a more recent version of Visual Studio and running > against an older `msvcp140.dll`. A workaround is documented in the [VS 2022 > 17.10 release > notes](https://github.com/microsoft/STL/releases/tag/vs-2022-17.10) and is > implemented by this PR. Without the workaround of compiling with > `_DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR` WebKit crashes in the ICU library when > run on JDK 24 or earlier, since the version of `msvcp140.dll` in JDK 24 is > the one from 17.6.5 (the JDK loads its `msvcp140.dll` first, causing the one > we redistribute to be ignored). With this workaround, we can run both on > older JDKs and on JDK 25. Media changes looks good. ------------- Marked as reviewed by almatvee (Reviewer). PR Review: https://git.openjdk.org/jfx/pull/1807#pullrequestreview-2851902349
