On Sat, 15 Mar 2025 03:41:29 GMT, Michael Strauß wrote:
>> This PR contains a definition of preview features for JavaFX, as well as a
>> helper class to verify that an application has opted into preview features.
>
> Michael Strauß has updated the pull request incrementally with one additional
On Sat, 15 Mar 2025 03:41:29 GMT, Michael Strauß wrote:
>> This PR contains a definition of preview features for JavaFX, as well as a
>> helper class to verify that an application has opted into preview features.
>
> Michael Strauß has updated the pull request incrementally with one additional
> This PR contains a definition of preview features for JavaFX, as well as a
> helper class to verify that an application has opted into preview features.
Michael Strauß has updated the pull request incrementally with one additional
commit since the last revision:
banner -> warning
-
On Fri, 14 Mar 2025 16:21:22 GMT, Michael Strauß wrote:
>> This PR contains a definition of preview features for JavaFX, as well as a
>> helper class to verify that an application has opted into preview features.
>
> Michael Strauß has updated the pull request incrementally with one additional
On Fri, 14 Mar 2025 16:21:22 GMT, Michael Strauß wrote:
>> This PR contains a definition of preview features for JavaFX, as well as a
>> helper class to verify that an application has opted into preview features.
>
> Michael Strauß has updated the pull request incrementally with one additional
> This PR contains a definition of preview features for JavaFX, as well as a
> helper class to verify that an application has opted into preview features.
Michael Strauß has updated the pull request incrementally with one additional
commit since the last revision:
rename system property
On Thu, 13 Mar 2025 03:29:28 GMT, Michael Strauß wrote:
>> This PR contains a definition of preview features for JavaFX, as well as a
>> helper class to verify that an application has opted into preview features.
>
> Michael Strauß has updated the pull request incrementally with one additional
On Thu, 13 Mar 2025 03:29:28 GMT, Michael Strauß wrote:
>> This PR contains a definition of preview features for JavaFX, as well as a
>> helper class to verify that an application has opted into preview features.
>
> Michael Strauß has updated the pull request incrementally with one additional
On Thu, 13 Mar 2025 03:29:28 GMT, Michael Strauß wrote:
>> This PR contains a definition of preview features for JavaFX, as well as a
>> helper class to verify that an application has opted into preview features.
>
> Michael Strauß has updated the pull request incrementally with one additional
On Thu, 13 Mar 2025 03:29:28 GMT, Michael Strauß wrote:
>> This PR contains a definition of preview features for JavaFX, as well as a
>> helper class to verify that an application has opted into preview features.
>
> Michael Strauß has updated the pull request incrementally with one additional
On Wed, 12 Mar 2025 14:24:08 GMT, Andy Goryachev wrote:
> > Should we specify that the `@Deprecated` annotation on preview features be
> > marked as `forRemoval=true`
>
> wouldn't this send a wrong message? could we invent a new annotation
> `@Preview` ?
We could, but then we'd lose the integ
> This PR contains a definition of preview features for JavaFX, as well as a
> helper class to verify that an application has opted into preview features.
Michael Strauß has updated the pull request incrementally with one additional
commit since the last revision:
warning can be suppressed
-
On Wed, 12 Mar 2025 13:31:11 GMT, Kevin Rushforth wrote:
> Should we specify that the `@Deprecated` annotation on preview features be
> marked as `forRemoval=true`
wouldn't this send a wrong message?
could we invent a new annotation `@Preview` ?
-
PR Comment: https://git.openjdk.o
On Wed, 12 Mar 2025 14:24:08 GMT, Andy Goryachev wrote:
> > Should we specify that the `@Deprecated` annotation on preview features be
> > marked as `forRemoval=true`
>
> wouldn't this send a wrong message?
Yes, that's the main counter-argument. Unlike incubator modules, which
necessarily nee
On Fri, 7 Feb 2025 09:16:54 GMT, Michael Strauß wrote:
>> This PR contains a definition of preview features for JavaFX, as well as a
>> helper class to verify that an application has opted into preview features.
>
> Michael Strauß has updated the pull request incrementally with four
> additiona
On Fri, 7 Feb 2025 09:16:54 GMT, Michael Strauß wrote:
>> This PR contains a definition of preview features for JavaFX, as well as a
>> helper class to verify that an application has opted into preview features.
>
> Michael Strauß has updated the pull request incrementally with four
> additiona
On Thu, 13 Feb 2025 21:53:25 GMT, Michael Strauß wrote:
>> Yeah, that's what I came to realize as well. So our property should remain
>> boolean.
>>
>> The only other thing I could think of is for us to provide a new utility
>> method (in some class in javafx.base) that an application must cal
On Thu, 13 Feb 2025 18:41:21 GMT, Kevin Rushforth wrote:
>> This is only done at compilation time, not at runtime. JEP 12 elaborates on
>> this:
>>
>>> --enable-preview itself does not take a version number because it would be
>>> easy to misinterpret. For example, on JDK 18, the (hypothetical
On Fri, 7 Feb 2025 15:07:26 GMT, Michael Strauß wrote:
>> modules/javafx.base/src/main/java/com/sun/javafx/PreviewFeature.java line 52:
>>
>>> 50: private static final String SUPPRESS_WARNING_PROPERTY =
>>> "javafx.suppressPreviewBanner";
>>> 51:
>>> 52: private static final boolean en
On Fri, 7 Feb 2025 09:16:54 GMT, Michael Strauß wrote:
>> This PR contains a definition of preview features for JavaFX, as well as a
>> helper class to verify that an application has opted into preview features.
>
> Michael Strauß has updated the pull request incrementally with four
> additiona
On Tue, 4 Feb 2025 19:47:34 GMT, Kevin Rushforth wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> move enum field to top
>
> modules/javafx.base/src/main/java/com/sun/javafx/PreviewFeature.java line 52:
>
>> 50:
> This PR contains a definition of preview features for JavaFX, as well as a
> helper class to verify that an application has opted into preview features.
Michael Strauß has updated the pull request incrementally with four additional
commits since the last revision:
- javadoc
- remove support
On Tue, 4 Feb 2025 19:39:07 GMT, Michael Strauß wrote:
>> This PR contains a definition of preview features for JavaFX, as well as a
>> helper class to verify that an application has opted into preview features.
>
> Michael Strauß has updated the pull request incrementally with one additional
>
On Tue, 4 Feb 2025 19:47:08 GMT, Kevin Rushforth wrote:
>> We could also do that, but the problem is that the contents of JEP 12 only
>> map to JavaFX in some parts, but not in others. So we would need to include
>> weasel language like "where applicable" (which always leaves a bit of room
>>
On Tue, 4 Feb 2025 19:25:40 GMT, Michael Strauß wrote:
>> PREVIEW-FEATURES.md line 1:
>>
>>> 1: # Preview features
>>
>> is this a good location of this document?
>> should it be in /doc-files somewhere?
>
> I think it's not a documentation of JavaFX itself, but more like a
> meta-documentatio
On Tue, 4 Feb 2025 19:20:47 GMT, Michael Strauß wrote:
>> The space of people who know what a JDK preview is is larger than that of
>> JFX people. I think we might want to point to JEP12 and explicitly explain
>> the difference, that's all.
>
> We could also do that, but the problem is that th
On Tue, 4 Feb 2025 19:34:29 GMT, Michael Strauß wrote:
>> modules/javafx.base/src/main/java/com/sun/javafx/PreviewFeature.java line 37:
>>
>>> 35: * has opted into preview features.
>>> 36: */
>>> 37: public enum PreviewFeature {
>>
>> Why enum?
>> Maybe use a regular class with a public cons
On Tue, 4 Feb 2025 18:18:31 GMT, Andy Goryachev wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> move enum field to top
>
> modules/javafx.base/src/main/java/com/sun/javafx/PreviewFeature.java line 37:
>
>> 35:
> This PR contains a definition of preview features for JavaFX, as well as a
> helper class to verify that an application has opted into preview features.
Michael Strauß has updated the pull request incrementally with one additional
commit since the last revision:
move enum field to top
On Tue, 4 Feb 2025 18:44:57 GMT, Andy Goryachev wrote:
>> This definition is, as you point out, largely lifted from JEP 12. Aside from
>> wording changes, here are some key differences:
>>
>> * JEP 12 assumes that a feature should be finished within two releases. I
>> think for JavaFX, being j
On Tue, 4 Feb 2025 18:13:19 GMT, Andy Goryachev wrote:
>> This PR contains a definition of preview features for JavaFX, as well as a
>> helper class to verify that an application has opted into preview features.
>
> PREVIEW-FEATURES.md line 1:
>
>> 1: # Preview features
>
> is this a good loca
On Tue, 4 Feb 2025 18:41:13 GMT, Michael Strauß wrote:
>> PREVIEW-FEATURES.md line 32:
>>
>>> 30:application has not opted into the use of preview features. All
>>> preview features have equal status
>>> 31:in any given JavaFX release and can not be enabled individually.
>>> 32:
>>
>>
On Tue, 4 Feb 2025 18:16:22 GMT, Andy Goryachev wrote:
>> This PR contains a definition of preview features for JavaFX, as well as a
>> helper class to verify that an application has opted into preview features.
>
> PREVIEW-FEATURES.md line 32:
>
>> 30:application has not opted into the use
On Wed, 7 Feb 2024 20:05:01 GMT, Michael Strauß wrote:
> This PR contains a definition of preview features for JavaFX, as well as a
> helper class to verify that an application has opted into preview features.
PREVIEW-FEATURES.md line 1:
> 1: # Preview features
is this a good location of this
This PR contains a definition of preview features for JavaFX, as well as a
helper class to verify that an application has opted into preview features.
-
Commit messages:
- Use enum constants instead of feature names
- Merge branch 'master' into feature/previewfeature
- Preview fea
35 matches
Mail list logo
