On Fri, 7 Feb 2025 09:16:54 GMT, Michael Strauß <mstra...@openjdk.org> wrote:

>> This PR contains a definition of preview features for JavaFX, as well as a 
>> helper class to verify that an application has opted into preview features.
>
> Michael Strauß has updated the pull request incrementally with four 
> additional commits since the last revision:
> 
>  - javadoc
>  - remove supporting documentation
>  - warning can't be suppressed
>  - initialize PreviewFeature early

The changes look good. I thought of one more option we might consider to check 
that the version of the preview API that the app compiled against matches the 
runtime version of the JavaFX runtime. Whether it is worth doing is something 
we can discuss.

-------------

PR Review: https://git.openjdk.org/jfx/pull/1359#pullrequestreview-2615933747

Reply via email to