On Sat, 21 Sep 2024 00:54:05 GMT, Jay Bhaskar wrote:
>> Successfully converted Non-parametrized base tests to JUnit 5
>
> Jay Bhaskar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> restore and convert mistakenly removed tests
thank you fo
On Sat, 21 Sep 2024 00:54:05 GMT, Jay Bhaskar wrote:
>> Successfully converted Non-parametrized base tests to JUnit 5
>
> Jay Bhaskar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> restore and convert mistakenly removed tests
Marked as re
On Fri, 20 Sep 2024 20:08:40 GMT, Andy Goryachev wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> one missing , formating
>
> looked at each line, double checking:
> - before->beforeEach etc.
> - exception types in a
> Successfully converted Non-parametrized base tests to JUnit 5
Jay Bhaskar has updated the pull request incrementally with one additional
commit since the last revision:
restore and convert mistakenly removed tests
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1576/files
On Fri, 20 Sep 2024 21:18:39 GMT, Kevin Rushforth wrote:
> JavaBeanPropertyBuilderHelperTest
I left those because these files have may assertThrows and having try catch ,
that required some extra care to convert, we will add then in parameterized
test PR
-
PR Comment: https://git
On Fri, 20 Sep 2024 02:36:34 GMT, Jay Bhaskar wrote:
>> Successfully converted Non-parametrized base tests to JUnit 5
>
> Jay Bhaskar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> one missing , formating
I got curious, so I looked for al
On Fri, 20 Sep 2024 20:08:40 GMT, Andy Goryachev wrote:
> Could not run the junit4 query because there are still parameterized tests
> left.
What I did to verify this was to do a grep just on those files that changed:
git diff --name-only master... | xargs grep -n -e "org.junit" -e
"junit.fr
On Fri, 20 Sep 2024 19:39:38 GMT, Andy Goryachev wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> one missing , formating
>
> modules/javafx.base/src/test/java/test/com/sun/javafx/binding/ErrorLoggingUtiltity.java
>
On Fri, 20 Sep 2024 02:36:34 GMT, Jay Bhaskar wrote:
>> Successfully converted Non-parametrized base tests to JUnit 5
>
> Jay Bhaskar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> one missing , formating
looked at each line, double check
On Fri, 20 Sep 2024 02:36:34 GMT, Jay Bhaskar wrote:
>> Successfully converted Non-parametrized base tests to JUnit 5
>
> Jay Bhaskar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> one missing , formating
One remaining problem with mistak
On Thu, 19 Sep 2024 21:06:40 GMT, Kevin Rushforth wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> one missing , formating
>
> modules/javafx.base/src/test/java/test/com/sun/javafx/binding/ContentBindingSetTest.java
> Successfully converted Non-parametrized base tests to JUnit 5
Jay Bhaskar has updated the pull request incrementally with one additional
commit since the last revision:
one missing , formating
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1576/files
- new: https://git.
On Thu, 19 Sep 2024 21:04:06 GMT, Kevin Rushforth wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Modification as per review
>
> modules/javafx.base/src/test/java/test/com/sun/javafx/binding/ContentBindingMapTest.ja
> Successfully converted Non-parametrized base tests to JUnit 5
Jay Bhaskar has updated the pull request incrementally with one additional
commit since the last revision:
Modification as per review
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1576/files
- new: https://g
On Thu, 19 Sep 2024 16:27:26 GMT, Jay Bhaskar wrote:
>> Successfully converted Non-parametrized base tests to JUnit 5
>
> Jay Bhaskar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert "8339515: [TestBug] Convert web tests to JUnit 5"
>
> Successfully converted Non-parametrized base tests to JUnit 5
Jay Bhaskar has updated the pull request incrementally with one additional
commit since the last revision:
Revert "8339515: [TestBug] Convert web tests to JUnit 5"
This reverts commit 86f73271142049a2c0162d987aee6bd0fcb2f82a.
Successfully converted Non-parametrized base tests to JUnit 5
-
Commit messages:
- 8339511: [TestBug] Convert Non parametrized base tests to JUnit 5
- 8339515: [TestBug] Convert web tests to JUnit 5
Changes: https://git.openjdk.org/jfx/pull/1576/files
Webrev: https://webrevs.open
17 matches
Mail list logo
