On Fri, 20 Sep 2024 02:36:34 GMT, Jay Bhaskar <jbhas...@openjdk.org> wrote:
>> Successfully converted Non-parametrized base tests to JUnit 5 > > Jay Bhaskar has updated the pull request incrementally with one additional > commit since the last revision: > > one missing , formating I got curious, so I looked for all base test files with junit4 imports, and excluded the ones that have parameterized tests. I see that there are a few: modules/javafx.base/src/test/java/test/com/sun/javafx/property/adapter/JavaBeanPropertyBuilderHelperTest.java modules/javafx.base/src/test/java/test/javafx/beans/property/adapter/JavaBeanPropertyTestBase.java modules/javafx.base/src/test/java/test/javafx/beans/value/ObservableValueSubscriptionsTest.java modules/javafx.base/src/test/java/test/javafx/binding/When_Boolean_Test.java modules/javafx.base/src/test/java/test/javafx/binding/When_Double_Test.java modules/javafx.base/src/test/java/test/javafx/binding/When_Float_Test.java modules/javafx.base/src/test/java/test/javafx/binding/When_Integer_Test.java modules/javafx.base/src/test/java/test/javafx/binding/When_Long_Test.java modules/javafx.base/src/test/java/test/javafx/binding/When_Object_Test.java modules/javafx.base/src/test/java/test/javafx/binding/When_String_Test.java modules/javafx.base/src/test/java/test/javafx/util/converter/CurrencyStringConverterTest.java modules/javafx.base/src/test/java/test/javafx/util/converter/NumberStringConverterTest.java So they can either be added to this PR (if there is nothing else that makes them tricky to convert) or lumped in with the parameterized tests and done in the follow-on bug. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1576#issuecomment-2364631292
