On Fri, 20 Sep 2024 20:08:40 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional >> commit since the last revision: >> >> one missing , formating > > looked at each line, double checking: > - before->beforeEach etc. > - exception types in assertThrows > > Could not run the junit4 query because there are still parameterized tests > left. > > left a few comments, plus some tests need to be brought back. > otherwise looks good. Looks good now. Please wait to see if @andy-goryachev-oracle has any more comments. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1576#issuecomment-2365215090
