Re: RFR: 8339335: set number of parallel jobs when building webkit [v2]

2024-09-04 Thread Kevin Rushforth
On Tue, 3 Sep 2024 19:56:48 GMT, Johan Vos wrote: >> When building webkit, the perl script in >> `modules/javafx.web/src/main/native/Tools/Scripts/build-webkit` will check >> for a `-j` argument in `$makeArgs`. If that doesn't exist, it will default >> to `numberOfCPUs()`. >> This PR passes th

Re: RFR: 8339335: set number of parallel jobs when building webkit [v2]

2024-09-03 Thread Andy Goryachev
On Tue, 3 Sep 2024 19:56:48 GMT, Johan Vos wrote: >> When building webkit, the perl script in >> `modules/javafx.web/src/main/native/Tools/Scripts/build-webkit` will check >> for a `-j` argument in `$makeArgs`. If that doesn't exist, it will default >> to `numberOfCPUs()`. >> This PR passes th

Re: RFR: 8339335: set number of parallel jobs when building webkit [v2]

2024-09-03 Thread Kevin Rushforth
On Tue, 3 Sep 2024 19:56:48 GMT, Johan Vos wrote: >> When building webkit, the perl script in >> `modules/javafx.web/src/main/native/Tools/Scripts/build-webkit` will check >> for a `-j` argument in `$makeArgs`. If that doesn't exist, it will default >> to `numberOfCPUs()`. >> This PR passes th

Re: RFR: 8339335: set number of parallel jobs when building webkit [v2]

2024-09-03 Thread Andy Goryachev
On Tue, 3 Sep 2024 19:56:48 GMT, Johan Vos wrote: >> When building webkit, the perl script in >> `modules/javafx.web/src/main/native/Tools/Scripts/build-webkit` will check >> for a `-j` argument in `$makeArgs`. If that doesn't exist, it will default >> to `numberOfCPUs()`. >> This PR passes th

Re: RFR: 8339335: set number of parallel jobs when building webkit [v2]

2024-09-03 Thread Kevin Rushforth
On Tue, 3 Sep 2024 19:56:48 GMT, Johan Vos wrote: >> When building webkit, the perl script in >> `modules/javafx.web/src/main/native/Tools/Scripts/build-webkit` will check >> for a `-j` argument in `$makeArgs`. If that doesn't exist, it will default >> to `numberOfCPUs()`. >> This PR passes th

Re: RFR: 8339335: set number of parallel jobs when building webkit [v2]

2024-09-03 Thread Johan Vos
> When building webkit, the perl script in > `modules/javafx.web/src/main/native/Tools/Scripts/build-webkit` will check > for a `-j` argument in `$makeArgs`. If that doesn't exist, it will default to > `numberOfCPUs()`. > This PR passes the `NUM_COMPILE_THREADS` from `build.gradle` to the > `bu

Re: RFR: 8339335: set number of parallel jobs when building webkit

2024-09-03 Thread Kevin Rushforth
On Mon, 2 Sep 2024 07:20:50 GMT, Johan Vos wrote: > When building webkit, the perl script in > `modules/javafx.web/src/main/native/Tools/Scripts/build-webkit` will check > for a `-j` argument in `$makeArgs`. If that doesn't exist, it will default to > `numberOfCPUs()`. > This PR passes the `NU

Re: RFR: 8339335: set number of parallel jobs when building webkit

2024-09-03 Thread Kevin Rushforth
On Mon, 2 Sep 2024 07:20:50 GMT, Johan Vos wrote: > When building webkit, the perl script in > `modules/javafx.web/src/main/native/Tools/Scripts/build-webkit` will check > for a `-j` argument in `$makeArgs`. If that doesn't exist, it will default to > `numberOfCPUs()`. > This PR passes the `NU

Re: RFR: 8339335: set number of parallel jobs when building webkit

2024-09-03 Thread Johan Vos
On Tue, 3 Sep 2024 17:46:17 GMT, Kevin Rushforth wrote: > Btw, I ran another CI build with the `NUM_COMPILE_THREADS=1` workaround for > Mac removed, and the build times are good again. In fact, the x64 build runs > even faster than before -- possibly because WebKit build defaults to a lower >

Re: RFR: 8339335: set number of parallel jobs when building webkit

2024-09-03 Thread Kevin Rushforth
On Tue, 3 Sep 2024 17:35:49 GMT, Johan Vos wrote: > Sounds like a plan. I'll add that to the PR once you confirm testing went as > expected. So far so good. I'll let it run a bit longer, but already I'm over 120 iterations with no failures. - PR Comment: https://git.openjdk.org/j

Re: RFR: 8339335: set number of parallel jobs when building webkit

2024-09-03 Thread Kevin Rushforth
On Mon, 2 Sep 2024 07:20:50 GMT, Johan Vos wrote: > When building webkit, the perl script in > `modules/javafx.web/src/main/native/Tools/Scripts/build-webkit` will check > for a `-j` argument in `$makeArgs`. If that doesn't exist, it will default to > `numberOfCPUs()`. > This PR passes the `NU

Re: RFR: 8339335: set number of parallel jobs when building webkit

2024-09-03 Thread Johan Vos
On Tue, 3 Sep 2024 17:27:15 GMT, Kevin Rushforth wrote: > Presuming that my testing shows no problems, I propose the following: > > 1. I will close [JDK-8089417](https://bugs.openjdk.org/browse/JDK-8089417) as > "Cannot reproduce" > 2. I will file a new bug to remove the workaround that current

Re: RFR: 8339335: set number of parallel jobs when building webkit

2024-09-03 Thread Kevin Rushforth
On Mon, 2 Sep 2024 07:20:50 GMT, Johan Vos wrote: > When building webkit, the perl script in > `modules/javafx.web/src/main/native/Tools/Scripts/build-webkit` will check > for a `-j` argument in `$makeArgs`. If that doesn't exist, it will default to > `numberOfCPUs()`. > This PR passes the `NU

Re: RFR: 8339335: set number of parallel jobs when building webkit

2024-09-03 Thread Kevin Rushforth
On Mon, 2 Sep 2024 07:20:50 GMT, Johan Vos wrote: > When building webkit, the perl script in > `modules/javafx.web/src/main/native/Tools/Scripts/build-webkit` will check > for a `-j` argument in `$makeArgs`. If that doesn't exist, it will default to > `numberOfCPUs()`. > This PR passes the `NU

Re: RFR: 8339335: set number of parallel jobs when building webkit

2024-09-03 Thread Johan Vos
On Mon, 2 Sep 2024 07:20:50 GMT, Johan Vos wrote: > When building webkit, the perl script in > `modules/javafx.web/src/main/native/Tools/Scripts/build-webkit` will check > for a `-j` argument in `$makeArgs`. If that doesn't exist, it will default to > `numberOfCPUs()`. > This PR passes the `NU

Re: RFR: 8339335: set number of parallel jobs when building webkit

2024-09-03 Thread Kevin Rushforth
On Mon, 2 Sep 2024 07:20:50 GMT, Johan Vos wrote: > When building webkit, the perl script in > `modules/javafx.web/src/main/native/Tools/Scripts/build-webkit` will check > for a `-j` argument in `$makeArgs`. If that doesn't exist, it will default to > `numberOfCPUs()`. > This PR passes the `NU

Re: RFR: 8339335: set number of parallel jobs when building webkit

2024-09-03 Thread Johan Vos
On Mon, 2 Sep 2024 07:20:50 GMT, Johan Vos wrote: > When building webkit, the perl script in > `modules/javafx.web/src/main/native/Tools/Scripts/build-webkit` will check > for a `-j` argument in `$makeArgs`. If that doesn't exist, it will default to > `numberOfCPUs()`. > This PR passes the `NU

Re: RFR: 8339335: set number of parallel jobs when building webkit

2024-09-03 Thread Kevin Rushforth
On Mon, 2 Sep 2024 07:20:50 GMT, Johan Vos wrote: > When building webkit, the perl script in > `modules/javafx.web/src/main/native/Tools/Scripts/build-webkit` will check > for a `-j` argument in `$makeArgs`. If that doesn't exist, it will default to > `numberOfCPUs()`. > This PR passes the `NU

RFR: 8339335: set number of parallel jobs when building webkit

2024-09-02 Thread Johan Vos
When building webkit, the perl script in `modules/javafx.web/src/main/native/Tools/Scripts/build-webkit` will check for a `-j` argument in `$makeArgs`. If that doesn't exist, it will default to `numberOfCPUs()`. This PR passes the `NUM_COMPILE_THREADS` from `build.gradle` to the `build-webkit`