On Tue, 3 Sep 2024 19:56:48 GMT, Johan Vos <j...@openjdk.org> wrote:

>> When building webkit, the perl script in 
>> `modules/javafx.web/src/main/native/Tools/Scripts/build-webkit` will check 
>> for a `-j` argument in `$makeArgs`. If that doesn't exist, it will default 
>> to `numberOfCPUs()`.
>> This PR passes the `NUM_COMPILE_THREADS` from `build.gradle` to the 
>> `build-webkit` script. When not setting `NUM_COMPILE_THREADS` explicitly,it 
>> will default to the number of CPU's as well, hence it will have the same 
>> behavior as without this PR.
>> When setting `NUM_COMPILE_THREADS` explicitly, the provided number will be 
>> used by cmake as well now.
>
> Johan Vos has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Remove the special case where native compile jobs are hard set to 1
>   on Mac -- see JDK-8339505

I am using this command to build:


(rm -rf ./build ; gradle -PCOMPILE_MEDIA=true -PCOMPILE_WEBKIT=true all 2>&1) | 
tee ~/`date +"build-%Y-%m%d-%H%M%S"`.log


on macOS 14.6.1 / M1 Pro

looking at the Activity Monitor, I see 1 thread per clang compiler. Is this 
expected, or am I supposed to see more concurrent threads?

![Screenshot 2024-09-03 at 13 25 
55](https://github.com/user-attachments/assets/96085195-d71d-4ff7-9d49-7090efc7a892)

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1554#issuecomment-2327381083

Reply via email to