On Tue, 3 Sep 2024 19:56:48 GMT, Johan Vos <j...@openjdk.org> wrote: >> When building webkit, the perl script in >> `modules/javafx.web/src/main/native/Tools/Scripts/build-webkit` will check >> for a `-j` argument in `$makeArgs`. If that doesn't exist, it will default >> to `numberOfCPUs()`. >> This PR passes the `NUM_COMPILE_THREADS` from `build.gradle` to the >> `build-webkit` script. When not setting `NUM_COMPILE_THREADS` explicitly,it >> will default to the number of CPU's as well, hence it will have the same >> behavior as without this PR. >> When setting `NUM_COMPILE_THREADS` explicitly, the provided number will be >> used by cmake as well now. > > Johan Vos has updated the pull request incrementally with one additional > commit since the last revision: > > Remove the special case where native compile jobs are hard set to 1 > on Mac -- see JDK-8339505
Marked as reviewed by angorya (Reviewer). -PNUM_COMPILE_THREADS=1: BUILD SUCCESSFUL in 1h 9m 44s -PNUM_COMPILE_THREADS=10: BUILD SUCCESSFUL in 17m 4s -PNUM_COMPILE_THREADS=32: BUILD SUCCESSFUL in 19m 49s ------------- PR Review: https://git.openjdk.org/jfx/pull/1554#pullrequestreview-2278644614 PR Comment: https://git.openjdk.org/jfx/pull/1554#issuecomment-2327568361
