On Wed, 5 Mar 2025 17:12:36 GMT, Alexander Zuev wrote:
>> Create implementation for Slider and Stepper accessibility protocols.
>> Fix mapping.
>> Fix performAction parameter type in declaration.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the
On Wed, 5 Mar 2025 17:12:36 GMT, Alexander Zuev wrote:
>> Create implementation for Slider and Stepper accessibility protocols.
>> Fix mapping.
>> Fix performAction parameter type in declaration.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the
On Wed, 5 Mar 2025 17:12:36 GMT, Alexander Zuev wrote:
>> Create implementation for Slider and Stepper accessibility protocols.
>> Fix mapping.
>> Fix performAction parameter type in declaration.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the
On Wed, 5 Mar 2025 16:48:22 GMT, Andy Goryachev wrote:
> so the remaining question is whether it should announce "percent" of the
> slider position or the actual value?
Unfortunately we do not have any control on that. There is no way to tell
VoiceOver if it is percent or the raw value - VO de
> Create implementation for Slider and Stepper accessibility protocols.
> Fix mapping.
> Fix performAction parameter type in declaration.
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Remove duplicate code make accessibilityLabel
On Mon, 3 Mar 2025 16:54:08 GMT, Alexander Zuev wrote:
> Also, for Spinner, it says "Stepper", is this expected?
On macOS the control we call Spinner is called Stepper, there's no Spinner.
>From macOS UI guide: "A stepper is a two-segment control that people use to
>increase or decrease an inc
On Wed, 5 Mar 2025 16:47:06 GMT, Alexander Zuev wrote:
> Spinner is called Stepper
yep, that's what I suspected. thanks!
-
PR Comment: https://git.openjdk.org/jfx/pull/1226#issuecomment-2701509394
On Fri, 28 Feb 2025 11:43:39 GMT, Ambarish Rapte wrote:
>> Alexander Zuev has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 14 commits:
>>
>> - Add accessibilityTitleUIElement function to the base class.
>> - Merge branch 'master'
On Fri, 28 Feb 2025 23:41:18 GMT, Andy Goryachev wrote:
> With Slider, it announces the current value as "percent" (of the working
> envelope?), even though the min/max can be arbitrary. Is this intentional?
>
> Also, for Spinner, it says "Stepper", is this expected?
>
> macOS 15.3.1 M1
I nee
On Wed, 26 Feb 2025 11:30:50 GMT, Alexander Zuev wrote:
>> Create implementation for Slider and Stepper accessibility protocols.
>> Fix mapping.
>> Fix performAction parameter type in declaration.
>
> Alexander Zuev has updated the pull request with a new target base due to a
> merge or a rebase
On Wed, 26 Feb 2025 11:30:50 GMT, Alexander Zuev wrote:
>> Create implementation for Slider and Stepper accessibility protocols.
>> Fix mapping.
>> Fix performAction parameter type in declaration.
>
> Alexander Zuev has updated the pull request with a new target base due to a
> merge or a rebase
On Wed, 26 Feb 2025 11:30:50 GMT, Alexander Zuev wrote:
>> Create implementation for Slider and Stepper accessibility protocols.
>> Fix mapping.
>> Fix performAction parameter type in declaration.
>
> Alexander Zuev has updated the pull request with a new target base due to a
> merge or a rebase
> Create implementation for Slider and Stepper accessibility protocols.
> Fix mapping.
> Fix performAction parameter type in declaration.
Alexander Zuev has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 14 commits:
- Add accessibilityT
On Wed, 15 Nov 2023 22:00:13 GMT, Alexander Zuev wrote:
>> Create implementation for Slider and Stepper accessibility protocols.
>> Fix mapping.
>> Fix performAction parameter type in declaration.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since th
On Wed, 15 Nov 2023 22:00:13 GMT, Alexander Zuev wrote:
>> Create implementation for Slider and Stepper accessibility protocols.
>> Fix mapping.
>> Fix performAction parameter type in declaration.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since th
On Wed, 15 Nov 2023 22:00:13 GMT, Alexander Zuev wrote:
>> Create implementation for Slider and Stepper accessibility protocols.
>> Fix mapping.
>> Fix performAction parameter type in declaration.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since th
On Wed, 30 Aug 2023 14:21:48 GMT, Ambarish Rapte wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add commented out debug statements.
>
> I observed few warnings and behavioral differences.
> - Warnings:
> 1.
> m
On Wed, 15 Nov 2023 22:00:13 GMT, Alexander Zuev wrote:
>> Create implementation for Slider and Stepper accessibility protocols.
>> Fix mapping.
>> Fix performAction parameter type in declaration.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since th
> Create implementation for Slider and Stepper accessibility protocols.
> Fix mapping.
> Fix performAction parameter type in declaration.
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Adding accessibilityMinValue and accessibility
> Create implementation for Slider and Stepper accessibility protocols.
> Fix mapping.
> Fix performAction parameter type in declaration.
Alexander Zuev has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought i
> Create implementation for Slider and Stepper accessibility protocols.
> Fix mapping.
> Fix performAction parameter type in declaration.
Alexander Zuev has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought i
On Wed, 30 Aug 2023 17:50:37 GMT, Alexander Zuev wrote:
>> Create implementation for Slider and Stepper accessibility protocols.
>> Fix mapping.
>> Fix performAction parameter type in declaration.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since th
> Create implementation for Slider and Stepper accessibility protocols.
> Fix mapping.
> Fix performAction parameter type in declaration.
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Fixing warnings during build
-
C
On Tue, 29 Aug 2023 20:14:44 GMT, Alexander Zuev wrote:
>> Create implementation for Slider and Stepper accessibility protocols.
>> Fix mapping.
>> Fix performAction parameter type in declaration.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since th
On Tue, 29 Aug 2023 19:45:32 GMT, Andy Goryachev wrote:
> what I meant is that commented out logging statements should be left in the
> code, so the reviewers can uncomment them and test. like this:
>
> ```
> // System.err.println("it works");
> ```
Did that. I would just appreciate if you or
> Create implementation for Slider and Stepper accessibility protocols.
> Fix mapping.
> Fix performAction parameter type in declaration.
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Add commented out debug statements.
-
On Tue, 29 Aug 2023 15:18:20 GMT, Kevin Rushforth wrote:
> Having said that, it would be helpful for Alex to list the controls that will
> use the new implementation, so reviewers can test it manually.
I will definitely do that in the future. In this case you are right the
controls are Spinner
On Tue, 29 Aug 2023 10:10:54 GMT, Alexander Zuev wrote:
> Create implementation for Slider and Stepper accessibility protocols.
> Fix mapping.
> Fix performAction parameter type in declaration.
what I meant is that commented out logging statements should be left in the
code, so the reviewers ca
On Tue, 29 Aug 2023 15:55:13 GMT, Andy Goryachev wrote:
> perhaps the logging statements should be added (commented out) as a part of
> this PR.
I can do that - i usually refrained from doing so because code would look not
very clean but basically the only way to tell that it goes trough the n
On Tue, 29 Aug 2023 10:10:54 GMT, Alexander Zuev wrote:
> Create implementation for Slider and Stepper accessibility protocols.
> Fix mapping.
> Fix performAction parameter type in declaration.
perhaps the logging statements should be added (commented out) as a part of
this PR.
-
On Tue, 29 Aug 2023 10:10:54 GMT, Alexander Zuev wrote:
> Create implementation for Slider and Stepper accessibility protocols.
> Fix mapping.
> Fix performAction parameter type in declaration.
Yes, you read it correctly. Good question about how you can tell that it is
going through the new imp
On Tue, 29 Aug 2023 10:10:54 GMT, Alexander Zuev wrote:
> Create implementation for Slider and Stepper accessibility protocols.
> Fix mapping.
> Fix performAction parameter type in declaration.
Thank you for clarification, Kevin.
The two linked tickets, and the associated umbrella tickets talk a
On Tue, 29 Aug 2023 14:59:41 GMT, Andy Goryachev wrote:
> should there be an automated test for the added functionality?
Automated testing of the screen reader is not feasible. Even if it were, it
would be a separate enhancement to add accessibility tests. Btw, this PR isn't
providing new func
On Tue, 29 Aug 2023 10:10:54 GMT, Alexander Zuev wrote:
> Create implementation for Slider and Stepper accessibility protocols.
> Fix mapping.
> Fix performAction parameter type in declaration.
should there be an automated test for the added functionality?
-
PR Comment: https://git
On Tue, 29 Aug 2023 10:10:54 GMT, Alexander Zuev wrote:
> Create implementation for Slider and Stepper accessibility protocols.
> Fix mapping.
> Fix performAction parameter type in declaration.
Reviewers: @arapte @andy-goryachev-oracle
-
PR Comment: https://git.openjdk.org/jfx/pull
Create implementation for Slider and Stepper accessibility protocols.
Fix mapping.
Fix performAction parameter type in declaration.
-
Commit messages:
- 8313556: Create implementation of NSAccessibilitySlider protocol
Changes: https://git.openjdk.org/jfx/pull/1226/files
Webrev: ht
36 matches
Mail list logo
