On Tue, 29 Aug 2023 14:59:41 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
> should there be an automated test for the added functionality? Automated testing of the screen reader is not feasible. Even if it were, it would be a separate enhancement to add accessibility tests. Btw, this PR isn't providing new functionality. It is providing a new implementation of existing functionality. Having said that, it would be helpful for Alex to list the controls that will use the new implementation, so reviewers can test it manually. For this PR, I would imagine that the `Slider` and `Spinner` controls would be used to test the `NSAccessibilitySlider` and `NSAccessibilityStepper` protocols, respectively. Perhaps there are also other ways to hit the new code? ------------- PR Comment: https://git.openjdk.org/jfx/pull/1226#issuecomment-1697651507
