On Wed, 6 Sep 2023 10:21:14 GMT, Jose Pereda wrote:
> Clean backport of 8309470: Potential performance improvements in VirtualFlow
> Reviewed-by: kpk, angorya
Marked as reviewed by jvos (Reviewer).
-
PR Review: https://git.openjdk.org/jfx17u/pull/159#pullrequestreview-1613024999
Clean backport of 8309470: Potential performance improvements in VirtualFlow
Reviewed-by: kpk, angorya
-
Commit messages:
- 8309470: Potential performance improvements in VirtualFlow
Changes: https://git.openjdk.org/jfx17u/pull/159/files
Webrev: https://webrevs.openjdk.org/?repo=jf
On Thu, 8 Jun 2023 17:44:21 GMT, Karthik P K wrote:
> All the tests added here passes with the fix and fails without it. No issues
> now. Could have been some problem from my end.
Alright, thanks for the feedback!
-
PR Comment: https://git.openjdk.org/jfx/pull/1150#issuecomment-15
On Thu, 8 Jun 2023 15:59:13 GMT, Marius Hanl wrote:
>> This PR does two small improvements to `VirtualFlow`.
>> Until now, the `VirtualFlow` sometimes called the `computeHeight` or
>> `computeWidth` methods, although a fixed cell size is set and we therefore
>> don't need to call those method (
On Thu, 8 Jun 2023 06:47:44 GMT, Marius Hanl wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java
>> line 1954:
>>
>>> 1952: * Gets the breadth of a specific cell
>>> 1953: */
>>> 1954: double getCellBreadth(T cell) {
>>
>> is there a possibi
On Thu, 8 Jun 2023 15:59:13 GMT, Marius Hanl wrote:
>> This PR does two small improvements to `VirtualFlow`.
>> Until now, the `VirtualFlow` sometimes called the `computeHeight` or
>> `computeWidth` methods, although a fixed cell size is set and we therefore
>> don't need to call those method (
On Thu, 8 Jun 2023 15:59:13 GMT, Marius Hanl wrote:
>> This PR does two small improvements to `VirtualFlow`.
>> Until now, the `VirtualFlow` sometimes called the `computeHeight` or
>> `computeWidth` methods, although a fixed cell size is set and we therefore
>> don't need to call those method (
> This PR does two small improvements to `VirtualFlow`.
> Until now, the `VirtualFlow` sometimes called the `computeHeight` or
> `computeWidth` methods, although a fixed cell size is set and we therefore
> don't need to call those method (and never should do, as we may don't get the
> expected r
On Thu, 8 Jun 2023 13:41:04 GMT, Karthik P K wrote:
> Tested the changes in MacOS 13.3.1, I'm seeing failure ...
I added two more test that directly fail if those methods are called. You will
get a better stacktrace from them. If this issue still appears, please paste it
here. :)
On Thu, 8 Jun 2023 13:41:56 GMT, Karthik P K wrote:
>> Marius Hanl has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> JDK-8309470: Improved Tests
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java
> line 3
On Thu, 8 Jun 2023 15:43:00 GMT, Marius Hanl wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/VirtualFlowTest.java
>> line 1542:
>>
>>> 1540: @Override
>>> 1541: protected double computeMinHeight(double width) {
>>> 1542: ret
> This PR does two small improvements to `VirtualFlow`.
> Until now, the `VirtualFlow` sometimes called the `computeHeight` or
> `computeWidth` methods, although a fixed cell size is set and we therefore
> don't need to call those method (and never should do, as we may don't get the
> expected r
On Thu, 8 Jun 2023 07:18:22 GMT, Marius Hanl wrote:
>> This PR does two small improvements to `VirtualFlow`.
>> Until now, the `VirtualFlow` sometimes called the `computeHeight` or
>> `computeWidth` methods, although a fixed cell size is set and we therefore
>> don't need to call those method (
On Thu, 8 Jun 2023 07:18:22 GMT, Marius Hanl wrote:
>> This PR does two small improvements to `VirtualFlow`.
>> Until now, the `VirtualFlow` sometimes called the `computeHeight` or
>> `computeWidth` methods, although a fixed cell size is set and we therefore
>> don't need to call those method (
> This PR does two small improvements to `VirtualFlow`.
> Until now, the `VirtualFlow` sometimes called the `computeHeight` or
> `computeWidth` methods, although a fixed cell size is set and we therefore
> don't need to call those method (and never should do, as we may don't get the
> expected r
On Thu, 8 Jun 2023 00:07:20 GMT, Andy Goryachev wrote:
> I don't see any ill effects in the MonkeyTester. There is still a bit of lag
> with 10,000,000 row model, same as before.
Yeah for me as well. This is a very minor improvement and actually with this PR
the following assertion is now true
> This PR does two small improvements to `VirtualFlow`.
> Until now, the `VirtualFlow` sometimes called the `computeHeight` or
> `computeWidth` methods, although a fixed cell size is set and we therefore
> don't need to call those method (and never should do, as we may don't get the
> expected r
On Thu, 8 Jun 2023 06:46:28 GMT, Marius Hanl wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/VirtualFlowTest.java
>> line 1579:
>>
>>> 1577: @Test
>>> 1578: public void
>>> testComputeWidthShouldNotBeCalledWhenFixedCellSizeIsSet() {
>>> 1579: int
On Thu, 8 Jun 2023 00:01:02 GMT, Andy Goryachev wrote:
>> This PR does two small improvements to `VirtualFlow`.
>> Until now, the `VirtualFlow` sometimes called the `computeHeight` or
>> `computeWidth` methods, although a fixed cell size is set and we therefore
>> don't need to call those metho
On Wed, 7 Jun 2023 20:59:01 GMT, Marius Hanl wrote:
> This PR does two small improvements to `VirtualFlow`.
> Until now, the `VirtualFlow` sometimes called the `computeHeight` or
> `computeWidth` methods, although a fixed cell size is set and we therefore
> don't need to call those method (and
On Wed, 7 Jun 2023 20:59:01 GMT, Marius Hanl wrote:
> This PR does two small improvements to `VirtualFlow`.
> Until now, the `VirtualFlow` sometimes called the `computeHeight` or
> `computeWidth` methods, although a fixed cell size is set and we therefore
> don't need to call those method (and
This PR does two small improvements to `VirtualFlow`.
Until now, the `VirtualFlow` sometimes called the `computeHeight` or
`computeWidth` methods, although a fixed cell size is set and we therefore
don't need to call those method (and never should do, as we may don't get the
expected result and
22 matches
Mail list logo
