On Thu, 8 Jun 2023 15:59:13 GMT, Marius Hanl <mh...@openjdk.org> wrote:
>> This PR does two small improvements to `VirtualFlow`. >> Until now, the `VirtualFlow` sometimes called the `computeHeight` or >> `computeWidth` methods, although a fixed cell size is set and we therefore >> don't need to call those method (and never should do, as we may don't get >> the expected result and mix computed sizes with the fixed cell size). >> >> Added tests that fail before and pass now. They check that the >> `computeHeight` or `computeWidth` (non vertical flow) are never called when >> a fixed cell size is set. > > Marius Hanl has updated the pull request incrementally with one additional > commit since the last revision: > > JDK-8309470: Added fail tests lgtm ------------- Marked as reviewed by angorya (Reviewer). PR Review: https://git.openjdk.org/jfx/pull/1150#pullrequestreview-1470496391
