Integrated: JDK-8284445: macOS 12 prints a warning when a function key shortcut is assigned to a menu

2023-11-08 Thread vlaaad
On Mon, 2 Oct 2023 12:51:52 GMT, vlaaad wrote: > This PR addresses [JDK-8284445](https://bugs.openjdk.org/browse/JDK-8284445). > > Context: the warning might be more important than it seems. Our JavaFX-based > desktop app has [an issue](https://github.com/defold/defold/issues/784

Re: RFR: JDK-8284445: macOS 12 prints a warning when a function key shortcut is assigned to a menu [v3]

2023-11-08 Thread vlaaad
On Tue, 31 Oct 2023 08:05:56 GMT, vlaaad wrote: >> This PR addresses [JDK-8284445](https://bugs.openjdk.org/browse/JDK-8284445). >> >> Context: the warning might be more important than it seems. Our JavaFX-based >> desktop app has [an issue](https://github.com/d

Re: RFR: JDK-8284445: macOS 12 prints a warning when a function key shortcut is assigned to a menu [v3]

2023-11-06 Thread vlaaad
On Thu, 2 Nov 2023 11:43:06 GMT, Ambarish Rapte wrote: >> vlaaad has updated the pull request incrementally with one additional commit >> since the last revision: >> >> Don't use NSFunctionKeyMask as modifier at all > > When a function key is p

Re: RFR: JDK-8284445: macOS 12 prints a warning when a function key shortcut is assigned to a menu [v3]

2023-11-02 Thread vlaaad
On Tue, 31 Oct 2023 08:05:56 GMT, vlaaad wrote: >> This PR addresses [JDK-8284445](https://bugs.openjdk.org/browse/JDK-8284445). >> >> Context: the warning might be more important than it seems. Our JavaFX-based >> desktop app has [an issue](https://github.com/d

Re: RFR: JDK-8284445: macOS 12 prints a warning when a function key shortcut is assigned to a menu [v3]

2023-11-02 Thread vlaaad
On Thu, 2 Nov 2023 11:43:06 GMT, Ambarish Rapte wrote: >> vlaaad has updated the pull request incrementally with one additional commit >> since the last revision: >> >> Don't use NSFunctionKeyMask as modifier at all > > When a function key is p

Re: RFR: JDK-8284445: macOS 12 prints a warning when a function key shortcut is assigned to a menu

2023-10-31 Thread vlaaad
On Sun, 22 Oct 2023 21:25:45 GMT, Martin Fox wrote: >> This PR addresses [JDK-8284445](https://bugs.openjdk.org/browse/JDK-8284445). >> >> Context: the warning might be more important than it seems. Our JavaFX-based >> desktop app has [an issue](https://github.com/defold/defold/issues/7845) —

Re: RFR: JDK-8284445: macOS 12 prints a warning when a function key shortcut is assigned to a menu [v2]

2023-10-31 Thread vlaaad
On Mon, 30 Oct 2023 18:08:52 GMT, Martin Fox wrote: >> vlaaad has updated the pull request incrementally with one additional commit >> since the last revision: >> >> Revert java changes and set NSFunctionKeyMask for non-F1-F24 menu items > > modules/javafx.grap

Re: RFR: JDK-8284445: macOS 12 prints a warning when a function key shortcut is assigned to a menu [v3]

2023-10-31 Thread vlaaad
s reminded me of the warnings we get about `NSEventModifierFlagFunction > specified to -setKeyEquivalentModifierMask` for such shortcuts. I > experimented with removing the modifier for these shortcuts, and it helped > with our issue! vlaaad has updated the pull request incrementally w

Re: RFR: JDK-8284445: macOS 12 prints a warning when a function key shortcut is assigned to a menu

2023-10-30 Thread vlaaad
On Sun, 22 Oct 2023 21:25:45 GMT, Martin Fox wrote: >> This PR addresses [JDK-8284445](https://bugs.openjdk.org/browse/JDK-8284445). >> >> Context: the warning might be more important than it seems. Our JavaFX-based >> desktop app has [an issue](https://github.com/defold/defold/issues/7845) —

Re: RFR: JDK-8284445: macOS 12 prints a warning when a function key shortcut is assigned to a menu [v2]

2023-10-30 Thread vlaaad
s reminded me of the warnings we get about `NSEventModifierFlagFunction > specified to -setKeyEquivalentModifierMask` for such shortcuts. I > experimented with removing the modifier for these shortcuts, and it helped > with our issue! vlaaad has updated the pull request incrementally w

RFR: JDK-8284445: macOS 12 prints a warning when a function key shortcut is assigned to a menu

2023-10-20 Thread vlaaad
This PR addresses [JDK-8284445](https://bugs.openjdk.org/browse/JDK-8284445). Context: the warning might be more important than it seems. Our JavaFX-based desktop app has [an issue](https://github.com/defold/defold/issues/7845) — when the user opens 2 instances of the app, one of the instances h

Re: RFR: JDK-8284445: macOS 12 prints a warning when a function key shortcut is assigned to a menu

2023-10-20 Thread vlaaad
On Mon, 2 Oct 2023 12:51:52 GMT, vlaaad wrote: > This PR addresses [JDK-8284445](https://bugs.openjdk.org/browse/JDK-8284445). > > Context: the warning might be more important than it seems. Our JavaFX-based > desktop app has [an issue](https://github.com/defold/defold/issues/784